| Message ID | 1466174835-17703-1-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 17/06/16 15:47, Ben Dooks wrote: > If both CONFIG_CPU_IDLE or CONFIG_SOC_IMX6Q are not set > then the imx6q_cpuidle_fec_irqs_used() and other functions > should be marked static inline to avoid the following > warnings whilst building drivers/net/ethernet/freescale: > > include/soc/imx/cpuidle.h:21:6: warning: symbol 'imx6q_cpuidle_fec_irqs_used' was not declared. Should it be static? > include/soc/imx/cpuidle.h:22:6: warning: symbol 'imx6q_cpuidle_fec_irqs_unused' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Apologies, failed to properly merge the inline fix in. Resend as V2.
diff --git a/include/soc/imx/cpuidle.h b/include/soc/imx/cpuidle.h index 986a482..8d393cd 100644 --- a/include/soc/imx/cpuidle.h +++ b/include/soc/imx/cpuidle.h @@ -18,8 +18,8 @@ void imx6q_cpuidle_fec_irqs_used(void); void imx6q_cpuidle_fec_irqs_unused(void); #else -void imx6q_cpuidle_fec_irqs_used(void) { } -void imx6q_cpuidle_fec_irqs_unused(void) { } +static void imx6q_cpuidle_fec_irqs_used(void) { } +static void imx6q_cpuidle_fec_irqs_unused(void) { } #endif #endif /* __SOC_IMX_CPUIDLE_H__ */
If both CONFIG_CPU_IDLE or CONFIG_SOC_IMX6Q are not set then the imx6q_cpuidle_fec_irqs_used() and other functions should be marked static inline to avoid the following warnings whilst building drivers/net/ethernet/freescale: include/soc/imx/cpuidle.h:21:6: warning: symbol 'imx6q_cpuidle_fec_irqs_used' was not declared. Should it be static? include/soc/imx/cpuidle.h:22:6: warning: symbol 'imx6q_cpuidle_fec_irqs_unused' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <kernel@pengutronix.de> Cc: linux-arm-kernel@lists.infradead.org --- include/soc/imx/cpuidle.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)