diff mbox

[v2] dell-wmi: add a WMI event code for display on/off

Message ID 1466135067-28566-1-git-send-email-alex.hung@canonical.com (mailing list archive)
State Accepted, archived
Headers show

Commit Message

Alex Hung June 17, 2016, 3:44 a.m. UTC 
Some new Dell AIO systems have a button that generates WMI evnet
that is to be used to turn LCD on/off.

Acked-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Alex Hung <alex.hung@canonical.com>
---
 drivers/platform/x86/dell-wmi.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Darren Hart June 17, 2016, 6:19 p.m. UTC | #1 
On Fri, Jun 17, 2016 at 11:44:27AM +0800, Alex Hung wrote:
> Some new Dell AIO systems have a button that generates WMI evnet
> that is to be used to turn LCD on/off.
> 
> Acked-by: Pali Rohár <pali.rohar@gmail.com>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
>  drivers/platform/x86/dell-wmi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
> index b8ad055..8e6c357 100644
> --- a/drivers/platform/x86/dell-wmi.c
> +++ b/drivers/platform/x86/dell-wmi.c
> @@ -133,6 +133,9 @@ static const struct key_entry dell_wmi_keymap_type_0000[] __initconst = {
>  	/* Audio panel key */
>  	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
>  
> +	/* Monitor On/Off Control key */

I've changed this to:

	/* LCD Display On/Off Control Key */

As "Monitor" read like external display to me. I can change this back if you
strongly disagree.

Queued for 4.8.
Pali Rohár June 17, 2016, 6:50 p.m. UTC | #2 
On Friday 17 June 2016 05:44:27 Alex Hung wrote:
> @@ -133,6 +133,9 @@ static const struct key_entry
> dell_wmi_keymap_type_0000[] __initconst = { /* Audio panel key */
>  	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
> 
> +	/* Monitor On/Off Control key */
> +	{ KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },

Darren, I would suggest small alignment (as for 0xe026):

   	{ KE_KEY,    0xe027, { KEY_DISPLAYTOGGLE } },

>  	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
Darren Hart June 21, 2016, 4:24 p.m. UTC | #3 
On Fri, Jun 17, 2016 at 08:50:27PM +0200, Pali Rohár wrote:
> On Friday 17 June 2016 05:44:27 Alex Hung wrote:
> > @@ -133,6 +133,9 @@ static const struct key_entry
> > dell_wmi_keymap_type_0000[] __initconst = { /* Audio panel key */
> >  	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
> > 
> > +	/* Monitor On/Off Control key */
> > +	{ KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
> 
> Darren, I would suggest small alignment (as for 0xe026):

Done.

> 
>    	{ KE_KEY,    0xe027, { KEY_DISPLAYTOGGLE } },
> 
> >  	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
> 
> -- 
> Pali Rohár
> pali.rohar@gmail.com
diff mbox

Patch

diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c
index b8ad055..8e6c357 100644
--- a/drivers/platform/x86/dell-wmi.c
+++ b/drivers/platform/x86/dell-wmi.c
@@ -133,6 +133,9 @@  static const struct key_entry dell_wmi_keymap_type_0000[] __initconst = {
 	/* Audio panel key */
 	{ KE_IGNORE, 0xe026, { KEY_RESERVED } },
 
+	/* Monitor On/Off Control key */
+	{ KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
+
 	/* Untested, Multimedia key on Dell Vostro 3560 */
 	/* { KE_IGNORE, 0xe028, { KEY_RESERVED } }, */