| Message ID | 1466522179-22198-2-git-send-email-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote: > > -struct syscore_ops mvebu_mbus_syscore_ops = { > +static struct syscore_ops mvebu_mbus_syscore_ops = { > .suspend = mvebu_mbus_suspend, > .resume = mvebu_mbus_resume, > }; > Looks good, but I immediately thought it should be "const" as well. Unfortunately there is a list_head in them, so that isn't easy, but if anyone has an idea for how to make these all const, that would be nice. Anyway, that shouldn't stop your patch from getting merged, so Acked-by: Arnd Bergmann <arnd@arndb.de> (also for patch 1/2). Arnd
Hi Ben, On mar., juin 21 2016, Arnd Bergmann <arnd@arndb.de> wrote: > On Tuesday, June 21, 2016 4:16:19 PM CEST Ben Dooks wrote: >> >> -struct syscore_ops mvebu_mbus_syscore_ops = { >> +static struct syscore_ops mvebu_mbus_syscore_ops = { >> .suspend = mvebu_mbus_suspend, >> .resume = mvebu_mbus_resume, >> }; >> > > > Looks good, but I immediately thought it should be "const" as well. > Unfortunately there is a list_head in them, so that isn't easy, > but if anyone has an idea for how to make these all const, that > would be nice. > > Anyway, that shouldn't stop your patch from getting merged, so > > Acked-by: Arnd Bergmann <arnd@arndb.de> > > (also for patch 1/2). So I applied both patch in mvebu/cleanup Thanks, Gregory > > Arnd
diff --git a/drivers/bus/mvebu-mbus.c b/drivers/bus/mvebu-mbus.c index 8cac3b8..c7f3969 100644 --- a/drivers/bus/mvebu-mbus.c +++ b/drivers/bus/mvebu-mbus.c @@ -1089,7 +1089,7 @@ static void mvebu_mbus_resume(void) } } -struct syscore_ops mvebu_mbus_syscore_ops = { +static struct syscore_ops mvebu_mbus_syscore_ops = { .suspend = mvebu_mbus_suspend, .resume = mvebu_mbus_resume, };
Make mvebu_mbus_syscore_ops static as it does not get used or declared outside mvebu-mbus.c to fix the following sparse warning: linux/drivers/bus/mvebu-mbus.c:1092:20: warning: symbol 'mvebu_mbus_syscore_ops' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Jason Cooper <jason@lakedaemon.net> Cc: Andrew Lunn <andrew@lunn.ch> Cc: Gregory CLEMENT <gregory.clement@free-electrons.com> Cc: Evan Wang <xswang@marvell.com> Cc: linux-kernel@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org --- drivers/bus/mvebu-mbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)