diff mbox

Xen 4.3, armhf, ocamlopt, wheezy

Message ID 22385.3593.873211.260433@mariner.uk.xensource.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson June 27, 2016, 11:29 a.m. UTC 
Since around January we have been testing our Xen 4.3 stable branches
(which still receive security support until very soon) with a version
of Debian which was current when 4.3 was also current - ie, wheezy.

Debian wheezy has an `ocaml-nox' package, but it does not contain
`ocamlopt' on armhf.  There is code in `configure' in
xen.git#staging-4.3 to attempt to discover whether ocamlopt exists.
That code appears to work, correctly detecting that ocamlopt does not
exist - but then the build tries to use it anyway:

http://logs.test-lab.xenproject.org/osstest/logs/96291/build-armhf/5.ts-xen-build.log

I would like to get one final push of Xen 4.3 before it goes out of
security support.  I don't think this configuration bug in Xen 4.3 is
recently introduced.  I think that previous tests we were probably
using squeeze, which probably did not have ocaml at all, and that we
were using an osstest which didn't try to use it.

I propose to drop the ocaml package installation from osstest runs
using Debian squeeze or Debian wheezy.

Feel free to object, if you have a better plan.

Also, you might like to consider whether the logic in xen-unstable is
correct, wrt the use of ocamlopt.  I can't seem even there to find the
plumbing which makes use of the result of the configure check.

Thanks,
Ian.

From 6fb8fdd67de8a4ca2b3b26a93f1a6664e3e06a01 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Mon, 27 Jun 2016 12:25:14 +0100
Subject: [OSSTEST PATCH] ts-xen-build-prep: Do not install Ocaml on squeeze or
 wheezy

squeeze doesn't (didn't) have it at all.  wheezy doesn't have ocamlopt
on armhf, and the Xen build system (in the old branches where this is
relevant) seems not to be able to test this.

In any case we use these old Debian suites when testing old Xen
branches, which were (when they were current) built without ocaml.

This partially reverts "ts-xen-build-prep: Install Ocaml" bbe1a9b2a6c0.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: David Scott <dave@recoil.org>
CC: Jan Beulich <JBeulich@suse.com>
---
 ts-xen-build-prep | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Jan Beulich June 27, 2016, 3:33 p.m. UTC | #1 
>>> On 27.06.16 at 13:29, <ian.jackson@eu.citrix.com> wrote:
> Since around January we have been testing our Xen 4.3 stable branches
> (which still receive security support until very soon) with a version
> of Debian which was current when 4.3 was also current - ie, wheezy.
> 
> Debian wheezy has an `ocaml-nox' package, but it does not contain
> `ocamlopt' on armhf.  There is code in `configure' in
> xen.git#staging-4.3 to attempt to discover whether ocamlopt exists.
> That code appears to work, correctly detecting that ocamlopt does not
> exist - but then the build tries to use it anyway:
> 
> http://logs.test-lab.xenproject.org/osstest/logs/96291/build-armhf/5.ts-xen-buil 
> d.log
> 
> I would like to get one final push of Xen 4.3 before it goes out of
> security support.  I don't think this configuration bug in Xen 4.3 is
> recently introduced.  I think that previous tests we were probably
> using squeeze, which probably did not have ocaml at all, and that we
> were using an osstest which didn't try to use it.
> 
> I propose to drop the ocaml package installation from osstest runs
> using Debian squeeze or Debian wheezy.

Fine with me, fwiw.

Jan
David Scott June 27, 2016, 6:28 p.m. UTC | #2 
> On 27 Jun 2016, at 12:29, Ian Jackson <ian.jackson@eu.citrix.com> wrote:
> 
> Since around January we have been testing our Xen 4.3 stable branches
> (which still receive security support until very soon) with a version
> of Debian which was current when 4.3 was also current - ie, wheezy.
> 
> Debian wheezy has an `ocaml-nox' package, but it does not contain
> `ocamlopt' on armhf.  There is code in `configure' in
> xen.git#staging-4.3 to attempt to discover whether ocamlopt exists.
> That code appears to work, correctly detecting that ocamlopt does not
> exist - but then the build tries to use it anyway:
> 
> http://logs.test-lab.xenproject.org/osstest/logs/96291/build-armhf/5.ts-xen-build.log
> 
> I would like to get one final push of Xen 4.3 before it goes out of
> security support.  I don't think this configuration bug in Xen 4.3 is
> recently introduced.  I think that previous tests we were probably
> using squeeze, which probably did not have ocaml at all, and that we
> were using an osstest which didn't try to use it.
> 
> I propose to drop the ocaml package installation from osstest runs
> using Debian squeeze or Debian wheezy.
> 
> Feel free to object, if you have a better plan.

No objection from me.

> 
> Also, you might like to consider whether the logic in xen-unstable is
> correct, wrt the use of ocamlopt.  I can't seem even there to find the
> plumbing which makes use of the result of the configure check.

Thanks for the heads-up. I’ll take a look.

Cheers,
Dave



> 
> Thanks,
> Ian.
> 
> From 6fb8fdd67de8a4ca2b3b26a93f1a6664e3e06a01 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@eu.citrix.com>
> Date: Mon, 27 Jun 2016 12:25:14 +0100
> Subject: [OSSTEST PATCH] ts-xen-build-prep: Do not install Ocaml on squeeze or
> wheezy
> 
> squeeze doesn't (didn't) have it at all.  wheezy doesn't have ocamlopt
> on armhf, and the Xen build system (in the old branches where this is
> relevant) seems not to be able to test this.
> 
> In any case we use these old Debian suites when testing old Xen
> branches, which were (when they were current) built without ocaml.
> 
> This partially reverts "ts-xen-build-prep: Install Ocaml" bbe1a9b2a6c0.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: David Scott <dave@recoil.org>
> CC: Jan Beulich <JBeulich@suse.com>
> ---
> ts-xen-build-prep | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/ts-xen-build-prep b/ts-xen-build-prep
> index c8cebf4..0450811 100755
> --- a/ts-xen-build-prep
> +++ b/ts-xen-build-prep
> @@ -206,9 +206,11 @@ sub prep () {
>                       autoconf automake libtool xsltproc
>                       libxml2-utils libxml2-dev
>                       libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
> -                      ocaml-nox ocaml-findlib
>                       ccache nasm checkpolicy ebtables);
> 
> +    if ($ho->{Suite} !~ m/squeeze|wheezy/) {
> +	push(@packages, qw(ocaml-nox ocaml-findlib));
> +    }
>     if ($ho->{Suite} =~ m/wheezy|squeeze|lenny/) {
> 	push(@packages, "libnl-dev");
>     } else {
> -- 
> 2.1.4
>
diff mbox

Patch

diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index c8cebf4..0450811 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -206,9 +206,11 @@  sub prep () {
                       autoconf automake libtool xsltproc
                       libxml2-utils libxml2-dev
                       libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
-                      ocaml-nox ocaml-findlib
                       ccache nasm checkpolicy ebtables);
 
+    if ($ho->{Suite} !~ m/squeeze|wheezy/) {
+	push(@packages, qw(ocaml-nox ocaml-findlib));
+    }
     if ($ho->{Suite} =~ m/wheezy|squeeze|lenny/) {
 	push(@packages, "libnl-dev");
     } else {