| Message ID | 1466670690-77458-1-git-send-email-allen_hung@dell.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 06/23/2016 01:31 AM, Allen Hung wrote: > This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection > if device implements confidence usage") > > The commit enables palm rejection for Win8 Precision Touchpad devices but > the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very > properly. This quirk is originally designed for some WIn7 touchscreens. Use > of this for a Win8 Precision Touchpad will cause unexpected pointer jumping > problem. > > Signed-off-by: Allen Hung <allen_hung@dell.com> > --- > drivers/hid/hid-multitouch.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c > index 95b7d61..4ef7006 100644 > --- a/drivers/hid/hid-multitouch.c > +++ b/drivers/hid/hid-multitouch.c > @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi, > mt_store_field(usage, td, hi); > return 1; > case HID_DG_CONFIDENCE: > - if (cls->name == MT_CLS_WIN_8 && > - field->application == HID_DG_TOUCHPAD) { > - cls->quirks &= ~MT_QUIRK_ALWAYS_VALID; > - cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE; > - } > mt_store_field(usage, td, hi); > return 1; > case HID_DG_TIPSWITCH: > This and patch 2 are: Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3 (And I'm curious why 1.4.3 seems to have been pulled. Might it have been this issue? For better or for worse, I upgraded in the narrow window in which it was available on Dell's website.) --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Andy, > (And I'm curious why 1.4.3 seems to have been pulled. Might it have > been this issue? For better or for worse, I upgraded in the narrow > window in which it was available on Dell's website.) It wasn't pulled in relation to this issue. It was something else. Nothing I'm aware of in the 1.4.3 BIOS changes should have made this any worse than previously. Maybe something else in the stack moved that exaggerated the problem or you started palming the touchpad more? Your Tested-by: is that meaning that it's fixed entirely for you? Not getting stuck at all now? Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 27, 2016 at 10:55 AM, Andy Lutomirski <luto@kernel.org> wrote: > On 06/23/2016 01:31 AM, Allen Hung wrote: >> >> This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection >> if device implements confidence usage") >> >> The commit enables palm rejection for Win8 Precision Touchpad devices but >> the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very >> properly. This quirk is originally designed for some WIn7 touchscreens. >> Use >> of this for a Win8 Precision Touchpad will cause unexpected pointer >> jumping >> problem. >> >> Signed-off-by: Allen Hung <allen_hung@dell.com> >> --- >> drivers/hid/hid-multitouch.c | 5 ----- >> 1 file changed, 5 deletions(-) >> >> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c >> index 95b7d61..4ef7006 100644 >> --- a/drivers/hid/hid-multitouch.c >> +++ b/drivers/hid/hid-multitouch.c >> @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device >> *hdev, struct hid_input *hi, >> mt_store_field(usage, td, hi); >> return 1; >> case HID_DG_CONFIDENCE: >> - if (cls->name == MT_CLS_WIN_8 && >> - field->application == HID_DG_TOUCHPAD) { >> - cls->quirks &= ~MT_QUIRK_ALWAYS_VALID; >> - cls->quirks |= >> MT_QUIRK_VALID_IS_CONFIDENCE; >> - } >> mt_store_field(usage, td, hi); >> return 1; >> case HID_DG_TIPSWITCH: >> > > This and patch 2 are: > > Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3 > > (And I'm curious why 1.4.3 seems to have been pulled. Might it have been > this issue? For better or for worse, I upgraded in the narrow window in > which it was available on Dell's website.) > I should amend that Tested-by slightly: these patches seem to make the problem merely about as bad as it was before. It's still not perfect -- I still occasionally get stuck touches. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi, I've applied the series to hid.git#for-4.7/upstream-fixes Thanks everybody,
On Mon, Jun 27, 2016 at 3:25 PM, Andy Lutomirski <luto@amacapital.net> wrote: > On Mon, Jun 27, 2016 at 10:55 AM, Andy Lutomirski <luto@kernel.org> wrote: >> >> This and patch 2 are: >> >> Tested-by: Andy Lutomirski <luto@kernel.org> # XPS 13 9350, BIOS 1.4.3 >> >> (And I'm curious why 1.4.3 seems to have been pulled. Might it have been >> this issue? For better or for worse, I upgraded in the narrow window in >> which it was available on Dell's website.) >> > > I should amend that Tested-by slightly: these patches seem to make the > problem merely about as bad as it was before. It's still not perfect > -- I still occasionally get stuck touches. On further investigation, I'm not getting stuck touches AFAICT. I'm experiencing an upgraded version of libinput being clever and incorrectly deciding that I middle-clicked. Sorry for the noise. https://bugs.freedesktop.org/show_bug.cgi?id=96710 --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> I've applied the series to hid.git#for-4.7/upstream-fixes
Hi Jiri,
Would you also submit this to -stable?
I think it should be generally applicable at least a few releases back
since Allen's original submit.
Thanks,
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 29 Jun 2016, Mario Limonciello wrote: > Would you also submit this to -stable? > I think it should be generally applicable at least a few releases back > since Allen's original submit. Both commits (already in Linus' tree as of today) contain the -stable kernel annotation.
> -----Original Message----- > From: Jiri Kosina [mailto:jikos@kernel.org] > Sent: Thursday, June 30, 2016 2:40 AM > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > Cc: Hung, Allen <Allen_Hung@Dell.com>; Benjamin Tissoires > <benjamin.tissoires@redhat.com>; linux-input@vger.kernel.org; LKML > <linux-kernel@vger.kernel.org> > Subject: Re: [1/2] Revert "HID: multitouch: enable palm rejection if device > implements confidence usage" > > On Wed, 29 Jun 2016, Mario Limonciello wrote: > > > Would you also submit this to -stable? > > I think it should be generally applicable at least a few releases back > > since Allen's original submit. > > Both commits (already in Linus' tree as of today) contain the -stable > kernel annotation. > > -- > Jiri Kosina > SUSE Labs Sorry I missed that, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c index 95b7d61..4ef7006 100644 --- a/drivers/hid/hid-multitouch.c +++ b/drivers/hid/hid-multitouch.c @@ -502,11 +502,6 @@ static int mt_touch_input_mapping(struct hid_device *hdev, struct hid_input *hi, mt_store_field(usage, td, hi); return 1; case HID_DG_CONFIDENCE: - if (cls->name == MT_CLS_WIN_8 && - field->application == HID_DG_TOUCHPAD) { - cls->quirks &= ~MT_QUIRK_ALWAYS_VALID; - cls->quirks |= MT_QUIRK_VALID_IS_CONFIDENCE; - } mt_store_field(usage, td, hi); return 1; case HID_DG_TIPSWITCH:
This reverts commit 25a84db15b3f ("HID: multitouch: enable palm rejection if device implements confidence usage") The commit enables palm rejection for Win8 Precision Touchpad devices but the quirk MT_QUIRK_VALID_IS_CONFIDENCE it is using is not working very properly. This quirk is originally designed for some WIn7 touchscreens. Use of this for a Win8 Precision Touchpad will cause unexpected pointer jumping problem. Signed-off-by: Allen Hung <allen_hung@dell.com> --- drivers/hid/hid-multitouch.c | 5 ----- 1 file changed, 5 deletions(-)