| Message ID | 1466832839-32248-1-git-send-email-shc_work@mail.ru (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sat, Jun 25, 2016 at 08:33:59AM +0300, Alexander Shiyan wrote: > Signed-off-by: Alexander Shiyan <shc_work@mail.ru> No changelog? Please do explain why this is redundant... > --- > drivers/dma/imx-sdma.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c > index 0f6fd42..409d858 100644 > --- a/drivers/dma/imx-sdma.c > +++ b/drivers/dma/imx-sdma.c > @@ -999,8 +999,6 @@ static int sdma_config_channel(struct dma_chan *chan) > } else > __set_bit(sdmac->event_id0, sdmac->event_mask); > > - /* Watermark Level */ > - sdmac->watermark_level |= sdmac->watermark_level; > /* Address */ > sdmac->shp_addr = sdmac->per_address; > sdmac->per_addr = sdmac->per_address2; > -- > 2.4.9 >
PtCS0YLQvtGA0L3QuNC6LCAyOCDQuNGO0L3RjyAyMDE2LCA2OjM2ICswMzowMCDQvtGCIFZpbm9k IEtvdWwgPHZpbm9kLmtvdWxAaW50ZWwuY29tPjoKPgo+T24gU2F0LCBKdW4gMjUsIDIwMTYgYXQg MDg6MzM6NTlBTSArMDMwMCwgQWxleGFuZGVyIFNoaXlhbiB3cm90ZToKPj4gU2lnbmVkLW9mZi1i eTogQWxleGFuZGVyIFNoaXlhbiA8IHNoY193b3JrQG1haWwucnUgPgo+Cj5ObyBjaGFuZ2Vsb2c/ IFBsZWFzZSBkbyBleHBsYWluIHdoeSB0aGlzIGlzIHJlZHVuZGFudC4uLgoKSSBjYW4gbm90IGV2 ZW4gaW1hZ2luZSB3aGF0IGl0IHdvdWxkIGJlIHBvc3NpYmxlIHRvIGFkZCBpbiB0aGUgZGVzY3Jp cHRpb24sCmluIGFkZGl0aW9uIHRvIHRoZSBzdWJqZWN0LgpUaGUgcGF0Y2ggY29uc2lzdHMgb2Yg b25lIGxpbmUgd2hpY2ggc3BlYWtzIGZvciBpdHNlbGYuClN1Y2ggY2hhbmdlIHJlYWxseSBuZWVk IHRvIGV4cGxhaW4/Cgo+PiAtLS0KPj4gIGRyaXZlcnMvZG1hL2lteC1zZG1hLmMgfCAyIC0tCj4+ ICAxIGZpbGUgY2hhbmdlZCwgMiBkZWxldGlvbnMoLSkKPj4gCj4+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2RtYS9pbXgtc2RtYS5jIGIvZHJpdmVycy9kbWEvaW14LXNkbWEuYwo+PiBpbmRleCAwZjZm ZDQyLi40MDlkODU4IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2RtYS9pbXgtc2RtYS5jCj4+ICsr KyBiL2RyaXZlcnMvZG1hL2lteC1zZG1hLmMKPj4gQEAgLTk5OSw4ICs5OTksNiBAQCBzdGF0aWMg aW50IHNkbWFfY29uZmlnX2NoYW5uZWwoc3RydWN0IGRtYV9jaGFuICpjaGFuKQo+PiAgfSBlbHNl Cj4+ICBfX3NldF9iaXQoc2RtYWMtPmV2ZW50X2lkMCwgc2RtYWMtPmV2ZW50X21hc2spOwo+PiAK Pj4gLS8qIFdhdGVybWFyayBMZXZlbCAqLwo+PiAtc2RtYWMtPndhdGVybWFya19sZXZlbCB8PSBz ZG1hYy0+d2F0ZXJtYXJrX2xldmVsOwo+PiAgLyogQWRkcmVzcyAqLwo+PiAgc2RtYWMtPnNocF9h ZGRyID0gc2RtYWMtPnBlcl9hZGRyZXNzOwo+PiAgc2RtYWMtPnBlcl9hZGRyID0gc2RtYWMtPnBl cl9hZGRyZXNzMjsKCi0tLQoK -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, On Fri, Jul 01, 2016 at 10:10:24PM +0300, Alexander Shiyan wrote: > >Вторник, 28 июня 2016, 6:36 +03:00 от Vinod Koul <vinod.koul@intel.com>: > > > >On Sat, Jun 25, 2016 at 08:33:59AM +0300, Alexander Shiyan wrote: > >> Signed-off-by: Alexander Shiyan < shc_work@mail.ru > > > > >No changelog? Please do explain why this is redundant... > > I can not even imagine what it would be possible to add in the description, > in addition to the subject. > The patch consists of one line which speaks for itself. > Such change really need to explain? Something like: An expression v |= v with v being an unsigned int has no effect. Removing it doesn't change the generated code (tested with gcc 5.1). would be great. Best regards Uwe
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 0f6fd42..409d858 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -999,8 +999,6 @@ static int sdma_config_channel(struct dma_chan *chan) } else __set_bit(sdmac->event_id0, sdmac->event_mask); - /* Watermark Level */ - sdmac->watermark_level |= sdmac->watermark_level; /* Address */ sdmac->shp_addr = sdmac->per_address; sdmac->per_addr = sdmac->per_address2;
Signed-off-by: Alexander Shiyan <shc_work@mail.ru> --- drivers/dma/imx-sdma.c | 2 -- 1 file changed, 2 deletions(-)