diff mbox

target-arm/arm-semi.c: In SYS_HEAPINFO use correct type for 'limit'

Message ID 1467650942-28706-1-git-send-email-peter.maydell@linaro.org (mailing list archive)
State New, archived
Headers show

Commit Message

Peter Maydell July 4, 2016, 4:49 p.m. UTC
In commit f5666418c4 most of the SYS_HEAPINFO implementation was
fixed to use target_ulong rather than uint32_t, but the 'limit'
variable was not changed.

Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This was actually pointed out in code review for the original
patch, but I accidentally forgot to make the change when I
applied the patch to the target-arm queue :-(
---
 target-arm/arm-semi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Laurent Desnogues July 4, 2016, 5:02 p.m. UTC | #1
On Mon, Jul 4, 2016 at 6:49 PM, Peter Maydell <peter.maydell@linaro.org> wrote:
> In commit f5666418c4 most of the SYS_HEAPINFO implementation was
> fixed to use target_ulong rather than uint32_t, but the 'limit'
> variable was not changed.
>
> Reported-by: Laurent Desnogues <laurent.desnogues@gmail.com>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Laurent Desnogues <laurent.desnogues@gmail.com>

Thanks,

Laurent

> ---
> This was actually pointed out in code review for the original
> patch, but I accidentally forgot to make the change when I
> applied the patch to the target-arm queue :-(
> ---
>  target-arm/arm-semi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c
> index d50726f..7cac873 100644
> --- a/target-arm/arm-semi.c
> +++ b/target-arm/arm-semi.c
> @@ -565,7 +565,7 @@ target_ulong do_arm_semihosting(CPUARMState *env)
>      case TARGET_SYS_HEAPINFO:
>          {
>              target_ulong retvals[4];
> -            uint32_t limit;
> +            target_ulong limit;
>              int i;
>
>              GET_ARG(0);
> --
> 1.9.1
>
diff mbox

Patch

diff --git a/target-arm/arm-semi.c b/target-arm/arm-semi.c
index d50726f..7cac873 100644
--- a/target-arm/arm-semi.c
+++ b/target-arm/arm-semi.c
@@ -565,7 +565,7 @@  target_ulong do_arm_semihosting(CPUARMState *env)
     case TARGET_SYS_HEAPINFO:
         {
             target_ulong retvals[4];
-            uint32_t limit;
+            target_ulong limit;
             int i;
 
             GET_ARG(0);