diff mbox

fs: btrfs: Replace -ENOENT by -ERANGE in btrfs_get_acl()

Message ID 1467520810-11027-1-git-send-email-salah.triki@gmail.com (mailing list archive)
State Accepted
Headers show

Commit Message

Salah Triki July 3, 2016, 4:40 a.m. UTC 
size contains the value returned by posix_acl_from_xattr(), which
returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
replace -ENOENT by -ERANGE.

Signed-off-by: Salah Triki <salah.triki@gmail.com>
---
 fs/btrfs/acl.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Sterba July 4, 2016, 5:53 p.m. UTC | #1 
On Sun, Jul 03, 2016 at 05:40:10AM +0100, Salah Triki wrote:
> size contains the value returned by posix_acl_from_xattr(), which
> returns -ERANGE, -ENODATA, zero, or an integer greater than zero. So
> replace -ENOENT by -ERANGE.
> 
> Signed-off-by: Salah Triki <salah.triki@gmail.com>

Reviewed-by: David Sterba <dsterba@suse.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 67a6077..53bb7af 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -55,8 +55,7 @@  struct posix_acl *btrfs_get_acl(struct inode *inode, int type)
 	}
 	if (size > 0) {
 		acl = posix_acl_from_xattr(&init_user_ns, value, size);
-	} else if (size == -ENOENT || size == -ENODATA || size == 0) {
-		/* FIXME, who returns -ENOENT?  I think nobody */
+	} else if (size == -ERANGE || size == -ENODATA || size == 0) {
 		acl = NULL;
 	} else {
 		acl = ERR_PTR(-EIO);