| Message ID | 1467734999-21389-1-git-send-email-monis@mellanox.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis@mellanox.com> wrote: > A line was unnecessarily broken and with bad indentation. > Also, unnecessary braces were removed. > > Fixes: 99c483da1a82 ('IB/rxe: QP request handling') Doug, is this commit ID gonna persist when you merge RXE to your for-4.8 branch and later when Linus pulls this? if not, no point to use it here, in that case, Moni, please remove it. > Signed-off-by: Moni Shoua <monis@mellanox.com> -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 6, 2016 at 12:52 AM, Or Gerlitz <gerlitz.or@gmail.com> wrote: > On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis@mellanox.com> wrote: >> A line was unnecessarily broken and with bad indentation. >> Also, unnecessary braces were removed. >> >> Fixes: 99c483da1a82 ('IB/rxe: QP request handling') > > Doug, is this commit ID gonna persist when you merge RXE to your > for-4.8 branch and later when Linus pulls this? if not, no point to > use it here, in that case, Moni, please remove it. > You are right Or. I added the "Fixes" line to help Doug decide which patch to squash to in case he decides to do that. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 7/6/2016 3:16 AM, Moni Shoua wrote: > On Wed, Jul 6, 2016 at 12:52 AM, Or Gerlitz <gerlitz.or@gmail.com> wrote: >> On Tue, Jul 5, 2016 at 7:09 PM, Moni Shoua <monis@mellanox.com> wrote: >>> A line was unnecessarily broken and with bad indentation. >>> Also, unnecessary braces were removed. >>> >>> Fixes: 99c483da1a82 ('IB/rxe: QP request handling') >> >> Doug, is this commit ID gonna persist when you merge RXE to your >> for-4.8 branch and later when Linus pulls this? if not, no point to >> use it here, in that case, Moni, please remove it. >> > > You are right Or. > I added the "Fixes" line to help Doug decide which patch to squash to > in case he decides to do that. > Applied and squashed.
diff --git a/drivers/infiniband/hw/rxe/rxe_req.c b/drivers/infiniband/hw/rxe/rxe_req.c index e945967..f78efa6 100644 --- a/drivers/infiniband/hw/rxe/rxe_req.c +++ b/drivers/infiniband/hw/rxe/rxe_req.c @@ -547,10 +547,8 @@ static void update_state(struct rxe_qp *qp, struct rxe_send_wqe *wqe, qp->req.opcode = pkt->opcode; - if (pkt->mask & RXE_END_MASK) { - qp->req.wqe_index = next_index(qp->sq.queue, - qp->req.wqe_index); - } + if (pkt->mask & RXE_END_MASK) + qp->req.wqe_index = next_index(qp->sq.queue, qp->req.wqe_index); qp->need_req_skb = 0;
A line was unnecessarily broken and with bad indentation. Also, unnecessary braces were removed. Fixes: 99c483da1a82 ('IB/rxe: QP request handling') Signed-off-by: Moni Shoua <monis@mellanox.com> --- drivers/infiniband/hw/rxe/rxe_req.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)