| Message ID | 1466769168-31602-1-git-send-email-tjakobi@math.uni-bielefeld.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Ping! - Tobias Tobias Jakobi wrote: > Currently enabling Exynos DRM support automatically pulls in > lots of fbdev dependencies. However these deps are > unnecessary since DRM core already enables them when > needed. > > Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > --- > drivers/gpu/drm/exynos/Kconfig | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig > index baddf33..590559c 100644 > --- a/drivers/gpu/drm/exynos/Kconfig > +++ b/drivers/gpu/drm/exynos/Kconfig > @@ -2,10 +2,6 @@ config DRM_EXYNOS > tristate "DRM Support for Samsung SoC EXYNOS Series" > depends on OF && DRM && (ARCH_S3C64XX || ARCH_EXYNOS || ARCH_MULTIPLATFORM) > select DRM_KMS_HELPER > - select DRM_KMS_FB_HELPER > - select FB_CFB_FILLRECT > - select FB_CFB_COPYAREA > - select FB_CFB_IMAGEBLIT > select VIDEOMODE_HELPERS > help > Choose this option if you have a Samsung SoC EXYNOS chipset. >
On Wed, Jul 06, 2016 at 03:51:21PM +0200, Tobias Jakobi wrote: > Ping! Applied to drm-misc, thanks for the patch. Aside: I think there's other drivers which get this wrong, with the generic support to make fbdev optional in the drm core none of this should be needed anywhere. Can I volunteer you to double check other Kconfig files in drm for the same mistake? Thanks, Daniel > > - Tobias > > Tobias Jakobi wrote: > > Currently enabling Exynos DRM support automatically pulls in > > lots of fbdev dependencies. However these deps are > > unnecessary since DRM core already enables them when > > needed. > > > > Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > > --- > > drivers/gpu/drm/exynos/Kconfig | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig > > index baddf33..590559c 100644 > > --- a/drivers/gpu/drm/exynos/Kconfig > > +++ b/drivers/gpu/drm/exynos/Kconfig > > @@ -2,10 +2,6 @@ config DRM_EXYNOS > > tristate "DRM Support for Samsung SoC EXYNOS Series" > > depends on OF && DRM && (ARCH_S3C64XX || ARCH_EXYNOS || ARCH_MULTIPLATFORM) > > select DRM_KMS_HELPER > > - select DRM_KMS_FB_HELPER > > - select FB_CFB_FILLRECT > > - select FB_CFB_COPYAREA > > - select FB_CFB_IMAGEBLIT > > select VIDEOMODE_HELPERS > > help > > Choose this option if you have a Samsung SoC EXYNOS chipset. > > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/exynos/Kconfig b/drivers/gpu/drm/exynos/Kconfig index baddf33..590559c 100644 --- a/drivers/gpu/drm/exynos/Kconfig +++ b/drivers/gpu/drm/exynos/Kconfig @@ -2,10 +2,6 @@ config DRM_EXYNOS tristate "DRM Support for Samsung SoC EXYNOS Series" depends on OF && DRM && (ARCH_S3C64XX || ARCH_EXYNOS || ARCH_MULTIPLATFORM) select DRM_KMS_HELPER - select DRM_KMS_FB_HELPER - select FB_CFB_FILLRECT - select FB_CFB_COPYAREA - select FB_CFB_IMAGEBLIT select VIDEOMODE_HELPERS help Choose this option if you have a Samsung SoC EXYNOS chipset.
Currently enabling Exynos DRM support automatically pulls in lots of fbdev dependencies. However these deps are unnecessary since DRM core already enables them when needed. Signed-off-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> --- drivers/gpu/drm/exynos/Kconfig | 4 ---- 1 file changed, 4 deletions(-)