| Message ID | 1467882386-40544-4-git-send-email-dawei.chien@mediatek.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote: > This adds the thermal controller and auxadc nodes > to the Mediatek MT2701 dtsi file. > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > --- > This patch depned on: > https://patchwork.kernel.org/patch/9213545/ > --- > arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > index 2ac8b50..0834a23 100644 > --- a/arch/arm/boot/dts/mt2701.dtsi > +++ b/arch/arm/boot/dts/mt2701.dtsi > @@ -77,6 +77,36 @@ > #clock-cells = <0>; > }; > > + thermal-zones { > + cpu_thermal: cpu_thermal { > + polling-delay-passive = <1000>; /* milliseconds */ > + polling-delay = <1000>; /* milliseconds */ > + > + thermal-sensors = <&thermal 0>; > + sustainable-power = <1000>; > + > + trips { > + threshold: trip-point@0 { > + temperature = <68000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + target: trip-point@1 { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu_crit: cpu_crit@0 { > + temperature = <115000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + }; > + are there any corresponding cooling-maps? > timer { > compatible = "arm,armv7-timer"; > interrupt-parent = <&gic>; > @@ -183,4 +213,17 @@ > clocks = <&uart_clk>; > status = "disabled"; > }; > + > + thermal: thermal@1100b000 { > + #thermal-sensor-cells = <0>; > + compatible = "mediatek,mt2701-thermal"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; > + clock-names = "therm", "auxadc"; > + resets = <&pericfg 0x10>; > + reset-names = "therm"; > + mediatek,auxadc = <&auxadc>; > + mediatek,apmixedsys = <&apmixedsys>; > + }; > }; >
Dear Keerthy, On Thu, 2016-07-07 at 17:39 +0530, Keerthy wrote: > > On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote: > > This adds the thermal controller and auxadc nodes > > to the Mediatek MT2701 dtsi file. > > > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > > --- > > This patch depned on: > > https://patchwork.kernel.org/patch/9213545/ > > --- > > arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > > index 2ac8b50..0834a23 100644 > > --- a/arch/arm/boot/dts/mt2701.dtsi > > +++ b/arch/arm/boot/dts/mt2701.dtsi > > @@ -77,6 +77,36 @@ > > #clock-cells = <0>; > > }; > > > > + thermal-zones { > > + cpu_thermal: cpu_thermal { > > + polling-delay-passive = <1000>; /* milliseconds */ > > + polling-delay = <1000>; /* milliseconds */ > > + > > + thermal-sensors = <&thermal 0>; > > + sustainable-power = <1000>; > > + > > + trips { > > + threshold: trip-point@0 { > > + temperature = <68000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + target: trip-point@1 { > > + temperature = <85000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + cpu_crit: cpu_crit@0 { > > + temperature = <115000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + }; > > + > > are there any corresponding cooling-maps? Since MT2701 does not register CPUFREQ cooling device and its' own device node, I could not add cooling-maps so far. Could we add cooling map after CPUFREQ ready, thank you. > > > timer { > > compatible = "arm,armv7-timer"; > > interrupt-parent = <&gic>; > > @@ -183,4 +213,17 @@ > > clocks = <&uart_clk>; > > status = "disabled"; > > }; > > + > > + thermal: thermal@1100b000 { > > + #thermal-sensor-cells = <0>; > > + compatible = "mediatek,mt2701-thermal"; > > + reg = <0 0x1100b000 0 0x1000>; > > + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_LOW>; > > + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; > > + clock-names = "therm", "auxadc"; > > + resets = <&pericfg 0x10>; > > + reset-names = "therm"; > > + mediatek,auxadc = <&auxadc>; > > + mediatek,apmixedsys = <&apmixedsys>; > > + }; > > }; > >
On Monday 11 July 2016 02:26 PM, dawei chien wrote: > Dear Keerthy, > > On Thu, 2016-07-07 at 17:39 +0530, Keerthy wrote: >> >> On Thursday 07 July 2016 02:36 PM, Dawei Chien wrote: >>> This adds the thermal controller and auxadc nodes >>> to the Mediatek MT2701 dtsi file. >>> >>> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> >>> --- >>> This patch depned on: >>> https://patchwork.kernel.org/patch/9213545/ >>> --- >>> arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi >>> index 2ac8b50..0834a23 100644 >>> --- a/arch/arm/boot/dts/mt2701.dtsi >>> +++ b/arch/arm/boot/dts/mt2701.dtsi >>> @@ -77,6 +77,36 @@ >>> #clock-cells = <0>; >>> }; >>> >>> + thermal-zones { >>> + cpu_thermal: cpu_thermal { >>> + polling-delay-passive = <1000>; /* milliseconds */ >>> + polling-delay = <1000>; /* milliseconds */ >>> + >>> + thermal-sensors = <&thermal 0>; >>> + sustainable-power = <1000>; >>> + >>> + trips { >>> + threshold: trip-point@0 { >>> + temperature = <68000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + target: trip-point@1 { >>> + temperature = <85000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + cpu_crit: cpu_crit@0 { >>> + temperature = <115000>; >>> + hysteresis = <2000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >> >> are there any corresponding cooling-maps? > > Since MT2701 does not register CPUFREQ cooling device and its' own > device node, I could not add cooling-maps so far. > Could we add cooling map after CPUFREQ ready, thank you. Okay. I was curious to know about the cooling agents. > >> >>> timer { >>> compatible = "arm,armv7-timer"; >>> interrupt-parent = <&gic>; >>> @@ -183,4 +213,17 @@ >>> clocks = <&uart_clk>; >>> status = "disabled"; >>> }; >>> + >>> + thermal: thermal@1100b000 { >>> + #thermal-sensor-cells = <0>; >>> + compatible = "mediatek,mt2701-thermal"; >>> + reg = <0 0x1100b000 0 0x1000>; >>> + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_LOW>; >>> + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; >>> + clock-names = "therm", "auxadc"; >>> + resets = <&pericfg 0x10>; >>> + reset-names = "therm"; >>> + mediatek,auxadc = <&auxadc>; >>> + mediatek,apmixedsys = <&apmixedsys>; >>> + }; >>> }; >>> > >
On 07/07/16 11:06, Dawei Chien wrote: > This adds the thermal controller and auxadc nodes > to the Mediatek MT2701 dtsi file. > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > --- > This patch depned on: > https://patchwork.kernel.org/patch/9213545/ > --- > arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > index 2ac8b50..0834a23 100644 > --- a/arch/arm/boot/dts/mt2701.dtsi > +++ b/arch/arm/boot/dts/mt2701.dtsi > @@ -77,6 +77,36 @@ > #clock-cells = <0>; > }; > > + thermal-zones { > + cpu_thermal: cpu_thermal { > + polling-delay-passive = <1000>; /* milliseconds */ > + polling-delay = <1000>; /* milliseconds */ > + > + thermal-sensors = <&thermal 0>; > + sustainable-power = <1000>; > + > + trips { > + threshold: trip-point@0 { > + temperature = <68000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + target: trip-point@1 { > + temperature = <85000>; > + hysteresis = <2000>; > + type = "passive"; > + }; > + > + cpu_crit: cpu_crit@0 { > + temperature = <115000>; > + hysteresis = <2000>; > + type = "critical"; > + }; > + }; > + }; > + }; > + > timer { > compatible = "arm,armv7-timer"; > interrupt-parent = <&gic>; > @@ -183,4 +213,17 @@ > clocks = <&uart_clk>; > status = "disabled"; > }; > + > + thermal: thermal@1100b000 { > + #thermal-sensor-cells = <0>; > + compatible = "mediatek,mt2701-thermal"; > + reg = <0 0x1100b000 0 0x1000>; > + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_LOW>; > + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; > + clock-names = "therm", "auxadc"; > + resets = <&pericfg 0x10>; > + reset-names = "therm"; > + mediatek,auxadc = <&auxadc>; > + mediatek,apmixedsys = <&apmixedsys>; > + }; > }; > what about: status = "disabled"; ?
Hi Matthias, On Thu, 2016-08-11 at 17:51 +0200, Matthias Brugger wrote: > > On 07/07/16 11:06, Dawei Chien wrote: > > This adds the thermal controller and auxadc nodes > > to the Mediatek MT2701 dtsi file. > > > > Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> > > --- > > This patch depned on: > > https://patchwork.kernel.org/patch/9213545/ > > --- > > arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi > > index 2ac8b50..0834a23 100644 > > --- a/arch/arm/boot/dts/mt2701.dtsi > > +++ b/arch/arm/boot/dts/mt2701.dtsi > > @@ -77,6 +77,36 @@ > > #clock-cells = <0>; > > }; > > > > + thermal-zones { > > + cpu_thermal: cpu_thermal { > > + polling-delay-passive = <1000>; /* milliseconds */ > > + polling-delay = <1000>; /* milliseconds */ > > + > > + thermal-sensors = <&thermal 0>; > > + sustainable-power = <1000>; > > + > > + trips { > > + threshold: trip-point@0 { > > + temperature = <68000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + target: trip-point@1 { > > + temperature = <85000>; > > + hysteresis = <2000>; > > + type = "passive"; > > + }; > > + > > + cpu_crit: cpu_crit@0 { > > + temperature = <115000>; > > + hysteresis = <2000>; > > + type = "critical"; > > + }; > > + }; > > + }; > > + }; > > + > > timer { > > compatible = "arm,armv7-timer"; > > interrupt-parent = <&gic>; > > @@ -183,4 +213,17 @@ > > clocks = <&uart_clk>; > > status = "disabled"; > > }; > > + > > + thermal: thermal@1100b000 { > > + #thermal-sensor-cells = <0>; > > + compatible = "mediatek,mt2701-thermal"; > > + reg = <0 0x1100b000 0 0x1000>; > > + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_LOW>; > > + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; > > + clock-names = "therm", "auxadc"; > > + resets = <&pericfg 0x10>; > > + reset-names = "therm"; > > + mediatek,auxadc = <&auxadc>; > > + mediatek,apmixedsys = <&apmixedsys>; > > + }; > > }; > > > > what about: > status = "disabled"; ? Since thermal driver would protect our platform by shutdown method once SoC temperature over critical point, I prefer keep this rather than disabling, how do you think, thank you. BR, Dawei
On 15/08/16 09:14, dawei chien wrote: > Hi Matthias, > > On Thu, 2016-08-11 at 17:51 +0200, Matthias Brugger wrote: >> >> On 07/07/16 11:06, Dawei Chien wrote: >>> This adds the thermal controller and auxadc nodes >>> to the Mediatek MT2701 dtsi file. >>> >>> Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> >>> --- >>> This patch depned on: >>> https://patchwork.kernel.org/patch/9213545/ >>> --- >>> arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 43 insertions(+) >>> >>> diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi >>> index 2ac8b50..0834a23 100644 >>> --- a/arch/arm/boot/dts/mt2701.dtsi >>> +++ b/arch/arm/boot/dts/mt2701.dtsi >>> @@ -77,6 +77,36 @@ >>> #clock-cells = <0>; >>> }; >>> >>> + thermal-zones { >>> + cpu_thermal: cpu_thermal { >>> + polling-delay-passive = <1000>; /* milliseconds */ >>> + polling-delay = <1000>; /* milliseconds */ >>> + >>> + thermal-sensors = <&thermal 0>; >>> + sustainable-power = <1000>; >>> + >>> + trips { >>> + threshold: trip-point@0 { >>> + temperature = <68000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + target: trip-point@1 { >>> + temperature = <85000>; >>> + hysteresis = <2000>; >>> + type = "passive"; >>> + }; >>> + >>> + cpu_crit: cpu_crit@0 { >>> + temperature = <115000>; >>> + hysteresis = <2000>; >>> + type = "critical"; >>> + }; >>> + }; >>> + }; >>> + }; >>> + >>> timer { >>> compatible = "arm,armv7-timer"; >>> interrupt-parent = <&gic>; >>> @@ -183,4 +213,17 @@ >>> clocks = <&uart_clk>; >>> status = "disabled"; >>> }; >>> + >>> + thermal: thermal@1100b000 { >>> + #thermal-sensor-cells = <0>; >>> + compatible = "mediatek,mt2701-thermal"; >>> + reg = <0 0x1100b000 0 0x1000>; >>> + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_LOW>; >>> + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; >>> + clock-names = "therm", "auxadc"; >>> + resets = <&pericfg 0x10>; >>> + reset-names = "therm"; >>> + mediatek,auxadc = <&auxadc>; >>> + mediatek,apmixedsys = <&apmixedsys>; >>> + }; >>> }; >>> >> >> what about: >> status = "disabled"; ? > > Since thermal driver would protect our platform by shutdown method once > SoC temperature over critical point, I prefer keep this rather than > disabling, how do you think, thank you. > Sounds reasonable. Thanks
diff --git a/arch/arm/boot/dts/mt2701.dtsi b/arch/arm/boot/dts/mt2701.dtsi index 2ac8b50..0834a23 100644 --- a/arch/arm/boot/dts/mt2701.dtsi +++ b/arch/arm/boot/dts/mt2701.dtsi @@ -77,6 +77,36 @@ #clock-cells = <0>; }; + thermal-zones { + cpu_thermal: cpu_thermal { + polling-delay-passive = <1000>; /* milliseconds */ + polling-delay = <1000>; /* milliseconds */ + + thermal-sensors = <&thermal 0>; + sustainable-power = <1000>; + + trips { + threshold: trip-point@0 { + temperature = <68000>; + hysteresis = <2000>; + type = "passive"; + }; + + target: trip-point@1 { + temperature = <85000>; + hysteresis = <2000>; + type = "passive"; + }; + + cpu_crit: cpu_crit@0 { + temperature = <115000>; + hysteresis = <2000>; + type = "critical"; + }; + }; + }; + }; + timer { compatible = "arm,armv7-timer"; interrupt-parent = <&gic>; @@ -183,4 +213,17 @@ clocks = <&uart_clk>; status = "disabled"; }; + + thermal: thermal@1100b000 { + #thermal-sensor-cells = <0>; + compatible = "mediatek,mt2701-thermal"; + reg = <0 0x1100b000 0 0x1000>; + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_LOW>; + clocks = <&pericfg CLK_PERI_THERM>, <&pericfg CLK_PERI_AUXADC>; + clock-names = "therm", "auxadc"; + resets = <&pericfg 0x10>; + reset-names = "therm"; + mediatek,auxadc = <&auxadc>; + mediatek,apmixedsys = <&apmixedsys>; + }; };
This adds the thermal controller and auxadc nodes to the Mediatek MT2701 dtsi file. Signed-off-by: Dawei Chien <dawei.chien@mediatek.com> --- This patch depned on: https://patchwork.kernel.org/patch/9213545/ --- arch/arm/boot/dts/mt2701.dtsi | 43 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 43 insertions(+)