diff mbox

x86, hvm: document the de facto policy for vCPU ids

Message ID 1468323882-6471-1-git-send-email-vkuznets@redhat.com (mailing list archive)
State New, archived
Headers show

Commit Message

Vitaly Kuznetsov July 12, 2016, 11:44 a.m. UTC 
PVHVM guests may need to know Xen's idea of vCPU ids they have and the
only way they can figure them out is to use ACPI ids from MADT table.
Document the de facto policy.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 xen/include/public/hvm/hvm_info_table.h | 8 ++++++++
 1 file changed, 8 insertions(+)

Comments

Konrad Rzeszutek Wilk July 12, 2016, 4:28 p.m. UTC | #1 
On Tue, Jul 12, 2016 at 7:44 AM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
> PVHVM guests may need to know Xen's idea of vCPU ids they have and the
> only way they can figure them out is to use ACPI ids from MADT table.
> Document the de facto policy.
>
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Andrew Cooper July 13, 2016, 1:28 p.m. UTC | #2 
On 12/07/16 17:28, Konrad Rzeszutek Wilk wrote:
> On Tue, Jul 12, 2016 at 7:44 AM, Vitaly Kuznetsov <vkuznets@redhat.com> wrote:
>> PVHVM guests may need to know Xen's idea of vCPU ids they have and the
>> only way they can figure them out is to use ACPI ids from MADT table.
>> Document the de facto policy.
>>
>> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Reviewed and committed.

~Andrew
diff mbox

Patch

diff --git a/xen/include/public/hvm/hvm_info_table.h b/xen/include/public/hvm/hvm_info_table.h
index 9e3f807..08c252e 100644
--- a/xen/include/public/hvm/hvm_info_table.h
+++ b/xen/include/public/hvm/hvm_info_table.h
@@ -34,6 +34,14 @@ 
 /* Maximum we can support with current vLAPIC ID mapping. */
 #define HVM_MAX_VCPUS        128
 
+/*
+ * In some cases SMP HVM guests may require knowledge of Xen's idea of vCPU ids
+ * for their vCPUs. For example, HYPERVISOR_vcpu_op and some EVTCHNOP_*
+ * hypercalls take vcpu id as a parameter. It is valid for HVM guests to assume
+ * that Xen's vCPU id always equals to ACPI (not APIC!) id in MADT table which
+ * is always present for SMP guests.
+ */
+
 struct hvm_info_table {
     char        signature[8]; /* "HVM INFO" */
     uint32_t    length;