| Message ID | 1467932621-358-9-git-send-email-steve_longerbeam@mentor.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > Adds ipu_csi_set_src() which is just a wrapper around > ipu_set_csi_src_mux(). > > Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com> > --- > drivers/gpu/ipu-v3/ipu-csi.c | 8 ++++++++ > include/video/imx-ipu-v3.h | 1 + > 2 files changed, 9 insertions(+) > > diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c > index 06631ac..336dc06 100644 > --- a/drivers/gpu/ipu-v3/ipu-csi.c > +++ b/drivers/gpu/ipu-v3/ipu-csi.c > @@ -609,6 +609,14 @@ int ipu_csi_set_skip_smfc(struct ipu_csi *csi, u32 skip, > } > EXPORT_SYMBOL_GPL(ipu_csi_set_skip_smfc); > > +int ipu_csi_set_src(struct ipu_csi *csi, u32 vc, bool select_mipi_csi2) vc is unused. > +{ > + ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2); > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(ipu_csi_set_src); > + Couldn't you just replace ipu_set_csi_src_mux? regards Philipp
On 07/15/2016 05:49 AM, Philipp Zabel wrote: > Am Donnerstag, den 07.07.2016, 16:03 -0700 schrieb Steve Longerbeam: > >> +{ >> + ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2); >> + >> + return 0; >> +} >> +EXPORT_SYMBOL_GPL(ipu_csi_set_src); >> + > Couldn't you just replace ipu_set_csi_src_mux? Yeah. I guess I created this as a matter of code convenience, but not worth exporting another function. I will remove this patch in next version. Steve
diff --git a/drivers/gpu/ipu-v3/ipu-csi.c b/drivers/gpu/ipu-v3/ipu-csi.c index 06631ac..336dc06 100644 --- a/drivers/gpu/ipu-v3/ipu-csi.c +++ b/drivers/gpu/ipu-v3/ipu-csi.c @@ -609,6 +609,14 @@ int ipu_csi_set_skip_smfc(struct ipu_csi *csi, u32 skip, } EXPORT_SYMBOL_GPL(ipu_csi_set_skip_smfc); +int ipu_csi_set_src(struct ipu_csi *csi, u32 vc, bool select_mipi_csi2) +{ + ipu_set_csi_src_mux(csi->ipu, csi->id, select_mipi_csi2); + + return 0; +} +EXPORT_SYMBOL_GPL(ipu_csi_set_src); + int ipu_csi_set_dest(struct ipu_csi *csi, enum ipu_csi_dest csi_dest) { unsigned long flags; diff --git a/include/video/imx-ipu-v3.h b/include/video/imx-ipu-v3.h index 2302fc5..57b487d 100644 --- a/include/video/imx-ipu-v3.h +++ b/include/video/imx-ipu-v3.h @@ -301,6 +301,7 @@ int ipu_csi_set_mipi_datatype(struct ipu_csi *csi, u32 vc, struct v4l2_mbus_framefmt *mbus_fmt); int ipu_csi_set_skip_smfc(struct ipu_csi *csi, u32 skip, u32 max_ratio, u32 id); +int ipu_csi_set_src(struct ipu_csi *csi, u32 vc, bool select_mipi_csi2); int ipu_csi_set_dest(struct ipu_csi *csi, enum ipu_csi_dest csi_dest); int ipu_csi_enable(struct ipu_csi *csi); int ipu_csi_disable(struct ipu_csi *csi);
Adds ipu_csi_set_src() which is just a wrapper around ipu_set_csi_src_mux(). Signed-off-by: Steve Longerbeam <steve_longerbeam@mentor.com> --- drivers/gpu/ipu-v3/ipu-csi.c | 8 ++++++++ include/video/imx-ipu-v3.h | 1 + 2 files changed, 9 insertions(+)