| Message ID | 1468867177-15007-2-git-send-email-okaya@codeaurora.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Mon, Jul 18, 2016 at 02:39:28PM -0400, Sinan Kaya wrote: > Adding a new binding for qcom,hidma-1.1 to distinguish HW supporting > MSI interrupts from the older revision. > > Signed-off-by: Sinan Kaya <okaya@codeaurora.org> > --- > Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > index fd5618b..45ce75b 100644 > --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt > @@ -47,7 +47,8 @@ When the OS is not in control of the management interface (i.e. it's a guest), > the channel nodes appear on their own, not under a management node. > > Required properties: > -- compatible: must contain "qcom,hidma-1.0" > +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" > +for MSI capable HW. Don't we need properties to describe the MSI details (e.g. sideband data like DeviceID)? Thanks, Mark. > - reg: Addresses for the transfer and event channel > - interrupts: Should contain the event interrupt > - desc-count: Number of asynchronous requests this channel can handle > -- > 1.8.2.1 > -- To unsubscribe from this list: send the line "unsubscribe dmaengine" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 7/19/2016 6:37 AM, Mark Rutland wrote: >> Required properties: >> > -- compatible: must contain "qcom,hidma-1.0" >> > +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" >> > +for MSI capable HW. > Don't we need properties to describe the MSI details (e.g. sideband data > like DeviceID)? > > Thanks, > Mark. > You are right. I forgot to copy those.
diff --git a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt index fd5618b..45ce75b 100644 --- a/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt +++ b/Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt @@ -47,7 +47,8 @@ When the OS is not in control of the management interface (i.e. it's a guest), the channel nodes appear on their own, not under a management node. Required properties: -- compatible: must contain "qcom,hidma-1.0" +- compatible: must contain "qcom,hidma-1.0" for initial HW or "qcom,hidma-1.1" +for MSI capable HW. - reg: Addresses for the transfer and event channel - interrupts: Should contain the event interrupt - desc-count: Number of asynchronous requests this channel can handle
Adding a new binding for qcom,hidma-1.1 to distinguish HW supporting MSI interrupts from the older revision. Signed-off-by: Sinan Kaya <okaya@codeaurora.org> --- Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)