| Message ID | 564985B7.3080806@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Simon Horman |
| Headers | show |
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 16 Nov 2015 08:20:36 +0100 > > The mempool_destroy() function tests whether its argument is NULL > and then returns immediately. Thus the test around the calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > arch/sh/kernel/dwarf.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c > index 9d209a0..e1d751a 100644 > --- a/arch/sh/kernel/dwarf.c > +++ b/arch/sh/kernel/dwarf.c > @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void) > rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node) > kfree(cie); > > - if (dwarf_reg_pool) > - mempool_destroy(dwarf_reg_pool); > - if (dwarf_frame_pool) > - mempool_destroy(dwarf_frame_pool); > + mempool_destroy(dwarf_reg_pool); > + mempool_destroy(dwarf_frame_pool); > kmem_cache_destroy(dwarf_reg_cachep); > kmem_cache_destroy(dwarf_frame_cachep); > } > How do you think about to integrate this update suggestion into another source code repository? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 19 Jul 2016, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Mon, 16 Nov 2015 08:20:36 +0100 > > > > The mempool_destroy() function tests whether its argument is NULL > > and then returns immediately. Thus the test around the calls is not needed. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > --- > > arch/sh/kernel/dwarf.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c > > index 9d209a0..e1d751a 100644 > > --- a/arch/sh/kernel/dwarf.c > > +++ b/arch/sh/kernel/dwarf.c > > @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void) > > rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node) > > kfree(cie); > > > > - if (dwarf_reg_pool) > > - mempool_destroy(dwarf_reg_pool); > > - if (dwarf_frame_pool) > > - mempool_destroy(dwarf_frame_pool); > > + mempool_destroy(dwarf_reg_pool); > > + mempool_destroy(dwarf_frame_pool); > > kmem_cache_destroy(dwarf_reg_cachep); > > kmem_cache_destroy(dwarf_frame_cachep); > > } > > > > How do you think about to integrate this update suggestion > into another source code repository? > Your patch is fine, but you may want to send it to the maintainers directly to merge. $ ./scripts/get_maintainer.pl -f arch/sh/kernel/dwarf.c Yoshinori Sato <ysato@users.sourceforge.jp> (maintainer:SUPERH) Rich Felker <dalias@libc.org> (maintainer:SUPERH) linux-sh@vger.kernel.org (open list:SUPERH) linux-kernel@vger.kernel.org (open list) -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
> From: Markus Elfring <elfring@users.sourceforge.net> > Date: Mon, 16 Nov 2015 08:20:36 +0100 > > The mempool_destroy() function tests whether its argument is NULL > and then returns immediately. Thus the test around the calls is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > arch/sh/kernel/dwarf.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c > index 9d209a0..e1d751a 100644 > --- a/arch/sh/kernel/dwarf.c > +++ b/arch/sh/kernel/dwarf.c > @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void) > rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node) > kfree(cie); > > - if (dwarf_reg_pool) > - mempool_destroy(dwarf_reg_pool); > - if (dwarf_frame_pool) > - mempool_destroy(dwarf_frame_pool); > + mempool_destroy(dwarf_reg_pool); > + mempool_destroy(dwarf_frame_pool); > kmem_cache_destroy(dwarf_reg_cachep); > kmem_cache_destroy(dwarf_frame_cachep); > } > Would you like to integrate this update suggestion into another source code repository? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jul 19, 2016 at 11:08:24PM +0200, SF Markus Elfring wrote: > > From: Markus Elfring <elfring@users.sourceforge.net> > > Date: Mon, 16 Nov 2015 08:20:36 +0100 > > > > The mempool_destroy() function tests whether its argument is NULL > > and then returns immediately. Thus the test around the calls is not needed. > > > > This issue was detected by using the Coccinelle software. > > > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > > --- > > arch/sh/kernel/dwarf.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c > > index 9d209a0..e1d751a 100644 > > --- a/arch/sh/kernel/dwarf.c > > +++ b/arch/sh/kernel/dwarf.c > > @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void) > > rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node) > > kfree(cie); > > > > - if (dwarf_reg_pool) > > - mempool_destroy(dwarf_reg_pool); > > - if (dwarf_frame_pool) > > - mempool_destroy(dwarf_frame_pool); > > + mempool_destroy(dwarf_reg_pool); > > + mempool_destroy(dwarf_frame_pool); > > kmem_cache_destroy(dwarf_reg_cachep); > > kmem_cache_destroy(dwarf_frame_cachep); > > } > > > > Would you like to integrate this update suggestion > into another source code repository? Looks OK. I have it in my linux-sh tree to go upstream. Rich -- To unsubscribe from this list: send the line "unsubscribe linux-sh" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/sh/kernel/dwarf.c b/arch/sh/kernel/dwarf.c index 9d209a0..e1d751a 100644 --- a/arch/sh/kernel/dwarf.c +++ b/arch/sh/kernel/dwarf.c @@ -1009,10 +1009,8 @@ static void __init dwarf_unwinder_cleanup(void) rbtree_postorder_for_each_entry_safe(cie, next_cie, &cie_root, node) kfree(cie); - if (dwarf_reg_pool) - mempool_destroy(dwarf_reg_pool); - if (dwarf_frame_pool) - mempool_destroy(dwarf_frame_pool); + mempool_destroy(dwarf_reg_pool); + mempool_destroy(dwarf_frame_pool); kmem_cache_destroy(dwarf_reg_cachep); kmem_cache_destroy(dwarf_frame_cachep); }