diff mbox

[-next] drm/arc: Fix some sparse warnings

Message ID 1468929845-9368-1-git-send-email-weiyj_lk@163.com (mailing list archive)
State New, archived
Headers show

Commit Message

weiyj_lk@163.com July 19, 2016, 12:04 p.m. UTC 
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fixes the following sparse warnings:

drivers/gpu/drm/arc/arcpgu_drv.c:52:5: warning:
  symbol 'arcpgu_gem_mmap' was not declared. Should it be static?
drivers/gpu/drm/arc/arcpgu_drv.c:134:48: warning:
  Using plain integer as NULL pointer
drivers/gpu/drm/arc/arcpgu_drv.c:155:5: warning:
  symbol 'arcpgu_unload' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/gpu/drm/arc/arcpgu_drv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Alexey Brodkin July 19, 2016, 6:01 p.m. UTC | #1 
Hi Wei Yongjun,

On Tue, 2016-07-19 at 12:04 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fixes the following sparse warnings:
> 
> drivers/gpu/drm/arc/arcpgu_drv.c:52:5: warning:
>   symbol 'arcpgu_gem_mmap' was not declared. Should it be static?
> drivers/gpu/drm/arc/arcpgu_drv.c:134:48: warning:
>   Using plain integer as NULL pointer
> drivers/gpu/drm/arc/arcpgu_drv.c:155:5: warning:
>   symbol 'arcpgu_unload' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
Sean Paul July 19, 2016, 7:39 p.m. UTC | #2 
On Tue, Jul 19, 2016 at 2:01 PM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> Hi Wei Yongjun,
>
> On Tue, 2016-07-19 at 12:04 +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> Fixes the following sparse warnings:
>>
>> drivers/gpu/drm/arc/arcpgu_drv.c:52:5: warning:
>>   symbol 'arcpgu_gem_mmap' was not declared. Should it be static?
>> drivers/gpu/drm/arc/arcpgu_drv.c:134:48: warning:
>>   Using plain integer as NULL pointer
>> drivers/gpu/drm/arc/arcpgu_drv.c:155:5: warning:
>>   symbol 'arcpgu_unload' was not declared. Should it be static?
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Alexey Brodkin <abrodkin@synopsys.com>


Merged to drm-misc
diff mbox

Patch

diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
index 0226ec0..3518d34 100644
--- a/drivers/gpu/drm/arc/arcpgu_drv.c
+++ b/drivers/gpu/drm/arc/arcpgu_drv.c
@@ -49,7 +49,7 @@  static void arcpgu_setup_mode_config(struct drm_device *drm)
 	drm->mode_config.funcs = &arcpgu_drm_modecfg_funcs;
 }
 
-int arcpgu_gem_mmap(struct file *filp, struct vm_area_struct *vma)
+static int arcpgu_gem_mmap(struct file *filp, struct vm_area_struct *vma)
 {
 	int ret;
 
@@ -131,7 +131,7 @@  static int arcpgu_load(struct drm_device *drm)
 		if (ret < 0)
 			return ret;
 	} else {
-		ret = arcpgu_drm_sim_init(drm, 0);
+		ret = arcpgu_drm_sim_init(drm, NULL);
 		if (ret < 0)
 			return ret;
 	}
@@ -152,7 +152,7 @@  static int arcpgu_load(struct drm_device *drm)
 	return 0;
 }
 
-int arcpgu_unload(struct drm_device *drm)
+static int arcpgu_unload(struct drm_device *drm)
 {
 	struct arcpgu_drm_private *arcpgu = drm->dev_private;