diff mbox

[-next] drm/arc: Remove redundant dev_err call in arcpgu_load()

Message ID 1468929697-8648-1-git-send-email-weiyj_lk@163.com (mailing list archive)
State New, archived
Headers show

Commit Message

weiyj_lk@163.com July 19, 2016, 12:01 p.m. UTC 
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/gpu/drm/arc/arcpgu_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Alexey Brodkin July 19, 2016, 6:02 p.m. UTC | #1 
Hi Wei Yongjun,

On Tue, 2016-07-19 at 12:01 +0000, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
Sean Paul July 19, 2016, 7:39 p.m. UTC | #2 
On Tue, Jul 19, 2016 at 2:02 PM, Alexey Brodkin
<Alexey.Brodkin@synopsys.com> wrote:
> Hi Wei Yongjun,
>
> On Tue, 2016-07-19 at 12:01 +0000, Wei Yongjun wrote:
>> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>>
>> There is a error message within devm_ioremap_resource
>> already, so remove the dev_err call to avoid redundant
>> error message.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Acked-by: Alexey Brodkin <abrodkin@synopsys.com>

Merged to drm-misc
diff mbox

Patch

diff --git a/drivers/gpu/drm/arc/arcpgu_drv.c b/drivers/gpu/drm/arc/arcpgu_drv.c
index 0226ec0..ef1d702 100644
--- a/drivers/gpu/drm/arc/arcpgu_drv.c
+++ b/drivers/gpu/drm/arc/arcpgu_drv.c
@@ -104,10 +104,8 @@  static int arcpgu_load(struct drm_device *drm)
 
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 	arcpgu->regs = devm_ioremap_resource(&pdev->dev, res);
-	if (IS_ERR(arcpgu->regs)) {
-		dev_err(drm->dev, "Could not remap IO mem\n");
+	if (IS_ERR(arcpgu->regs))
 		return PTR_ERR(arcpgu->regs);
-	}
 
 	dev_info(drm->dev, "arc_pgu ID: 0x%x\n",
 		 arc_pgu_read(arcpgu, ARCPGU_REG_ID));