| Message ID | a53076f443d43d1153dcef0fb35126b5753b08c7.1467281942.git.jstancek@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
On Thu, Jun 30, 2016 at 12:23:51PM +0200, Jan Stancek wrote: > Parallel build can sporadically fail because asn1 headers may > not be built yet by the time qat_asym_algs.o is compiled: > drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory > #include "qat_rsapubkey-asn1.h" > > Signed-off-by: Jan Stancek <jstancek@redhat.com> > Cc: Tadeusz Struk <tadeusz.struk@intel.com> > Cc: Herbert Xu <herbert@gondor.apana.org.au> Jan, Salvatore just posted a patch to delete the qat ASN code altogether, so your patch won't be needed. Thanks,
Den 01-07-2016 kl. 12:30, skrev Herbert Xu: > On Thu, Jun 30, 2016 at 12:23:51PM +0200, Jan Stancek wrote: >> Parallel build can sporadically fail because asn1 headers may >> not be built yet by the time qat_asym_algs.o is compiled: >> drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory >> #include "qat_rsapubkey-asn1.h" >> >> Signed-off-by: Jan Stancek <jstancek@redhat.com> >> Cc: Tadeusz Struk <tadeusz.struk@intel.com> >> Cc: Herbert Xu <herbert@gondor.apana.org.au> > > Jan, Salvatore just posted a patch to delete the qat ASN code > altogether, so your patch won't be needed. > > Thanks, > Yeah, but that patch seem to be heading to 4.8 only , so qat build in upcoming 4.7 still breaks... and pulling that fix only to 4.7 breaks too, so I guess more fixes would be needed for proper backport then... or are the qat fixes already queued somewhere for 4.7 final ? -- Thomas -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Jul 20, 2016 at 06:37:07PM +0300, Thomas Backlund wrote: > > Yeah, but that patch seem to be heading to 4.8 only , so qat build > in upcoming 4.7 still breaks... > > and pulling that fix only to 4.7 breaks too, so I guess more fixes > would be needed for proper backport then... > > or are the qat fixes already queued somewhere for 4.7 final ? You're right. This patch is probably the safest fix for 4.7. I'll bounce it to stable. Thanks,
diff --git a/drivers/crypto/qat/qat_common/Makefile b/drivers/crypto/qat/qat_common/Makefile index 6d74b91f2152..5fc3dbb9ada0 100644 --- a/drivers/crypto/qat/qat_common/Makefile +++ b/drivers/crypto/qat/qat_common/Makefile @@ -2,6 +2,7 @@ $(obj)/qat_rsapubkey-asn1.o: $(obj)/qat_rsapubkey-asn1.c \ $(obj)/qat_rsapubkey-asn1.h $(obj)/qat_rsaprivkey-asn1.o: $(obj)/qat_rsaprivkey-asn1.c \ $(obj)/qat_rsaprivkey-asn1.h +$(obj)/qat_asym_algs.o: $(obj)/qat_rsapubkey-asn1.h $(obj)/qat_rsaprivkey-asn1.h clean-files += qat_rsapubkey-asn1.c qat_rsapubkey-asn1.h clean-files += qat_rsaprivkey-asn1.c qat_rsaprivkey-asn1.h
Parallel build can sporadically fail because asn1 headers may not be built yet by the time qat_asym_algs.o is compiled: drivers/crypto/qat/qat_common/qat_asym_algs.c:55:32: fatal error: qat_rsapubkey-asn1.h: No such file or directory #include "qat_rsapubkey-asn1.h" Signed-off-by: Jan Stancek <jstancek@redhat.com> Cc: Tadeusz Struk <tadeusz.struk@intel.com> Cc: Herbert Xu <herbert@gondor.apana.org.au> --- drivers/crypto/qat/qat_common/Makefile | 1 + 1 file changed, 1 insertion(+)