| Message ID | 20160731112536.4625-3-icenowy@aosc.xyz (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sunday, July 31, 2016 7:25:36 PM CEST Icenowy Zheng wrote: > Allwinner A64 EHCI requires 4 clocks to be enabled. > > Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> > Can you say what those four clocks are? Are you sure that it's not just a case of a clock being incorrectly described in the clk driver, i.e. you reference one clock along with its parent here? Arnd
clocks = <&ccu CLK_A64_BUS_OHCI1>, <&ccu CLK_A64_BUS_EHCI1>, <&ccu CLK_A64_USB_OHCI0>, <&ccu CLK_A64_USB_OHCI1>; On A64, EHCI requires the matched OHCI to work. And OHCI1 clock requires OHCI0 clock to work. (But from the SoC's user manual we cannot get any infomation about the relationship between OHCI1 clock and OHCI0 clock, and in the manual OHCI0 clock is called OTG-OHCI) 01.08.2016, 15:01, "Arnd Bergmann" <arnd@arndb.de>: > On Sunday, July 31, 2016 7:25:36 PM CEST Icenowy Zheng wrote: >> Allwinner A64 EHCI requires 4 clocks to be enabled. >> >> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> > > Can you say what those four clocks are? > > Are you sure that it's not just a case of a clock being > incorrectly described in the clk driver, i.e. you reference > one clock along with its parent here? > > Arnd
Hi, On 01-08-16 09:05, Icenowy Zheng wrote: > clocks = <&ccu CLK_A64_BUS_OHCI1>, > <&ccu CLK_A64_BUS_EHCI1>, > <&ccu CLK_A64_USB_OHCI0>, > <&ccu CLK_A64_USB_OHCI1>; > > On A64, EHCI requires the matched OHCI to work. Ah, so just like on the H3 (where this also is needed and not documented). > And OHCI1 clock requires OHCI0 clock to work. Hmm, that one is new, can you double check this ? Regards, Hans > > (But from the SoC's user manual we cannot get any infomation > about the relationship between OHCI1 clock and OHCI0 clock, > and in the manual OHCI0 clock is called OTG-OHCI) > > 01.08.2016, 15:01, "Arnd Bergmann" <arnd@arndb.de>: >> On Sunday, July 31, 2016 7:25:36 PM CEST Icenowy Zheng wrote: >>> Allwinner A64 EHCI requires 4 clocks to be enabled. >>> >>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> >> >> Can you say what those four clocks are? >> >> Are you sure that it's not just a case of a clock being >> incorrectly described in the clk driver, i.e. you reference >> one clock along with its parent here? >> >> Arnd
01.08.2016, 15:27, "Hans de Goede" <hdegoede@redhat.com>: > Hi, > > On 01-08-16 09:05, Icenowy Zheng wrote: >> clocks = <&ccu CLK_A64_BUS_OHCI1>, >> <&ccu CLK_A64_BUS_EHCI1>, >> <&ccu CLK_A64_USB_OHCI0>, >> <&ccu CLK_A64_USB_OHCI1>; >> >> On A64, EHCI requires the matched OHCI to work. > > Ah, so just like on the H3 (where this also is needed > and not documented). Yes, I feeled that A64 is like a hybrid of H3 and A33. > >> And OHCI1 clock requires OHCI0 clock to work. > > Hmm, that one is new, can you double check this ? SCLK_GATING_OHCI. Gating Special Clock For OHCI(48M and 12M) 00: Clock is OFF 01: OTG-OHCI Clock is ON 10: Clock is OFF 11:OTG-OHCI and OHCI0 Clock is ON P.113 of A64 user manual 1.0 > > Regards, > > Hans > >> (But from the SoC's user manual we cannot get any infomation >> about the relationship between OHCI1 clock and OHCI0 clock, >> and in the manual OHCI0 clock is called OTG-OHCI) >> >> 01.08.2016, 15:01, "Arnd Bergmann" <arnd@arndb.de>: >>> On Sunday, July 31, 2016 7:25:36 PM CEST Icenowy Zheng wrote: >>>> Allwinner A64 EHCI requires 4 clocks to be enabled. >>>> >>>> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> >>> >>> Can you say what those four clocks are? >>> >>> Are you sure that it's not just a case of a clock being >>> incorrectly described in the clk driver, i.e. you reference >>> one clock along with its parent here? >>> >>> Arnd
Hi, On 01-08-16 10:18, Icenowy Zheng wrote: > > > 01.08.2016, 15:27, "Hans de Goede" <hdegoede@redhat.com>: >> Hi, >> >> On 01-08-16 09:05, Icenowy Zheng wrote: >>> clocks = <&ccu CLK_A64_BUS_OHCI1>, >>> <&ccu CLK_A64_BUS_EHCI1>, >>> <&ccu CLK_A64_USB_OHCI0>, >>> <&ccu CLK_A64_USB_OHCI1>; >>> >>> On A64, EHCI requires the matched OHCI to work. >> >> Ah, so just like on the H3 (where this also is needed >> and not documented). > Yes, I feeled that A64 is like a hybrid of H3 and A33. >> >>> And OHCI1 clock requires OHCI0 clock to work. >> >> Hmm, that one is new, can you double check this ? > SCLK_GATING_OHCI. > Gating Special Clock For OHCI(48M and 12M) > 00: Clock is OFF > 01: OTG-OHCI Clock is ON > 10: Clock is OFF > 11:OTG-OHCI and OHCI0 Clock is ON > > P.113 of A64 user manual 1.0 Ah I see that looks weird, I assume that you're working on getting the regular usb host on the A64 to work, iow the "HCI0" block in the usb block diagram at p. 580, right ? It could be that the ohci clock for that somehow is tapped from the ohci clock for the "USB-OTG-HCI" block, but: P.113, other bits of the USBPHY_CFG_REG register: 23:22 R/W 0x0 OHCI1_12M_SRC_SEL. OHCI1 12M Source Select 00: 12M divided from 48M 01: 12M divided from 24M 10: LOSC 11: / 21:20 R/W 0x0 OHCI0_12M_SRC_SEL. OHCI0 12M Source Select 00: 12M divided from 48M 01: 12M divided from 24M 10: LOSC 11: / Suggests that they are independent... Have you tried to simply drop <&ccu CLK_A64_USB_OHCI0>, From the clocks list and check that usb-1 devices (e.g. a mouse / keyboard) plugged directly into the board still work ? If it does we can simply drop it, of it does not work then indeed we need 4 clocks because allwinner has done something weird again. ### Also it seems that the CLK_A64_USB_OHCI0 / CLK_A64_USB_OHCI1 names are wrong, the datasheet consistently (*) refers to "usb-otg-ohci" and an "usb-ohci0" rather then ohci0 and ohci1 (**) Except for the USBPHY_CFG_REG documentation for bits 20:23, which I believe is an error in the datasheet. So we should do the same in the dt-bindings IMHO. Regards, Hans *) In the system address map (p. 73), "Interrupt Source" list (p.210) in the "Bus Clock Gating Register0" doc (p. 100) and in the usb block diagram (p. 580). **) Unlike the H3 where usb-otg-ohci is called usb-ohci0 and the first non otg host controller is called usb-ohci1.
diff --git a/drivers/usb/host/ehci-platform.c b/drivers/usb/host/ehci-platform.c index 6816b8c..876dca4 100644 --- a/drivers/usb/host/ehci-platform.c +++ b/drivers/usb/host/ehci-platform.c @@ -38,7 +38,7 @@ #include "ehci.h" #define DRIVER_DESC "EHCI generic platform driver" -#define EHCI_MAX_CLKS 3 +#define EHCI_MAX_CLKS 4 #define EHCI_MAX_RSTS 3 #define hcd_to_ehci_priv(h) ((struct ehci_platform_priv *)hcd_to_ehci(h)->priv)
Allwinner A64 EHCI requires 4 clocks to be enabled. Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz> --- drivers/usb/host/ehci-platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)