| Message ID | aef7bfd1dd47f80ab3e9a0b93333ce2a993137dd.1469997250.git.salah.triki@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 31/07/16 21:34, Salah Triki wrote: > There is no need to set *value, it will be overwritten later. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > fs/befs/btree.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > index a0e8cfa..f33fc6c 100644 > --- a/fs/befs/btree.c > +++ b/fs/befs/btree.c > @@ -348,8 +348,6 @@ befs_find_key(struct super_block *sb, struct befs_btree_node *node, > > befs_debug(sb, "---> %s %s", __func__, findkey); > > - *value = 0; > - > findkey_len = strlen(findkey); > > /* if node can not contain key, just skeep this node */ > Hi Salah, The key here is that befs_btree_find(), the only consumer of befs_find_key(), doesn't use the value if the return is BEFS_BT_NOT_FOUND. Tested the patch anyway to be sure. Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com> Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next Thanks! Luis -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 01, 2016 at 02:24:34PM +0100, Luis de Bethencourt wrote: > On 31/07/16 21:34, Salah Triki wrote: > > There is no need to set *value, it will be overwritten later. > > > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > > --- > > fs/befs/btree.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/fs/befs/btree.c b/fs/befs/btree.c > > index a0e8cfa..f33fc6c 100644 > > --- a/fs/befs/btree.c > > +++ b/fs/befs/btree.c > > @@ -348,8 +348,6 @@ befs_find_key(struct super_block *sb, struct befs_btree_node *node, > > > > befs_debug(sb, "---> %s %s", __func__, findkey); > > > > - *value = 0; > > - > > findkey_len = strlen(findkey); > > > > /* if node can not contain key, just skeep this node */ > > > > Hi Salah, > > The key here is that befs_btree_find(), the only consumer of befs_find_key(), > doesn't use the value if the return is BEFS_BT_NOT_FOUND. > > Tested the patch anyway to be sure. > > Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com> > > Pushed to the befs-next branch: > https://github.com/luisbg/linux-befs/tree/befs-next > > Thanks! > Luis Thanx :) Salah -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/befs/btree.c b/fs/befs/btree.c index a0e8cfa..f33fc6c 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@ -348,8 +348,6 @@ befs_find_key(struct super_block *sb, struct befs_btree_node *node, befs_debug(sb, "---> %s %s", __func__, findkey); - *value = 0; - findkey_len = strlen(findkey); /* if node can not contain key, just skeep this node */
There is no need to set *value, it will be overwritten later. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- fs/befs/btree.c | 2 -- 1 file changed, 2 deletions(-)