| Message ID | a094adf4e60e872606f5432094845c483523659a.1469997250.git.salah.triki@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 31/07/16 21:34, Salah Triki wrote: > Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned > value by this function is only used once. > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > --- > fs/befs/datastream.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c > index b68b6f9..343123c 100644 > --- a/fs/befs/datastream.c > +++ b/fs/befs/datastream.c > @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb, > struct buffer_head *indir_block; > befs_block_run indir_run; > befs_disk_inode_addr *iaddr_array; > - struct befs_sb_info *befs_sb = BEFS_SB(sb); > > befs_blocknr_t indir_start_blk = > - data->max_indirect_range >> befs_sb->block_shift; > + data->max_indirect_range >> BEFS_SB(sb)->block_shift; > > off_t dbl_indir_off = blockno - indir_start_blk; > > This looks to be consistent with other uses of BEFS_SB() when the value is only used once. Thanks, Luis Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com> Pushed to the befs-next branch: https://github.com/luisbg/linux-befs/tree/befs-next -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 01, 2016 at 03:02:57PM +0100, Luis de Bethencourt wrote: > On 31/07/16 21:34, Salah Triki wrote: > > Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned > > value by this function is only used once. > > > > Signed-off-by: Salah Triki <salah.triki@gmail.com> > > --- > > fs/befs/datastream.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c > > index b68b6f9..343123c 100644 > > --- a/fs/befs/datastream.c > > +++ b/fs/befs/datastream.c > > @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb, > > struct buffer_head *indir_block; > > befs_block_run indir_run; > > befs_disk_inode_addr *iaddr_array; > > - struct befs_sb_info *befs_sb = BEFS_SB(sb); > > > > befs_blocknr_t indir_start_blk = > > - data->max_indirect_range >> befs_sb->block_shift; > > + data->max_indirect_range >> BEFS_SB(sb)->block_shift; > > > > off_t dbl_indir_off = blockno - indir_start_blk; > > > > > > This looks to be consistent with other uses of BEFS_SB() when the value is > only used once. > > Thanks, > Luis > > Acked-by: Luis de Bethencourt <luisbg@osg.samsung.com> > > Pushed to the befs-next branch: > https://github.com/luisbg/linux-befs/tree/befs-next Thanx :) salah -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/befs/datastream.c b/fs/befs/datastream.c index b68b6f9..343123c 100644 --- a/fs/befs/datastream.c +++ b/fs/befs/datastream.c @@ -422,10 +422,9 @@ befs_find_brun_dblindirect(struct super_block *sb, struct buffer_head *indir_block; befs_block_run indir_run; befs_disk_inode_addr *iaddr_array; - struct befs_sb_info *befs_sb = BEFS_SB(sb); befs_blocknr_t indir_start_blk = - data->max_indirect_range >> befs_sb->block_shift; + data->max_indirect_range >> BEFS_SB(sb)->block_shift; off_t dbl_indir_off = blockno - indir_start_blk;
Remove *befs_sb and just call BEFS_SB(sb) directly, since the returned value by this function is only used once. Signed-off-by: Salah Triki <salah.triki@gmail.com> --- fs/befs/datastream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)