| Message ID | 147030114310.13239.5963137289838855143.stgit@Solace.fritz.box (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 04/08/16 09:59, Dario Faggioli wrote: > In fact, 52cf096df7 ("xenalyze: handle scheduling event"), > when dealing with TRC_SCHED_SWITCH, forgot to check whether > we actually are in dump mode, causing the printf() in > dump_sched_switch() to always produce its output, which > is not what we want. > > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> Acked-by: George Dunlap <george.dunlap@citrix.com> And queued.
diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index d223de6..3d06e45 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -7629,7 +7629,8 @@ void sched_process(struct pcpu_info *p) } break; case TRC_SCHED_SWITCH: - dump_sched_switch(ri); + if(opt.dump_all) + dump_sched_switch(ri); break; case TRC_SCHED_SWITCH_INFPREV: if(opt.dump_all) {
In fact, 52cf096df7 ("xenalyze: handle scheduling event"), when dealing with TRC_SCHED_SWITCH, forgot to check whether we actually are in dump mode, causing the printf() in dump_sched_switch() to always produce its output, which is not what we want. Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> --- Cc: George Dunlap <george.dunlap@eu.citrix.com> Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> --- tools/xentrace/xenalyze.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)