| Message ID | 20160801233610.10479-1-khilman@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Aug 1, 2016 at 6:13 PM, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> wrote: > > Hi Kevin > > Thank you for your patch > >> An ASoC driver using simple-card, when built as a module gets the >> following error at module load time: >> >> [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) >> [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) >> >> fix this by including simple-card-utils.o symbols in the module build >> its symols are resolved correctly. >> >> Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp, >> with all of ASoC built as modules. >> >> Cc: Sekhar Nori <nsekhar@ti.com> >> Signed-off-by: Kevin Hilman <khilman@baylibre.com> >> --- > > Hmm... strange... > > simple-card-utils will be used not only simple-card in the future, > thus it should be build separately. > > And, snd_soc_of_parse_daifmt() and snd_soc_of_parse_card_name() are > already exported on soc-core.c ? > > I tried it as module, but no error for me The error I'm getting is not at build time, but at module load time. The various snd related modules are autoloaded by udev events, but during that time I see this: [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) and my patch fixes that problem so that the module symbols resolve at load time. Kevin
On Tuesday 02 August 2016 05:06 AM, Kevin Hilman wrote: > An ASoC driver using simple-card, when built as a module gets the > following error at module load time: > > [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) > [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) > > fix this by including simple-card-utils.o symbols in the module build > its symols are resolved correctly. > > Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp, > with all of ASoC built as modules. > > Cc: Sekhar Nori <nsekhar@ti.com> > Signed-off-by: Kevin Hilman <khilman@baylibre.com> Tested with audio on DaVinci DA850 EVM. Tested-by: Sekhar Nori <nsekhar@ti.com> Regards, Sekhar
Hi Sekhar > > An ASoC driver using simple-card, when built as a module gets the > > following error at module load time: > > > > [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) > > [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) > > > > fix this by including simple-card-utils.o symbols in the module build > > its symols are resolved correctly. > > > > Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp, > > with all of ASoC built as modules. > > > > Cc: Sekhar Nori <nsekhar@ti.com> > > Signed-off-by: Kevin Hilman <khilman@baylibre.com> > > Tested with audio on DaVinci DA850 EVM. > > Tested-by: Sekhar Nori <nsekhar@ti.com> I think this issue was solved by this patch on Mark/fix/simple 1f85e118c81d15aa9e002604dfb69c823d4aac16 ("ASoC: simple-card-utils: add missing MODULE_xxx()")
On Tuesday 09 August 2016 05:56 AM, Kuninori Morimoto wrote: > > Hi Sekhar > >>> An ASoC driver using simple-card, when built as a module gets the >>> following error at module load time: >>> >>> [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) >>> [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) >>> >>> fix this by including simple-card-utils.o symbols in the module build >>> its symols are resolved correctly. >>> >>> Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp, >>> with all of ASoC built as modules. >>> >>> Cc: Sekhar Nori <nsekhar@ti.com> >>> Signed-off-by: Kevin Hilman <khilman@baylibre.com> >> >> Tested with audio on DaVinci DA850 EVM. >> >> Tested-by: Sekhar Nori <nsekhar@ti.com> > > I think this issue was solved by this patch on Mark/fix/simple > > 1f85e118c81d15aa9e002604dfb69c823d4aac16 > ("ASoC: simple-card-utils: add missing MODULE_xxx()") I see it in -next. Thanks! Regards, Sekhar
diff --git a/sound/soc/generic/Makefile b/sound/soc/generic/Makefile index 45602ca8536e..ff0c55eee4f7 100644 --- a/sound/soc/generic/Makefile +++ b/sound/soc/generic/Makefile @@ -2,4 +2,8 @@ obj-$(CONFIG_SND_SIMPLE_CARD_UTILS) := simple-card-utils.o snd-soc-simple-card-objs := simple-card.o +ifneq ($(CONFIG_SND_SIMPLE_CARD_UTILS),) +snd-soc-simple-card-objs += simple-card-utils.o +endif + obj-$(CONFIG_SND_SIMPLE_CARD) += snd-soc-simple-card.o
An ASoC driver using simple-card, when built as a module gets the following error at module load time: [ 23.571873] simple_card_utils: Unknown symbol snd_soc_of_parse_daifmt (err 0) [ 23.712726] simple_card_utils: Unknown symbol snd_soc_of_parse_card_name (err 0) fix this by including simple-card-utils.o symbols in the module build its symols are resolved correctly. Tested on Davinci DA850-EVM using snd_soc_edma, snc_soc_davinci_mcasp, with all of ASoC built as modules. Cc: Sekhar Nori <nsekhar@ti.com> Signed-off-by: Kevin Hilman <khilman@baylibre.com> --- sound/soc/generic/Makefile | 4 ++++ 1 file changed, 4 insertions(+)