diff mbox

multipath-tools: add missing group of options in Makefiles

Message ID 1471021927-8662-1-git-send-email-xose.vazquez@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Xose Vazquez Perez Aug. 12, 2016, 5:12 p.m. UTC
And remove "-g", it's already in OPTFLAG

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 kpartx/Makefile          | 2 +-
 libmpathpersist/Makefile | 2 +-
 mpathpersist/Makefile    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Comments

Christophe Varoqui Aug. 16, 2016, 7:43 a.m. UTC | #1
Applied.
Thanks.

On Fri, Aug 12, 2016 at 7:12 PM, Xose Vazquez Perez <xose.vazquez@gmail.com>
wrote:

> And remove "-g", it's already in OPTFLAG
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  kpartx/Makefile          | 2 +-
>  libmpathpersist/Makefile | 2 +-
>  mpathpersist/Makefile    | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kpartx/Makefile b/kpartx/Makefile
> index 75b7606..6f32680 100644
> --- a/kpartx/Makefile
> +++ b/kpartx/Makefile
> @@ -21,7 +21,7 @@ EXEC = kpartx
>  all: $(EXEC)
>
>  $(EXEC): $(OBJS)
> -       $(CC) $(OBJS) -o $(EXEC) $(LDFLAGS)
> +       $(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS)
>         $(GZIP) $(EXEC).8 > $(EXEC).8.gz
>
>  install: $(EXEC) $(EXEC).8
> diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
> index 1c4b2e1..6e43427 100644
> --- a/libmpathpersist/Makefile
> +++ b/libmpathpersist/Makefile
> @@ -15,7 +15,7 @@ all: $(LIBS)
>
>  $(LIBS):
>         $(CC) -c $(CFLAGS) *.c
> -       $(CC) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ $(CFLAGS) -o $@
> $(OBJS)
> +       $(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@
> $(CFLAGS) -o $@ $(OBJS)
>         $(LN) $(LIBS) $(DEVLIB)
>         $(GZIP) mpath_persistent_reserve_in.3 >
> mpath_persistent_reserve_in.3.gz
>         $(GZIP) mpath_persistent_reserve_out.3 >
> mpath_persistent_reserve_out.3.gz
> diff --git a/mpathpersist/Makefile b/mpathpersist/Makefile
> index d545514..b6ab730 100644
> --- a/mpathpersist/Makefile
> +++ b/mpathpersist/Makefile
> @@ -12,7 +12,7 @@ OBJS = main.o
>  all: $(EXEC)
>
>  $(EXEC): $(OBJS)
> -       $(CC) -g $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS)
> +       $(CC) $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS)
>         $(GZIP) $(EXEC).8 > $(EXEC).8.gz
>
>  install:
> --
> 2.7.4
>
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/kpartx/Makefile b/kpartx/Makefile
index 75b7606..6f32680 100644
--- a/kpartx/Makefile
+++ b/kpartx/Makefile
@@ -21,7 +21,7 @@  EXEC = kpartx
 all: $(EXEC)
 
 $(EXEC): $(OBJS)
-	$(CC) $(OBJS) -o $(EXEC) $(LDFLAGS)
+	$(CC) $(CFLAGS) $(OBJS) -o $(EXEC) $(LDFLAGS)
 	$(GZIP) $(EXEC).8 > $(EXEC).8.gz
 
 install: $(EXEC) $(EXEC).8
diff --git a/libmpathpersist/Makefile b/libmpathpersist/Makefile
index 1c4b2e1..6e43427 100644
--- a/libmpathpersist/Makefile
+++ b/libmpathpersist/Makefile
@@ -15,7 +15,7 @@  all: $(LIBS)
 
 $(LIBS):
 	$(CC) -c $(CFLAGS) *.c
-	$(CC) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS)
+	$(CC) $(LDFLAGS) $(SHARED_FLAGS) $(LIBDEPS) -Wl,-soname=$@ $(CFLAGS) -o $@ $(OBJS)
 	$(LN) $(LIBS) $(DEVLIB)
 	$(GZIP) mpath_persistent_reserve_in.3 > mpath_persistent_reserve_in.3.gz
 	$(GZIP) mpath_persistent_reserve_out.3 > mpath_persistent_reserve_out.3.gz
diff --git a/mpathpersist/Makefile b/mpathpersist/Makefile
index d545514..b6ab730 100644
--- a/mpathpersist/Makefile
+++ b/mpathpersist/Makefile
@@ -12,7 +12,7 @@  OBJS = main.o
 all: $(EXEC)
 
 $(EXEC): $(OBJS)
-	$(CC) -g $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS)
+	$(CC) $(OBJS) -o $(EXEC) $(LDFLAGS) $(CFLAGS)
 	$(GZIP) $(EXEC).8 > $(EXEC).8.gz
 
 install: