Message ID | 1470993535-11795-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com (mailing list archive) |
---|---|
State | Accepted |
Commit | 6d30733d01885adcda64b60f7354c7b98be8f4b2 |
Delegated to: | Simon Horman |
Headers | show |
On Fri, Aug 12, 2016 at 11:18 AM, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> wrote: > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, Aug 12, 2016 at 12:18:55PM +0300, Laurent Pinchart wrote: > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > This patch depends on "[PATCH] pinctrl: sh-pfc: r8a7795: Add DU support" > posted a few minutes ago to the linux-renesas-soc mailing list, as well as on > the "[PATCH v2 0/4] R-Car Gen3 DU enablement on Salvator-X board" series > posted yesterday to the same list. > > As the boot loader configures the DU pins on Salvator-X we can safely delay > this patch by one kernel version to let the pinctrl dependency hit mainling > first. I'm not entirely sure it is necessary to defer this patch by a kernel release but if that is your wish then I'm happy to do so. If so please repost at the appropriate time.
Hi Simon, On Wed, Aug 17, 2016 at 9:13 AM, Simon Horman <horms@verge.net.au> wrote: > On Fri, Aug 12, 2016 at 12:18:55PM +0300, Laurent Pinchart wrote: >> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> >> --- >> arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> This patch depends on "[PATCH] pinctrl: sh-pfc: r8a7795: Add DU support" >> posted a few minutes ago to the linux-renesas-soc mailing list, as well as on >> the "[PATCH v2 0/4] R-Car Gen3 DU enablement on Salvator-X board" series >> posted yesterday to the same list. >> >> As the boot loader configures the DU pins on Salvator-X we can safely delay >> this patch by one kernel version to let the pinctrl dependency hit mainling >> first. > > I'm not entirely sure it is necessary to defer this patch by a kernel > release but if that is your wish then I'm happy to do so. If so > please repost at the appropriate time. I believe applying this patch now means that the DU won't work in your renesas-devel tree (unless you merge sh-pfc-for-v4.9). Of course it should work in renesas-drivers. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Wednesday 17 Aug 2016 11:00:38 Geert Uytterhoeven wrote: > On Wed, Aug 17, 2016 at 9:13 AM, Simon Horman <horms@verge.net.au> wrote: > > On Fri, Aug 12, 2016 at 12:18:55PM +0300, Laurent Pinchart wrote: > >> Signed-off-by: Laurent Pinchart > >> <laurent.pinchart+renesas@ideasonboard.com> > >> --- > >> > >> arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> This patch depends on "[PATCH] pinctrl: sh-pfc: r8a7795: Add DU support" > >> posted a few minutes ago to the linux-renesas-soc mailing list, as well > >> as on the "[PATCH v2 0/4] R-Car Gen3 DU enablement on Salvator-X board" > >> series posted yesterday to the same list. > >> > >> As the boot loader configures the DU pins on Salvator-X we can safely > >> delay this patch by one kernel version to let the pinctrl dependency hit > >> mainling first. > > > > I'm not entirely sure it is necessary to defer this patch by a kernel > > release but if that is your wish then I'm happy to do so. If so > > please repost at the appropriate time. > > I believe applying this patch now means that the DU won't work in your > renesas-devel tree (unless you merge sh-pfc-for-v4.9). > Of course it should work in renesas-drivers. I haven't tested that, but I believe it would result in a probe failure as the device core won't be able to apply the request pinctrl settings.
On Wed, Aug 17, 2016 at 12:17:26PM +0300, Laurent Pinchart wrote: > On Wednesday 17 Aug 2016 11:00:38 Geert Uytterhoeven wrote: > > On Wed, Aug 17, 2016 at 9:13 AM, Simon Horman <horms@verge.net.au> wrote: > > > On Fri, Aug 12, 2016 at 12:18:55PM +0300, Laurent Pinchart wrote: > > >> Signed-off-by: Laurent Pinchart > > >> <laurent.pinchart+renesas@ideasonboard.com> > > >> --- > > >> > > >> arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 7 +++++++ > > >> 1 file changed, 7 insertions(+) > > >> > > >> This patch depends on "[PATCH] pinctrl: sh-pfc: r8a7795: Add DU support" > > >> posted a few minutes ago to the linux-renesas-soc mailing list, as well > > >> as on the "[PATCH v2 0/4] R-Car Gen3 DU enablement on Salvator-X board" > > >> series posted yesterday to the same list. > > >> > > >> As the boot loader configures the DU pins on Salvator-X we can safely > > >> delay this patch by one kernel version to let the pinctrl dependency hit > > >> mainling first. > > > > > > I'm not entirely sure it is necessary to defer this patch by a kernel > > > release but if that is your wish then I'm happy to do so. If so > > > please repost at the appropriate time. > > > > I believe applying this patch now means that the DU won't work in your > > renesas-devel tree (unless you merge sh-pfc-for-v4.9). > > Of course it should work in renesas-drivers. > > I haven't tested that, but I believe it would result in a probe failure > as the device core won't be able to apply the request pinctrl settings. Ok, in that case lets defer this patch as you suggested.
On Thu, Aug 18, 2016 at 09:12:07AM +0200, Simon Horman wrote: > On Wed, Aug 17, 2016 at 12:17:26PM +0300, Laurent Pinchart wrote: > > On Wednesday 17 Aug 2016 11:00:38 Geert Uytterhoeven wrote: > > > On Wed, Aug 17, 2016 at 9:13 AM, Simon Horman <horms@verge.net.au> wrote: > > > > On Fri, Aug 12, 2016 at 12:18:55PM +0300, Laurent Pinchart wrote: > > > >> Signed-off-by: Laurent Pinchart > > > >> <laurent.pinchart+renesas@ideasonboard.com> > > > >> --- > > > >> > > > >> arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 7 +++++++ > > > >> 1 file changed, 7 insertions(+) > > > >> > > > >> This patch depends on "[PATCH] pinctrl: sh-pfc: r8a7795: Add DU support" > > > >> posted a few minutes ago to the linux-renesas-soc mailing list, as well > > > >> as on the "[PATCH v2 0/4] R-Car Gen3 DU enablement on Salvator-X board" > > > >> series posted yesterday to the same list. > > > >> > > > >> As the boot loader configures the DU pins on Salvator-X we can safely > > > >> delay this patch by one kernel version to let the pinctrl dependency hit > > > >> mainling first. > > > > > > > > I'm not entirely sure it is necessary to defer this patch by a kernel > > > > release but if that is your wish then I'm happy to do so. If so > > > > please repost at the appropriate time. > > > > > > I believe applying this patch now means that the DU won't work in your > > > renesas-devel tree (unless you merge sh-pfc-for-v4.9). > > > Of course it should work in renesas-drivers. > > > > I haven't tested that, but I believe it would result in a probe failure > > as the device core won't be able to apply the request pinctrl settings. > > Ok, in that case lets defer this patch as you suggested. I have tentatively queued this up for v4.9 on a branch based on the sh-pfc-for-v4.9-tag2 tag of Geert's tree.
diff --git a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts index 64a29a87a724..b1eab6876f8c 100644 --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts @@ -181,6 +181,8 @@ }; &du { + pinctrl-0 = <&du_pins>; + pinctrl-names = "default"; status = "okay"; ports { @@ -227,6 +229,11 @@ function = "avb"; }; + du_pins: du { + groups = "du_rgb888", "du_sync", "du_oddf", "du_clk_out_0"; + function = "du"; + }; + sdhi0_pins: sd0 { groups = "sdhi0_data4", "sdhi0_ctrl"; function = "sdhi0";
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> --- arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts | 7 +++++++ 1 file changed, 7 insertions(+) This patch depends on "[PATCH] pinctrl: sh-pfc: r8a7795: Add DU support" posted a few minutes ago to the linux-renesas-soc mailing list, as well as on the "[PATCH v2 0/4] R-Car Gen3 DU enablement on Salvator-X board" series posted yesterday to the same list. As the boot loader configures the DU pins on Salvator-X we can safely delay this patch by one kernel version to let the pinctrl dependency hit mainling first.