| Message ID | a0bb3346635e3bd8caf6cf735ceba684e3fde2fa.1469616641.git.lukas@wunner.de (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Rafael Wysocki |
| Headers | show |
On Thursday, July 28, 2016 02:25:41 AM Lukas Wunner wrote: > Following the fwnode of a device is currently a one-way road: We provide > ACPI_COMPANION() to obtain the fwnode but there's no (public) method to > do the reverse. Granted, there may be multiple physical_nodes, but often > the first one in the list is sufficient. > > A handy function to obtain it was introduced with commit 3b95bd160547 > ("ACPI: introduce a function to find the first physical device"), but > currently it's only available internally. > > We're about to add an EFI Device Path parser which needs this function. > Consider the following device path: ACPI(PNP0A03,0)/PCI(28,2)/PCI(0,0) > The PCI root is encoded as an ACPI device in the path, so the parser > has to find the corresponding ACPI device, then find its physical node, > find the PCI bridge in slot 1c (decimal 28), function 2 below it and > finally find the PCI device in slot 0, function 0. > > To this end, make acpi_get_first_physical_node() public. > > Cc: Aleksey Makarov <aleksey.makarov@linaro.org> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > Signed-off-by: Lukas Wunner <lukas@wunner.de> ACK Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wednesday, August 17, 2016 02:38:15 AM Rafael J. Wysocki wrote: > On Thursday, July 28, 2016 02:25:41 AM Lukas Wunner wrote: > > Following the fwnode of a device is currently a one-way road: We provide > > ACPI_COMPANION() to obtain the fwnode but there's no (public) method to > > do the reverse. Granted, there may be multiple physical_nodes, but often > > the first one in the list is sufficient. > > > > A handy function to obtain it was introduced with commit 3b95bd160547 > > ("ACPI: introduce a function to find the first physical device"), but > > currently it's only available internally. > > > > We're about to add an EFI Device Path parser which needs this function. > > Consider the following device path: ACPI(PNP0A03,0)/PCI(28,2)/PCI(0,0) > > The PCI root is encoded as an ACPI device in the path, so the parser > > has to find the corresponding ACPI device, then find its physical node, > > find the PCI bridge in slot 1c (decimal 28), function 2 below it and > > finally find the PCI device in slot 0, function 0. > > > > To this end, make acpi_get_first_physical_node() public. > > > > Cc: Aleksey Makarov <aleksey.makarov@linaro.org> > > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > Signed-off-by: Lukas Wunner <lukas@wunner.de> > > ACK I've applied this one, thanks! Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/acpi/internal.h b/drivers/acpi/internal.h index 27cc7fe..48e718e 100644 --- a/drivers/acpi/internal.h +++ b/drivers/acpi/internal.h @@ -113,7 +113,6 @@ bool acpi_device_is_present(struct acpi_device *adev); bool acpi_device_is_battery(struct acpi_device *adev); bool acpi_device_is_first_physical_node(struct acpi_device *adev, const struct device *dev); -struct device *acpi_get_first_physical_node(struct acpi_device *adev); /* -------------------------------------------------------------------------- Device Matching and Notification diff --git a/include/linux/acpi.h b/include/linux/acpi.h index 288fac5..8ab6a95 100644 --- a/include/linux/acpi.h +++ b/include/linux/acpi.h @@ -85,6 +85,8 @@ static inline const char *acpi_dev_name(struct acpi_device *adev) return dev_name(&adev->dev); } +struct device *acpi_get_first_physical_node(struct acpi_device *adev); + enum acpi_irq_model_id { ACPI_IRQ_MODEL_PIC = 0, ACPI_IRQ_MODEL_IOAPIC, @@ -588,6 +590,11 @@ static inline const char *acpi_dev_name(struct acpi_device *adev) return NULL; } +static inline struct device *acpi_get_first_physical_node(struct acpi_device *adev) +{ + return NULL; +} + static inline void early_acpi_table_init(void *data, size_t size) { } static inline void acpi_early_init(void) { } static inline void acpi_subsystem_init(void) { }
Following the fwnode of a device is currently a one-way road: We provide ACPI_COMPANION() to obtain the fwnode but there's no (public) method to do the reverse. Granted, there may be multiple physical_nodes, but often the first one in the list is sufficient. A handy function to obtain it was introduced with commit 3b95bd160547 ("ACPI: introduce a function to find the first physical device"), but currently it's only available internally. We're about to add an EFI Device Path parser which needs this function. Consider the following device path: ACPI(PNP0A03,0)/PCI(28,2)/PCI(0,0) The PCI root is encoded as an ACPI device in the path, so the parser has to find the corresponding ACPI device, then find its physical node, find the PCI bridge in slot 1c (decimal 28), function 2 below it and finally find the PCI device in slot 0, function 0. To this end, make acpi_get_first_physical_node() public. Cc: Aleksey Makarov <aleksey.makarov@linaro.org> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Lukas Wunner <lukas@wunner.de> --- drivers/acpi/internal.h | 1 - include/linux/acpi.h | 7 +++++++ 2 files changed, 7 insertions(+), 1 deletion(-)