| Message ID | 1471020310-3028-1-git-send-email-wsa+renesas@sang-engineering.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 274607942b789f3a26a11f68464f1f0c15995e87 |
| Delegated to: | Simon Horman |
| Headers | show |
On Fri, Aug 12, 2016 at 06:45:09PM +0200, Wolfram Sang wrote: > We use the helper function which populates the smp_init pointer only in > case of SMP. > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Hi Wolfram, could you describe the motivation for this change in the changelog?
Hi Simon, > > We use the helper function which populates the smp_init pointer only in > > case of SMP. > > > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > could you describe the motivation for this change in the changelog? I am not sure what that could be. For me, it is pretty obvious that we should not call smp_init() in case of !SMP ? Regards, Wolfram
On Sun, Aug 21, 2016 at 11:10:26PM +0200, Wolfram Sang wrote: > Hi Simon, > > > > We use the helper function which populates the smp_init pointer only in > > > case of SMP. > > > > > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > > > could you describe the motivation for this change in the changelog? > > I am not sure what that could be. For me, it is pretty obvious that we > should not call smp_init() in case of !SMP ? Point taken. I have queued these up.
diff --git a/arch/arm/mach-shmobile/setup-r8a7790.c b/arch/arm/mach-shmobile/setup-r8a7790.c index 3506327e0bed24..78d3e859bd64ad 100644 --- a/arch/arm/mach-shmobile/setup-r8a7790.c +++ b/arch/arm/mach-shmobile/setup-r8a7790.c @@ -28,7 +28,7 @@ static const char * const r8a7790_boards_compat_dt[] __initconst = { }; DT_MACHINE_START(R8A7790_DT, "Generic R8A7790 (Flattened Device Tree)") - .smp_init = shmobile_smp_init_fallback_ops, + .smp_init = smp_init_ops(shmobile_smp_init_fallback_ops), .smp = smp_ops(r8a7790_smp_ops), .init_early = shmobile_init_delay, .init_time = rcar_gen2_timer_init,
We use the helper function which populates the smp_init pointer only in case of SMP. Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> --- arch/arm/mach-shmobile/setup-r8a7790.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)