diff mbox

ARM: dts: rskrza1: initial device tree

Message ID 20160825153115.15291-1-chris.brandt@renesas.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Brandt Aug. 25, 2016, 3:31 p.m. UTC
Add the initial device tree for the RZ/A1 based development board (RSK).

Signed-off-by: Chris Brandt <chris.brandt@renesas.com>
---
 arch/arm/boot/dts/Makefile             |  1 +
 arch/arm/boot/dts/r7s72100-rskrza1.dts | 53 ++++++++++++++++++++++++++++++++++
 2 files changed, 54 insertions(+)
 create mode 100644 arch/arm/boot/dts/r7s72100-rskrza1.dts

Comments

Geert Uytterhoeven Aug. 29, 2016, 1:34 p.m. UTC | #1
Hi Chris,

On Thu, Aug 25, 2016 at 5:31 PM, Chris Brandt <chris.brandt@renesas.com> wrote:
> Add the initial device tree for the RZ/A1 based development board (RSK).

Thanks for your patch!

> Signed-off-by: Chris Brandt <chris.brandt@renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

> --- /dev/null
> +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts

> +       compatible = "renesas,rskrza1", "renesas,r7s72100";

scripts/checkpatch.pl says:

    DT compatible string "renesas,rskrza1" appears un-documented --
check ./Documentation/devicetree/bindings/

Please send a follow-up patch to add this compatible value to
Documentation/devicetree/bindings/arm/shmobile.txt.

> +&scif2 {
> +       status = "okay";
> +};
> +

Please drop the trailing empty line.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
Chris Brandt Aug. 29, 2016, 2:56 p.m. UTC | #2
Hi Geert,

On Aug 29, Geert Uytterhoeven wrote:

> > --- /dev/null
> > +++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
>
> > +       compatible = "renesas,rskrza1", "renesas,r7s72100";
>
> scripts/checkpatch.pl says:
>
>    DT compatible string "renesas,rskrza1" appears un-documented -- check ./Documentation/devicetree/bindings/
>
> Please send a follow-up patch to add this compatible value to Documentation/devicetree/bindings/arm/shmobile.txt.
>
> > +&scif2 {
> > +       status = "okay";
> > +};
> > +
>
> Please drop the trailing empty line.

Thank you for the review.
I will modify and resend.

Chris
diff mbox

Patch

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index faacd52..c1c4d912 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -651,6 +651,7 @@  dtb-$(CONFIG_ARCH_S5PV210) += \
 dtb-$(CONFIG_ARCH_SHMOBILE_MULTI) += \
 	emev2-kzm9d.dtb \
 	r7s72100-genmai.dtb \
+	r7s72100-rskrza1.dtb \
 	r8a73a4-ape6evm.dtb \
 	r8a7740-armadillo800eva.dtb \
 	r8a7778-bockw.dtb \
diff --git a/arch/arm/boot/dts/r7s72100-rskrza1.dts b/arch/arm/boot/dts/r7s72100-rskrza1.dts
new file mode 100644
index 0000000..df9b979e
--- /dev/null
+++ b/arch/arm/boot/dts/r7s72100-rskrza1.dts
@@ -0,0 +1,53 @@ 
+/*
+ * Device Tree Source for the RZ/A1H RSK board
+ *
+ * Copyright (C) 2016 Renesas Electronics
+ *
+ * This file is licensed under the terms of the GNU General Public License
+ * version 2.  This program is licensed "as is" without any warranty of any
+ * kind, whether express or implied.
+ */
+
+/dts-v1/;
+#include "r7s72100.dtsi"
+
+/ {
+	model = "RSKRZA1";
+	compatible = "renesas,rskrza1", "renesas,r7s72100";
+
+	aliases {
+		serial0 = &scif2;
+	};
+
+	chosen {
+		bootargs = "ignore_loglevel";
+		stdout-path = "serial0:115200n8";
+	};
+
+	memory@8000000 {
+		device_type = "memory";
+		reg = <0x08000000 0x02000000>;
+	};
+
+	lbsc {
+		#address-cells = <1>;
+		#size-cells = <1>;
+	};
+};
+
+&extal_clk {
+	clock-frequency = <13330000>;
+};
+
+&usb_x1_clk {
+	clock-frequency = <48000000>;
+};
+
+&mtu2 {
+	status = "okay";
+};
+
+&scif2 {
+	status = "okay";
+};
+