| Message ID | 95c5e4100c3cd4eda643624f5b70e8d7abceb86c.1472660229.git.joe@perches.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
On 08/31/16 09:19, Joe Perches wrote: > Convert it to the preferred const struct pci_device_id instead. Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Joe" == Joe Perches <joe@perches.com> writes:
Joe> Convert it to the preferred const struct pci_device_id instead.
Applied to 4.9/scsi-queue.
On Fri, 02 Sep 2016 06:36:05 -0400 "Martin K. Petersen" <martin.petersen@oracle.com> wrote: > >>>>> "Joe" == Joe Perches <joe@perches.com> writes: > > Joe> Convert it to the preferred const struct pci_device_id instead. > > Applied to 4.9/scsi-queue. That creates an ordering dependency between the scsi tree and -mm's "treewide: remove references to the now unnecessary DEFINE_PCI_DEVICE_TABLE". So an ack would be preferred, please. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>> "Andrew" == Andrew Morton <akpm@linux-foundation.org> writes:
Andrew> That creates an ordering dependency between the scsi tree and
Andrew> -mm's "treewide: remove references to the now unnecessary
Andrew> DEFINE_PCI_DEVICE_TABLE".
Andrew> So an ack would be preferred, please.
OK. I was assuming that a subsequent patch would remove the macro.
I'll just drop the patch then.
diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c index e3da1a2..2a9da2e 100644 --- a/drivers/scsi/wd719x.c +++ b/drivers/scsi/wd719x.c @@ -962,7 +962,7 @@ static void wd719x_pci_remove(struct pci_dev *pdev) scsi_host_put(sh); } -static DEFINE_PCI_DEVICE_TABLE(wd719x_pci_table) = { +static const struct pci_device_id wd719x_pci_table[] = { { PCI_DEVICE(PCI_VENDOR_ID_WD, 0x3296) }, {} };
Convert it to the preferred const struct pci_device_id instead. Signed-off-by: Joe Perches <joe@perches.com> --- drivers/scsi/wd719x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)