| Message ID | 7011104f5ba6d400b550d2f25d16b1183efa0f35.1472583825.git.mgmoshes@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote: > Fix a line length warning found by the checkpatch.pl tool in > ddk750_chip.c. > > Signed-off-by: Moshe Green <mgmoshes@gmail.com> > --- > drivers/staging/sm750fb/ddk750_chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Lots of the patches in this series have the same exact subject: line, yet they do different things. Please fix them up and make them more obvious, or even better yet, merge them into less patches (one type of thing per file per patch, not one single change per patch). thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
There were (mostly) two kinds of warnings that I've handled, "80 character line length" and block comments structure. Some of the changes involve handling two separate warnings in a single comment. Where this occurs, should I break down the change into two steps - fixing a warning at a time? Or should I fix both warnings in the same commit - and place the commit in the most appropriate patch? thanks Moshe Green On 1 September 2016 at 19:04, Greg KH <gregkh@linuxfoundation.org> wrote: > On Tue, Aug 30, 2016 at 10:04:02PM +0300, Moshe Green wrote: >> Fix a line length warning found by the checkpatch.pl tool in >> ddk750_chip.c. >> >> Signed-off-by: Moshe Green <mgmoshes@gmail.com> >> --- >> drivers/staging/sm750fb/ddk750_chip.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Lots of the patches in this series have the same exact subject: line, > yet they do different things. Please fix them up and make them more > obvious, or even better yet, merge them into less patches (one type of > thing per file per patch, not one single change per patch). > > thanks, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Fri, Sep 02, 2016 at 11:28:51AM +0300, moshe green wrote: > There were (mostly) two kinds of warnings that I've handled, "80 > character line length" and block comments structure. > Some of the changes involve handling two separate warnings in a single comment. > Where this occurs, should I break down the change into two steps - > fixing a warning at a time? > Or should I fix both warnings in the same commit - and place the > commit in the most appropriate patch? Hm, use your best judgement here, what would you want to be on the receiving end of if you had to review such a patch series? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Sep 02, 2016 at 01:35:08PM +0200, Greg KH wrote: > > A: Because it messes up the order in which people normally read text. > Q: Why is top-posting such a bad thing? > A: Top-posting. > Q: What is the most annoying thing in e-mail? > > A: No. > Q: Should I include quotations after my reply? > > > http://daringfireball.net/2007/07/on_top > > On Fri, Sep 02, 2016 at 11:28:51AM +0300, moshe green wrote: > > There were (mostly) two kinds of warnings that I've handled, "80 > > character line length" and block comments structure. > > Some of the changes involve handling two separate warnings in a single comment. > > Where this occurs, should I break down the change into two steps - > > fixing a warning at a time? > > Or should I fix both warnings in the same commit - and place the > > commit in the most appropriate patch? > > Hm, use your best judgement here, what would you want to be on the > receiving end of if you had to review such a patch series? > > thanks, > > greg k-h Will do. thanks, Moshe Green -- To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index c1356bb..fb27eb4 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -71,7 +71,7 @@ static void setChipClock(unsigned int frequency) pll.clockType = MXCLK_PLL; /* - * Call calcPllValue() to fill up the other fields for PLL structure. + * Call calcPllValue() to fill the other fields of PLL structure. * Sometime, the chip cannot set up the exact clock required by User. * Return value from calcPllValue() gives the actual possible clock. */
Fix a line length warning found by the checkpatch.pl tool in ddk750_chip.c. Signed-off-by: Moshe Green <mgmoshes@gmail.com> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)