| Message ID | 1471883463-1950-2-git-send-email-s.nawrocki@samsung.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
On 08/22/2016 06:30 PM, Sylwester Nawrocki wrote: > The PDMA{0,1} and EPLL clock IDs are added separately in this > patch so the patch can be merged to the arm-soc tree as dependency. > > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > --- > include/dt-bindings/clock/exynos5410.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/dt-bindings/clock/exynos5410.h b/include/dt-bindings/clock/exynos5410.h > index 85b467b..a74442a 100644 > --- a/include/dt-bindings/clock/exynos5410.h > +++ b/include/dt-bindings/clock/exynos5410.h > @@ -19,6 +19,7 @@ > #define CLK_FOUT_MPLL 4 > #define CLK_FOUT_BPLL 5 > #define CLK_FOUT_KPLL 6 > +#define CLK_FOUT_EPLL 7 > > /* gate for special clocks (sclk) */ > #define CLK_SCLK_UART0 128 > @@ -48,6 +49,8 @@ > #define CLK_USI3 268 > #define CLK_UART3 260 > #define CLK_PWM 279 > +#define CLK_PDMA0 280 > +#define CLK_PDMA1 281 How about making the IDs the same as in exynos5420? This way those drivers could be merged someday in the future (if someone would be bored...). Best regards, Krzysztof > #define CLK_MCT 315 > #define CLK_WDT 316 > #define CLK_RTC 317 > -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/30/2016 11:54 AM, Krzysztof Kozlowski wrote: > On 08/22/2016 06:30 PM, Sylwester Nawrocki wrote: >> > The PDMA{0,1} and EPLL clock IDs are added separately in this >> > patch so the patch can be merged to the arm-soc tree as dependency. >> > >> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> >> > --- >> > include/dt-bindings/clock/exynos5410.h | 3 +++ >> > 1 file changed, 3 insertions(+) >> > >> > diff --git a/include/dt-bindings/clock/exynos5410.h b/include/dt-bindings/clock/exynos5410.h >> > index 85b467b..a74442a 100644 >> > --- a/include/dt-bindings/clock/exynos5410.h >> > +++ b/include/dt-bindings/clock/exynos5410.h >> > @@ -19,6 +19,7 @@ >> > #define CLK_FOUT_MPLL 4 >> > #define CLK_FOUT_BPLL 5 >> > #define CLK_FOUT_KPLL 6 >> > +#define CLK_FOUT_EPLL 7 >> > >> > /* gate for special clocks (sclk) */ >> > #define CLK_SCLK_UART0 128 >> > @@ -48,6 +49,8 @@ >> > #define CLK_USI3 268 >> > #define CLK_UART3 260 >> > #define CLK_PWM 279 >> > +#define CLK_PDMA0 280 >> > +#define CLK_PDMA1 281 > > How about making the IDs the same as in exynos5420? This way those > drivers could be merged someday in the future (if someone would be > bored...). OK, I will do it, but there is already mismatch in the PLL indices. -- Thanks, Sylwester -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Sep 02, 2016 at 04:09:08PM +0200, Sylwester Nawrocki wrote: > On 08/30/2016 11:54 AM, Krzysztof Kozlowski wrote: > > On 08/22/2016 06:30 PM, Sylwester Nawrocki wrote: > >> > The PDMA{0,1} and EPLL clock IDs are added separately in this > >> > patch so the patch can be merged to the arm-soc tree as dependency. > >> > > >> > Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> > >> > --- > >> > include/dt-bindings/clock/exynos5410.h | 3 +++ > >> > 1 file changed, 3 insertions(+) > >> > > >> > diff --git a/include/dt-bindings/clock/exynos5410.h b/include/dt-bindings/clock/exynos5410.h > >> > index 85b467b..a74442a 100644 > >> > --- a/include/dt-bindings/clock/exynos5410.h > >> > +++ b/include/dt-bindings/clock/exynos5410.h > >> > @@ -19,6 +19,7 @@ > >> > #define CLK_FOUT_MPLL 4 > >> > #define CLK_FOUT_BPLL 5 > >> > #define CLK_FOUT_KPLL 6 > >> > +#define CLK_FOUT_EPLL 7 > >> > > >> > /* gate for special clocks (sclk) */ > >> > #define CLK_SCLK_UART0 128 > >> > @@ -48,6 +49,8 @@ > >> > #define CLK_USI3 268 > >> > #define CLK_UART3 260 > >> > #define CLK_PWM 279 > >> > +#define CLK_PDMA0 280 > >> > +#define CLK_PDMA1 281 > > > > How about making the IDs the same as in exynos5420? This way those > > drivers could be merged someday in the future (if someone would be > > bored...). > > OK, I will do it, but there is already mismatch in the PLL indices. Oh, crap, I missed that difference. This means the drivers won't be combined... so I am not sure whether keeping same IDs for rest brings benefits. Whatever you chooses: Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/dt-bindings/clock/exynos5410.h b/include/dt-bindings/clock/exynos5410.h index 85b467b..a74442a 100644 --- a/include/dt-bindings/clock/exynos5410.h +++ b/include/dt-bindings/clock/exynos5410.h @@ -19,6 +19,7 @@ #define CLK_FOUT_MPLL 4 #define CLK_FOUT_BPLL 5 #define CLK_FOUT_KPLL 6 +#define CLK_FOUT_EPLL 7 /* gate for special clocks (sclk) */ #define CLK_SCLK_UART0 128 @@ -48,6 +49,8 @@ #define CLK_USI3 268 #define CLK_UART3 260 #define CLK_PWM 279 +#define CLK_PDMA0 280 +#define CLK_PDMA1 281 #define CLK_MCT 315 #define CLK_WDT 316 #define CLK_RTC 317
The PDMA{0,1} and EPLL clock IDs are added separately in this patch so the patch can be merged to the arm-soc tree as dependency. Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com> --- include/dt-bindings/clock/exynos5410.h | 3 +++ 1 file changed, 3 insertions(+)