| Message ID | 1472514096-10915-2-git-send-email-john.stultz@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi John, Thank you for the patch. On Monday 29 Aug 2016 16:41:33 John Stultz wrote: > From: Archit Taneja <architt@codeaurora.org> > > This patch moves the adv7511 data structure to header file so that the > audio driver file could use it. Actually it doesn't, the data structure is already in the header file. > Cc: David Airlie <airlied@linux.ie> > Cc: Archit Taneja <architt@codeaurora.org> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Wolfram Sang <wsa+renesas@sang-engineering.com> > Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Cc: "Ville Syrjälä" <ville.syrjala@linux.intel.com> > Cc: Boris Brezillon <boris.brezillon@free-electrons.com> > Cc: Andy Green <andy@warmcat.com> > Cc: Dave Long <dave.long@linaro.org> > Cc: Guodong Xu <guodong.xu@linaro.org> > Cc: Zhangfei Gao <zhangfei.gao@linaro.org> > Cc: Mark Brown <broonie@kernel.org> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Jose Abreu <joabreu@synopsys.com> > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > drivers/gpu/drm/bridge/adv7511/adv7511.h | 8 ++++++++ > drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 4 ++-- > 2 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h > b/drivers/gpu/drm/bridge/adv7511/adv7511.h index 161c923..c7002a0 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h > @@ -16,6 +16,14 @@ > #include <drm/drm_crtc_helper.h> > #include <drm/drm_mipi_dsi.h> > > +#include <drm/drm_crtc_helper.h> Isn't it enough to include that header once ? :-) > + > +struct regmap; This isn't needed, the header includes linux/regmap.h. > +struct adv7511; > + > +int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet); > +int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet); You can move those two functions at the end, with all the other function declarations, and get rid of the forward declaration of struct adv7511. > #define ADV7511_REG_CHIP_REVISION 0x00 > #define ADV7511_REG_N0 0x01 > #define ADV7511_REG_N1 0x02 > diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ec8fb2e..f8eb7f8 > 100644 > --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c > @@ -160,7 +160,7 @@ static void adv7511_set_colormap(struct adv7511 > *adv7511, bool enable, ADV7511_CSC_UPDATE_MODE, 0); > } > > -static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int > packet) > +int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet) > { > if (packet & 0xff) > regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0, > @@ -175,7 +175,7 @@ static int adv7511_packet_enable(struct adv7511 > *adv7511, unsigned int packet) return 0; > } > > -static int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int > packet) > +int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet) > { > if (packet & 0xff) > regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0,
On Tue, Aug 30, 2016 at 1:56 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > Hi John, > > Thank you for the patch. > > On Monday 29 Aug 2016 16:41:33 John Stultz wrote: >> From: Archit Taneja <architt@codeaurora.org> >> >> This patch moves the adv7511 data structure to header file so that the >> audio driver file could use it. > > Actually it doesn't, the data structure is already in the header file. Heh. Yea, it looks like most of that patch has fallen out, and looking closer at it, the remainders aren't necessary, so I'm dropping the whole thing. thanks -john
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511.h b/drivers/gpu/drm/bridge/adv7511/adv7511.h index 161c923..c7002a0 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511.h +++ b/drivers/gpu/drm/bridge/adv7511/adv7511.h @@ -16,6 +16,14 @@ #include <drm/drm_crtc_helper.h> #include <drm/drm_mipi_dsi.h> +#include <drm/drm_crtc_helper.h> + +struct regmap; +struct adv7511; + +int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet); +int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet); + #define ADV7511_REG_CHIP_REVISION 0x00 #define ADV7511_REG_N0 0x01 #define ADV7511_REG_N1 0x02 diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c index ec8fb2e..f8eb7f8 100644 --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c @@ -160,7 +160,7 @@ static void adv7511_set_colormap(struct adv7511 *adv7511, bool enable, ADV7511_CSC_UPDATE_MODE, 0); } -static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet) +int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet) { if (packet & 0xff) regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0, @@ -175,7 +175,7 @@ static int adv7511_packet_enable(struct adv7511 *adv7511, unsigned int packet) return 0; } -static int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet) +int adv7511_packet_disable(struct adv7511 *adv7511, unsigned int packet) { if (packet & 0xff) regmap_update_bits(adv7511->regmap, ADV7511_REG_PACKET_ENABLE0,