| Message ID | 20160902093255.24791-1-olaf@aepfle.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Sep 02, 2016 at 11:32:55AM +0200, Olaf Hering wrote:
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
More document is always a good thing. :-)
I will leave the review to Konrad and Stefano because I don't know
enough about this.
On Fri, Sep 02, 2016 at 11:32:55AM +0200, Olaf Hering wrote: > Signed-off-by: Olaf Hering <olaf@aepfle.de> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> And if nobody complains I will commit it in 'staging' in a day or so. P.S. I couldn't actually find it - but is there an spec for what the BARs in the Xen Platform PCI device should have? > --- > docs/misc/hvm-emulated-unplug.markdown | 24 ++++++++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown > index c6d1f9b..70fb024 100644 > --- a/docs/misc/hvm-emulated-unplug.markdown > +++ b/docs/misc/hvm-emulated-unplug.markdown > @@ -70,3 +70,27 @@ xen/include/public/hvm/pvdrivers.h. > NOTE: The IO ports implementing the unplug protocol are implemented > as part of the Xen Platform PCI Device, so if that device is not > present in the system then this protocol will not work. > + > + > +Unplug protocol for old SUSE PVonHVM > + > +During xen-3.0.4 timeframe an unofficial unplug protocol was added to > +the xen-platform-pci kernel module. The value 0x1 was written to offset > +0x4 in the memory region of the Xen Platform PCI Device. This was done > +unconditionally. The corresponding code in qemu-xen-traditional did an > +unplug of all NIC, IDE and SCSI devices. This was used in all SUSE > +releases up to openSUSE 12.3, SLES11SP3. Starting with openSUSE 13.1 and > +SLES11SP4/SLE12 the official protocol was used. > + > +Unplug protocol for old Novell VMDP > + > +During Xen-3.0 timeframe an unofficial unplug protocol was used in > +Novells VMDP. Depending on how VMDP was configured it would control all > +devices, or either NIC or storage. To control all devices the value 0x1 > +was written to offset 0x4 in the memory region of the Xen Platform PCI > +Device. This was supposed to unplug NIC, IDE and SCSI devices. If VMDP > +was configured to control just NIC devices it would write the value 0x1 > +to offset 0x8. If VMDP was configured to control just storage devices it > +would write the value 0x2 to offset 0x8. Starting with VMDP version 1.7 > +(released 2011) the official protocol was used. > +
On Tue, 6 Sep 2016, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 02, 2016 at 11:32:55AM +0200, Olaf Hering wrote: > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > And if nobody complains I will commit it in 'staging' in a day or so. Looks good to me too. > P.S. > I couldn't actually find it - but is there an spec for what the BARs > in the Xen Platform PCI device should have? I think that all the documentation we have is in this file. > > --- > > docs/misc/hvm-emulated-unplug.markdown | 24 ++++++++++++++++++++++++ > > 1 file changed, 24 insertions(+) > > > > diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown > > index c6d1f9b..70fb024 100644 > > --- a/docs/misc/hvm-emulated-unplug.markdown > > +++ b/docs/misc/hvm-emulated-unplug.markdown > > @@ -70,3 +70,27 @@ xen/include/public/hvm/pvdrivers.h. > > NOTE: The IO ports implementing the unplug protocol are implemented > > as part of the Xen Platform PCI Device, so if that device is not > > present in the system then this protocol will not work. > > + > > + > > +Unplug protocol for old SUSE PVonHVM > > + > > +During xen-3.0.4 timeframe an unofficial unplug protocol was added to > > +the xen-platform-pci kernel module. The value 0x1 was written to offset > > +0x4 in the memory region of the Xen Platform PCI Device. This was done > > +unconditionally. The corresponding code in qemu-xen-traditional did an > > +unplug of all NIC, IDE and SCSI devices. This was used in all SUSE > > +releases up to openSUSE 12.3, SLES11SP3. Starting with openSUSE 13.1 and > > +SLES11SP4/SLE12 the official protocol was used. > > + > > +Unplug protocol for old Novell VMDP > > + > > +During Xen-3.0 timeframe an unofficial unplug protocol was used in > > +Novells VMDP. Depending on how VMDP was configured it would control all > > +devices, or either NIC or storage. To control all devices the value 0x1 > > +was written to offset 0x4 in the memory region of the Xen Platform PCI > > +Device. This was supposed to unplug NIC, IDE and SCSI devices. If VMDP > > +was configured to control just NIC devices it would write the value 0x1 > > +to offset 0x8. If VMDP was configured to control just storage devices it > > +would write the value 0x2 to offset 0x8. Starting with VMDP version 1.7 > > +(released 2011) the official protocol was used. > > + >
On Tue, Sep 06, 2016 at 11:47:20AM -0400, Konrad Rzeszutek Wilk wrote: > On Fri, Sep 02, 2016 at 11:32:55AM +0200, Olaf Hering wrote: > > Signed-off-by: Olaf Hering <olaf@aepfle.de> > > Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Pushed with your reviewed-by. > And if nobody complains I will commit it in 'staging' in a day or so. > > P.S. > I couldn't actually find it - but is there an spec for what the BARs > in the Xen Platform PCI device should have? > More patches are welcome. :-) Wei.
diff --git a/docs/misc/hvm-emulated-unplug.markdown b/docs/misc/hvm-emulated-unplug.markdown index c6d1f9b..70fb024 100644 --- a/docs/misc/hvm-emulated-unplug.markdown +++ b/docs/misc/hvm-emulated-unplug.markdown @@ -70,3 +70,27 @@ xen/include/public/hvm/pvdrivers.h. NOTE: The IO ports implementing the unplug protocol are implemented as part of the Xen Platform PCI Device, so if that device is not present in the system then this protocol will not work. + + +Unplug protocol for old SUSE PVonHVM + +During xen-3.0.4 timeframe an unofficial unplug protocol was added to +the xen-platform-pci kernel module. The value 0x1 was written to offset +0x4 in the memory region of the Xen Platform PCI Device. This was done +unconditionally. The corresponding code in qemu-xen-traditional did an +unplug of all NIC, IDE and SCSI devices. This was used in all SUSE +releases up to openSUSE 12.3, SLES11SP3. Starting with openSUSE 13.1 and +SLES11SP4/SLE12 the official protocol was used. + +Unplug protocol for old Novell VMDP + +During Xen-3.0 timeframe an unofficial unplug protocol was used in +Novells VMDP. Depending on how VMDP was configured it would control all +devices, or either NIC or storage. To control all devices the value 0x1 +was written to offset 0x4 in the memory region of the Xen Platform PCI +Device. This was supposed to unplug NIC, IDE and SCSI devices. If VMDP +was configured to control just NIC devices it would write the value 0x1 +to offset 0x8. If VMDP was configured to control just storage devices it +would write the value 0x2 to offset 0x8. Starting with VMDP version 1.7 +(released 2011) the official protocol was used. +
Signed-off-by: Olaf Hering <olaf@aepfle.de> --- docs/misc/hvm-emulated-unplug.markdown | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+)