| Message ID | 1473509022-3478-1-git-send-email-weiyj.lk@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Herbert Xu |
| Headers | show |
Hi Wey On 09/10/2016 02:03 PM, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fix the missing clk_disable_unprepare() before return > from st_rng_probe() in the error handling case. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/char/hw_random/st-rng.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/hw_random/st-rng.c b/drivers/char/hw_random/st-rng.c > index 7e8aa6b..938ec10 100644 > --- a/drivers/char/hw_random/st-rng.c > +++ b/drivers/char/hw_random/st-rng.c > @@ -108,6 +108,7 @@ static int st_rng_probe(struct platform_device *pdev) > ret = hwrng_register(&ddata->ops); > if (ret) { > dev_err(&pdev->dev, "Failed to register HW RNG\n"); > + clk_disable_unprepare(clk); > return ret; > } > > > > Acked-by: Patrice Chotard <patrice.chotard@st.com> Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Wei, On Sat, 10 Sep 2016, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fix the missing clk_disable_unprepare() before return > from st_rng_probe() in the error handling case. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> > --- > drivers/char/hw_random/st-rng.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/char/hw_random/st-rng.c b/drivers/char/hw_random/st-rng.c > index 7e8aa6b..938ec10 100644 > --- a/drivers/char/hw_random/st-rng.c > +++ b/drivers/char/hw_random/st-rng.c > @@ -108,6 +108,7 @@ static int st_rng_probe(struct platform_device *pdev) > ret = hwrng_register(&ddata->ops); > if (ret) { > dev_err(&pdev->dev, "Failed to register HW RNG\n"); > + clk_disable_unprepare(clk); > return ret; > } > > Acked-by: Peter Griffin <peter.griffin@linaro.org> -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sat, Sep 10, 2016 at 12:03:42PM +0000, Wei Yongjun wrote: > From: Wei Yongjun <weiyongjun1@huawei.com> > > Fix the missing clk_disable_unprepare() before return > from st_rng_probe() in the error handling case. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Patch applied. Thanks.
diff --git a/drivers/char/hw_random/st-rng.c b/drivers/char/hw_random/st-rng.c index 7e8aa6b..938ec10 100644 --- a/drivers/char/hw_random/st-rng.c +++ b/drivers/char/hw_random/st-rng.c @@ -108,6 +108,7 @@ static int st_rng_probe(struct platform_device *pdev) ret = hwrng_register(&ddata->ops); if (ret) { dev_err(&pdev->dev, "Failed to register HW RNG\n"); + clk_disable_unprepare(clk); return ret; }