| Message ID | 1473299296-22458-2-git-send-email-vladimir_zapolskiy@mentor.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Thu, Sep 8, 2016 at 3:48 AM, Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> wrote: > While only Freescale Vybrid SoC has settings of GPIO capabilities done > by iomux controller, it is only a matter of GPIO controller driver > implementation for the rest of Freescale/NXP SoCs from iMX series. > > As a practical example on GPIO request a pad function should be > switched to GPIO, but because this requires updates to all particular > iMX pinctrl drivers, for simplicity at the moment add only a proper > connection between shared pinctrl-imx and pinctrl/pinmux core, namely > .gpio_request_enable/.gpio_disable_free/.gpio_set_direction callbacks > should return success to a caller. This change allows to progress by > adding request/free callbacks into gpio-mxc.c driver. > > Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> > --- > Changes from v1 to v2: > * none Patch applied with Shawn's ACK. Yours, Linus Walleij
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index 71391757938b..6e248ca10169 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -315,7 +315,7 @@ static int imx_pmx_gpio_request_enable(struct pinctrl_dev *pctldev, /* Currently implementation only for shared mux/conf register */ if (!(info->flags & SHARE_MUX_CONF_REG)) - return -EINVAL; + return 0; pin_reg = &info->pin_regs[offset]; if (pin_reg->mux_reg == -1) @@ -380,7 +380,7 @@ static int imx_pmx_gpio_set_direction(struct pinctrl_dev *pctldev, * They are part of the shared mux/conf register. */ if (!(info->flags & SHARE_MUX_CONF_REG)) - return -EINVAL; + return 0; pin_reg = &info->pin_regs[offset]; if (pin_reg->mux_reg == -1)
While only Freescale Vybrid SoC has settings of GPIO capabilities done by iomux controller, it is only a matter of GPIO controller driver implementation for the rest of Freescale/NXP SoCs from iMX series. As a practical example on GPIO request a pad function should be switched to GPIO, but because this requires updates to all particular iMX pinctrl drivers, for simplicity at the moment add only a proper connection between shared pinctrl-imx and pinctrl/pinmux core, namely .gpio_request_enable/.gpio_disable_free/.gpio_set_direction callbacks should return success to a caller. This change allows to progress by adding request/free callbacks into gpio-mxc.c driver. Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> --- Changes from v1 to v2: * none drivers/pinctrl/freescale/pinctrl-imx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)