| Message ID | 20160830075600.11559-5-andrew@aj.id.au (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Aug 30, 2016 at 5:25 PM, Andrew Jeffery <andrew@aj.id.au> wrote: > +&pinctrl { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_flbusy_default &pinctrl_flwp_default > + &pinctrl_vgahs_default &pinctrl_vgavs_default > + &pinctrl_ddcclk_default &pinctrl_ddcdat_default > + > + &pinctrl_pwm1_default &pinctrl_pwm2_default > + &pinctrl_pwm3_default &pinctrl_pwm4_default > + &pinctrl_pwm5_default &pinctrl_pwm6_default > + &pinctrl_pwm7_default > + > + &pinctrl_bmcint_default &pinctrl_flack_default>; > +}; It's not clear that all systems use these pins in that way. I will not include this one for now. Cheers, Joel
On Tue, 2016-09-13 at 22:11 +0930, Joel Stanley wrote: > It's not clear that all systems use these pins in that way. I will > not > include this one for now. Well, it has VGA so the VGA hsync, vsync and DDC should be there at least... Ben.
On Wed, Sep 14, 2016 at 6:28 AM, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > On Tue, 2016-09-13 at 22:11 +0930, Joel Stanley wrote: >> It's not clear that all systems use these pins in that way. I will >> not >> include this one for now. > > Well, it has VGA so the VGA hsync, vsync and DDC should be there at > least... True. When we enable VGA in our tree these pins will be requested as part of the VGA driver's device node, so they don't need to be hogged by the pinctrl node like this. The ones I'm not clear on are bmc_flack and bmc_int. Andrew, do you have a recommendation here? Cheers, Joel
diff --git a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts index cc5fcf2940bf..648fb6b9e427 100644 --- a/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts +++ b/arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts @@ -20,6 +20,20 @@ }; }; +&pinctrl { + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_flbusy_default &pinctrl_flwp_default + &pinctrl_vgahs_default &pinctrl_vgavs_default + &pinctrl_ddcclk_default &pinctrl_ddcdat_default + + &pinctrl_pwm1_default &pinctrl_pwm2_default + &pinctrl_pwm3_default &pinctrl_pwm4_default + &pinctrl_pwm5_default &pinctrl_pwm6_default + &pinctrl_pwm7_default + + &pinctrl_bmcint_default &pinctrl_flack_default>; +}; + &uart5 { status = "okay"; };
The requested functions are parented by the pinctrl node to provide the Palmetto's static pin configuration. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 14 ++++++++++++++ 1 file changed, 14 insertions(+)