Message ID | 20160614160023.GQ18662@thinpad.lan.raisama.net (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
14.06.2016 19:00, Eduardo Habkost wrote: > On Tue, Jun 14, 2016 at 04:44:57PM +0100, Daniel P. Berrange wrote: >> The g_test_trap_subprocess() method does not work on the >> Mingw32 platform, causing the test-qdev-global-props >> test case to abort >> >> (test-logging.exe:230): GLib-ERROR **: g_test_trap_subprocess() >> failed: Failed to execute helper program (No such file or directory) >> >> This failure was introduced a while ago in >> >> commit 2177801a4899bf29108b3d471417a5b4d701ec29 >> Author: Eduardo Habkost <ehabkost@redhat.com> >> Date: Fri Aug 8 16:03:27 2014 -0300 >> >> test-qdev-global-props: Run tests on subprocess >> >> Modify the configure time check to avoid enabling this feature >> on Mingw, rather than trying to rewrite the test to avoid this >> feature. >> > [...] >> -if test "$glib_subprocess" = "yes" ; then >> +if test "$glib_subprocess" = "yes" && test "$mingw32" != "yes" ; then >> echo "CONFIG_HAS_GLIB_SUBPROCESS_TESTS=y" >> $config_host_mak >> fi > > I would do the following instead, just in case we have extra code > looking at $glib_subprocess one day. > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> > --- > diff --git a/configure b/configure > index 8c2f90b..642a80b 100755 > --- a/configure > +++ b/configure > @@ -2996,7 +2996,7 @@ fi > > # g_test_trap_subprocess added in 2.38. Used by some tests. > glib_subprocess=yes > -if ! $pkg_config --atleast-version=2.38 glib-2.0; then > +if test "$mingw32" = "yes" || ! $pkg_config --atleast-version=2.38 glib-2.0; then > glib_subprocess=no > fi Applied this last version to -trivial, thanks! /mjt
diff --git a/configure b/configure index 8c2f90b..642a80b 100755 --- a/configure +++ b/configure @@ -2996,7 +2996,7 @@ fi # g_test_trap_subprocess added in 2.38. Used by some tests. glib_subprocess=yes -if ! $pkg_config --atleast-version=2.38 glib-2.0; then +if test "$mingw32" = "yes" || ! $pkg_config --atleast-version=2.38 glib-2.0; then glib_subprocess=no fi