| Message ID | 1fb2e894-93d3-3dbe-ca05-7e29e4c60e2a@users.sourceforge.net (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Stephen Boyd |
| Headers | show |
On 09/14/2016 01:40 PM, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 14 Sep 2016 20:26:05 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> Probably not needed in practice, but safer nevertheless. Reviewed-by: Alex Elder <elder@linaro.org> > --- > drivers/clk/bcm/clk-kona-setup.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c > index 526b0b0..a2e7e91 100644 > --- a/drivers/clk/bcm/clk-kona-setup.c > +++ b/drivers/clk/bcm/clk-kona-setup.c > @@ -586,8 +586,9 @@ static u32 *parent_process(const char *clocks[], > } > > /* There is at least one parent, so allocate a selector array */ > - > - parent_sel = kmalloc(parent_count * sizeof(*parent_sel), GFP_KERNEL); > + parent_sel = kmalloc_array(parent_count, > + sizeof(*parent_sel), > + GFP_KERNEL); > if (!parent_sel) { > pr_err("%s: error allocating %u parent selectors\n", __func__, > parent_count); > -- To unsubscribe from this list: send the line "unsubscribe linux-clk" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 09/14, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Wed, 14 Sep 2016 20:26:05 +0200 > > A multiplication for the size determination of a memory allocation > indicated that an array data structure should be processed. > Thus use the corresponding function "kmalloc_array". > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- Applied to clk-next
diff --git a/drivers/clk/bcm/clk-kona-setup.c b/drivers/clk/bcm/clk-kona-setup.c index 526b0b0..a2e7e91 100644 --- a/drivers/clk/bcm/clk-kona-setup.c +++ b/drivers/clk/bcm/clk-kona-setup.c @@ -586,8 +586,9 @@ static u32 *parent_process(const char *clocks[], } /* There is at least one parent, so allocate a selector array */ - - parent_sel = kmalloc(parent_count * sizeof(*parent_sel), GFP_KERNEL); + parent_sel = kmalloc_array(parent_count, + sizeof(*parent_sel), + GFP_KERNEL); if (!parent_sel) { pr_err("%s: error allocating %u parent selectors\n", __func__, parent_count);