diff mbox

[KBUILD] add symbol value to help find the real depend

Message ID 1234944825-10299-1-git-send-email-crquan@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Cheng Renquan Feb. 18, 2009, 8:13 a.m. UTC 
From: Cheng Renquan <chengrq@uit.com.cn>

kbuild-menuconfig-display-depend-value.patch

Sometimes when configuring need to disable some unused item, but the item is
selected by many other items, it's hard to find the real dependency which
selected it, This patch add every symbol's value accompanied to make it
possible to find the real dependency easily.

An example is CONFIG_RFKILL,

  ---------------------- RF switch subsystem support ----------------------
  | CONFIG_RFKILL:                                                        |
  |                                                                       |
  | Say Y here if you want to have control over RF switches               |
  | found on many WiFi and Bluetooth cards.                               |
  |                                                                       |
  | To compile this driver as a module, choose M here: the                |
  | module will be called rfkill.                                         |
  |                                                                       |
  | Symbol: RFKILL [=m]                                                   |
  | Prompt: RF switch subsystem support                                   |
  |   Defined at net/rfkill/Kconfig:4                                     |
  |   Depends on: NET [=y]                                                |
  |   Location:                                                           |
  |     -> Networking support (NET [=y])                                  |
  |   Selected by: IWLCORE [=n] && NETDEVICES [=y] && !S390 [=S390] && PC |
  |                                                                       |
  ----------------------------------------------------------------( 99%)---

Signed-off-by: Cheng Renquan <chengrq@uit.com.cn>

---

--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Randy Dunlap Feb. 21, 2009, 6:12 a.m. UTC | #1 
On Wed, 18 Feb 2009 16:13:45 +0800 Cheng Renquan wrote:

> From: Cheng Renquan <chengrq@uit.com.cn>
> 
> kbuild-menuconfig-display-depend-value.patch
> 
> Sometimes when configuring need to disable some unused item, but the item is
> selected by many other items, it's hard to find the real dependency which
> selected it, This patch add every symbol's value accompanied to make it
> possible to find the real dependency easily.
> 
> An example is CONFIG_RFKILL,
> 
>   ---------------------- RF switch subsystem support ----------------------
>   | CONFIG_RFKILL:                                                        |
>   |                                                                       |
>   | Say Y here if you want to have control over RF switches               |
>   | found on many WiFi and Bluetooth cards.                               |
>   |                                                                       |
>   | To compile this driver as a module, choose M here: the                |
>   | module will be called rfkill.                                         |
>   |                                                                       |
>   | Symbol: RFKILL [=m]                                                   |
>   | Prompt: RF switch subsystem support                                   |
>   |   Defined at net/rfkill/Kconfig:4                                     |
>   |   Depends on: NET [=y]                                                |
>   |   Location:                                                           |
>   |     -> Networking support (NET [=y])                                  |
>   |   Selected by: IWLCORE [=n] && NETDEVICES [=y] && !S390 [=S390] && PC |
>   |                                                                       |
>   ----------------------------------------------------------------( 99%)---
> 
> Signed-off-by: Cheng Renquan <chengrq@uit.com.cn>
> 
> ---
> 
> Index: linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
> ===================================================================
> --- linux-2.6.29-rc5-lio.orig/scripts/kconfig/expr.c
> +++ linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
> @@ -1098,6 +1098,9 @@ void expr_fprint(struct expr *e, FILE *o
>  static void expr_print_gstr_helper(void *data, struct symbol *sym, const char *str)
>  {
>  	str_append((struct gstr*)data, str);
> +	if (sym)
> +		str_printf((struct gstr *)data, " [=%s]",
> +				sym_get_string_value(sym));
>  }
>  
>  void expr_gstr_print(struct expr *e, struct gstr *gs)
> --

Hi,

This looks good/helpful.  Can it be made to work with
gconfig & xconfig as well as menuconfig?

Thanks,
---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Cheng Renquan Feb. 23, 2009, 10:28 a.m. UTC | #2 
On Sat, Feb 21, 2009 at 2:12 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> Hi,
>
> This looks good/helpful.  Can it be made to work with
> gconfig & xconfig as well as menuconfig?

Patches for gconfig & xconfig are already in progress, please be
patient, I will post later. Thanks,
diff mbox

Patch

Index: linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
===================================================================
--- linux-2.6.29-rc5-lio.orig/scripts/kconfig/expr.c
+++ linux-2.6.29-rc5-lio/scripts/kconfig/expr.c
@@ -1098,6 +1098,9 @@  void expr_fprint(struct expr *e, FILE *o
 static void expr_print_gstr_helper(void *data, struct symbol *sym, const char *str)
 {
 	str_append((struct gstr*)data, str);
+	if (sym)
+		str_printf((struct gstr *)data, " [=%s]",
+				sym_get_string_value(sym));
 }
 
 void expr_gstr_print(struct expr *e, struct gstr *gs)