| Message ID | 1473363766-12652-1-git-send-email-zach.brown@ni.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 8.9.2016 21:42, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the CD bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the CD bit in hardware, > setting the controller to test mode and then setting inserted to true > will get the controller to function without the CD bit. > > The device property "xlnx-fails-without-test-cd" will let the arasan > driver know the controller does not have the CD line wired and that the > controller does not function without it. > > Signed-off-by: Zach Brown <zach.brown@ni.com> > --- > v2: > * improved commit messages > * removed fake-cd device property > * removed fake-cd quirk > * use broken-cd device property > * documented new usage of broken-cd > v3: > * removed new usage of broken-cd > * created fails-without-test-cd device property > * created arasan controller specific quirk > v4: > * changed fails-without-test-cd to xlnx-fails-without-test-cd > * removed extra blank line > v5: > * Fixed style mistake > * Changed (1 << 0 ) to BIT(0) > v6: > * Fixed style mistakes > * Condensed unnecessarily long variable names > * Removed line wraps that were no longer necessary. > * Rebased changes off Ulf's mmc tree's next branch. > > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > df --gt /Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 3404afa..e71f043 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -21,6 +21,10 @@ Required Properties: > - interrupts: Interrupt specifier > - interrupt-parent: Phandle for the interrupt controller that services > interrupts for this device. > +Optional Properties: > +- xlnx-fails-without-test-cd: when present, the controller doesn't work when xlnx, here. Thanks, Michal
On Thu, Sep 08, 2016 at 02:42:45PM -0500, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the CD bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the CD bit in hardware, > setting the controller to test mode and then setting inserted to true > will get the controller to function without the CD bit. > > The device property "xlnx-fails-without-test-cd" will let the arasan > driver know the controller does not have the CD line wired and that the > controller does not function without it. > > Signed-off-by: Zach Brown <zach.brown@ni.com> > --- > v2: > * improved commit messages > * removed fake-cd device property > * removed fake-cd quirk > * use broken-cd device property > * documented new usage of broken-cd > v3: > * removed new usage of broken-cd > * created fails-without-test-cd device property > * created arasan controller specific quirk > v4: > * changed fails-without-test-cd to xlnx-fails-without-test-cd > * removed extra blank line > v5: > * Fixed style mistake > * Changed (1 << 0 ) to BIT(0) > v6: > * Fixed style mistakes > * Condensed unnecessarily long variable names > * Removed line wraps that were no longer necessary. > * Rebased changes off Ulf's mmc tree's next branch. > > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > df --gt /Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index 3404afa..e71f043 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -21,6 +21,10 @@ Required Properties: > - interrupts: Interrupt specifier > - interrupt-parent: Phandle for the interrupt controller that services > interrupts for this device. > +Optional Properties: > +- xlnx-fails-without-test-cd: when present, the controller doesn't work when xlnx,fails... With that, Acked-by: Rob Herring <robh@kernel.org>
--- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -21,6 +21,10 @@ Required Properties: - interrupts: Interrupt specifier - interrupt-parent: Phandle for the interrupt controller that services interrupts for this device. +Optional Properties: +- xlnx-fails-without-test-cd: when present, the controller doesn't work when + the CD line is not connected properly, and the line is not connected + properly. Test mode can be used to force the controller to function. Required Properties for "arasan,sdhci-5.1": - phys: From PHY bindings: Phandle for the Generic PHY for arasan.
The sdhci controller on xilinx zynq devices will not function unless the CD bit is provided. http://www.xilinx.com/support/answers/61064.html In cases where it is impossible to provide the CD bit in hardware, setting the controller to test mode and then setting inserted to true will get the controller to function without the CD bit. The device property "xlnx-fails-without-test-cd" will let the arasan driver know the controller does not have the CD line wired and that the controller does not function without it. Signed-off-by: Zach Brown <zach.brown@ni.com> --- v2: * improved commit messages * removed fake-cd device property * removed fake-cd quirk * use broken-cd device property * documented new usage of broken-cd v3: * removed new usage of broken-cd * created fails-without-test-cd device property * created arasan controller specific quirk v4: * changed fails-without-test-cd to xlnx-fails-without-test-cd * removed extra blank line v5: * Fixed style mistake * Changed (1 << 0 ) to BIT(0) v6: * Fixed style mistakes * Condensed unnecessarily long variable names * Removed line wraps that were no longer necessary. * Rebased changes off Ulf's mmc tree's next branch. Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 4 ++++ 1 file changed, 4 insertions(+) df --gt /Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index 3404afa..e71f043 100644