| Message ID | 20160916111422.109959-5-aleksandar.markovic@rt-rk.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Le 16/09/2016 à 13:14, Aleksandar Markovic a écrit : > From: Aleksandar Markovic <aleksandar.markovic@imgtec.com> > > This patch corrects target_semid64_ds structure definition for Mips. > > See, for example definition of semid64_ds for Mips in Linux kernel: > arch/mips/include/uapi/asm/sembuf.h#L13. > > This patch will also fix certain semaphore-related LTP tests for Mips, > if they are executed in Qemu user mode for any Mips platform. > > Signed-off-by: Miodrag Dinic <miodrag.dinic@imgtec.com> > Signed-off-by: Aleksandar Markovic <aleksandar.markovic@imgtec.com> > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > --- > linux-user/mips/target_structs.h | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/linux-user/mips/target_structs.h b/linux-user/mips/target_structs.h > index fbd9955..5ba124d 100644 > --- a/linux-user/mips/target_structs.h > +++ b/linux-user/mips/target_structs.h > @@ -45,4 +45,20 @@ struct target_shmid_ds { > abi_ulong __unused2; > }; > > +#define TARGET_SEMID64_DS > + > +/* > + * The semid64_ds structure for the MIPS architecture. > + * Note extra padding because this structure is passed back and forth > + * between kernel and user space. > + */ > +struct target_semid64_ds { > + struct target_ipc_perm sem_perm; > + abi_ulong sem_otime; > + abi_ulong sem_ctime; > + abi_ulong sem_nsems; > + abi_ulong __unused3; > + abi_ulong __unused4; > +}; Perhaps you can call them __unused1 and __unused2, like they are in the kernel? Anyway: Reviewed-by: Laurent Vivier <laurent@vivier.eu> Laurent
The naming in this patch will be synced with that from the kernel in v7. Thanks!
diff --git a/linux-user/mips/target_structs.h b/linux-user/mips/target_structs.h index fbd9955..5ba124d 100644 --- a/linux-user/mips/target_structs.h +++ b/linux-user/mips/target_structs.h @@ -45,4 +45,20 @@ struct target_shmid_ds { abi_ulong __unused2; }; +#define TARGET_SEMID64_DS + +/* + * The semid64_ds structure for the MIPS architecture. + * Note extra padding because this structure is passed back and forth + * between kernel and user space. + */ +struct target_semid64_ds { + struct target_ipc_perm sem_perm; + abi_ulong sem_otime; + abi_ulong sem_ctime; + abi_ulong sem_nsems; + abi_ulong __unused3; + abi_ulong __unused4; +}; + #endif