| Message ID | f986aec5-e069-d355-79fc-cd6e050e0be2@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi On Wed, Sep 21, 2016 at 6:47 AM, poma <pomidorabelisima@gmail.com> wrote: > Within X server, on top of DisplayLink GPU USB2.0 device, > screen content is not refreshed i.e. updated. > > This fixes commit: > > - e375882406d0cc24030746638592004755ed4ae0 > "drm/udl: Use drm_fb_helper deferred_io support" > > Thanks Noralf and Daniel for the comments. > > Tested-by: poma <poma@gmail.com> Can you provide your Signed-off-by: line? Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Thanks David > --- > drivers/gpu/drm/udl/udl_fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c > index d5df555..cc2daba 100644 > --- a/drivers/gpu/drm/udl/udl_fb.c > +++ b/drivers/gpu/drm/udl/udl_fb.c > @@ -122,7 +122,7 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y, > return 0; > cmd = urb->transfer_buffer; > > - for (i = y; i < height ; i++) { > + for (i = y; i < y + height ; i++) { > const int line_offset = fb->base.pitches[0] * i; > const int byte_offset = line_offset + (x * bpp); > const int dev_byte_offset = (fb->base.width * bpp * i) + (x * bpp); > -- > 2.7.4 > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
On 21.09.2016 09:34, David Herrmann wrote: > Hi > > On Wed, Sep 21, 2016 at 6:47 AM, poma <pomidorabelisima@gmail.com> wrote: >> Within X server, on top of DisplayLink GPU USB2.0 device, >> screen content is not refreshed i.e. updated. >> >> This fixes commit: >> >> - e375882406d0cc24030746638592004755ed4ae0 >> "drm/udl: Use drm_fb_helper deferred_io support" >> >> Thanks Noralf and Daniel for the comments. >> >> Tested-by: poma <poma@gmail.com> > > Can you provide your Signed-off-by: line? > > Reviewed-by: David Herrmann <dh.herrmann@gmail.com> > > Thanks > David > S-o-b should be performed by the actual kernel developer. R-b & T-b, I've already written.
Hi On Wed, Sep 21, 2016 at 1:19 PM, poma <pomidorabelisima@gmail.com> wrote: > On 21.09.2016 09:34, David Herrmann wrote: >> Hi >> >> On Wed, Sep 21, 2016 at 6:47 AM, poma <pomidorabelisima@gmail.com> wrote: >>> Within X server, on top of DisplayLink GPU USB2.0 device, >>> screen content is not refreshed i.e. updated. >>> >>> This fixes commit: >>> >>> - e375882406d0cc24030746638592004755ed4ae0 >>> "drm/udl: Use drm_fb_helper deferred_io support" >>> >>> Thanks Noralf and Daniel for the comments. >>> >>> Tested-by: poma <poma@gmail.com> >> >> Can you provide your Signed-off-by: line? >> >> Reviewed-by: David Herrmann <dh.herrmann@gmail.com> >> >> Thanks >> David >> > > S-o-b should be performed by the actual kernel developer. > R-b & T-b, I've already written. The author of a patch must provide the S-o-b (see Documentation/SubmittingPatches if you want details). So simply reply with a "S-o-b: foo <bar>" line to this mail. And please include it in all patches you submit (preferably use `git commit --sign-off`). Thanks David
On Wed, 21 Sep 2016, poma <pomidorabelisima@gmail.com> wrote: > On 21.09.2016 09:34, David Herrmann wrote: >> Hi >> >> On Wed, Sep 21, 2016 at 6:47 AM, poma <pomidorabelisima@gmail.com> wrote: >>> Within X server, on top of DisplayLink GPU USB2.0 device, >>> screen content is not refreshed i.e. updated. >>> >>> This fixes commit: >>> >>> - e375882406d0cc24030746638592004755ed4ae0 >>> "drm/udl: Use drm_fb_helper deferred_io support" >>> >>> Thanks Noralf and Daniel for the comments. >>> >>> Tested-by: poma <poma@gmail.com> >> >> Can you provide your Signed-off-by: line? >> >> Reviewed-by: David Herrmann <dh.herrmann@gmail.com> >> >> Thanks >> David >> > > S-o-b should be performed by the actual kernel developer. > R-b & T-b, I've already written. Please read section 11 of Documentation/SubmittingPatches. In short, you need to add your Signed-off-by with your real name. BR, Jani.
On 21.09.2016 13:33, David Herrmann wrote: > Hi > > On Wed, Sep 21, 2016 at 1:19 PM, poma <pomidorabelisima@gmail.com> wrote: >> On 21.09.2016 09:34, David Herrmann wrote: >>> Hi >>> >>> On Wed, Sep 21, 2016 at 6:47 AM, poma <pomidorabelisima@gmail.com> wrote: >>>> Within X server, on top of DisplayLink GPU USB2.0 device, >>>> screen content is not refreshed i.e. updated. >>>> >>>> This fixes commit: >>>> >>>> - e375882406d0cc24030746638592004755ed4ae0 >>>> "drm/udl: Use drm_fb_helper deferred_io support" >>>> >>>> Thanks Noralf and Daniel for the comments. >>>> >>>> Tested-by: poma <poma@gmail.com> >>> >>> Can you provide your Signed-off-by: line? >>> >>> Reviewed-by: David Herrmann <dh.herrmann@gmail.com> >>> >>> Thanks >>> David >>> >> >> S-o-b should be performed by the actual kernel developer. >> R-b & T-b, I've already written. > > The author of a patch must provide the S-o-b (see > Documentation/SubmittingPatches if you want details). So simply reply > with a "S-o-b: foo <bar>" line to this mail. And please include it in > all patches you submit (preferably use `git commit --sign-off`). > > Thanks > David > Patches are nothing but direct suggestions from Noralf and Daniel. I wrote a patch to show what is actually tested, tested successfully, but I'm not the author of these corrections.
On Wed, 21 Sep 2016, poma <pomidorabelisima@gmail.com> wrote: > On 21.09.2016 13:33, David Herrmann wrote: >> The author of a patch must provide the S-o-b (see >> Documentation/SubmittingPatches if you want details). So simply reply >> with a "S-o-b: foo <bar>" line to this mail. And please include it in >> all patches you submit (preferably use `git commit --sign-off`). >> >> Thanks >> David >> > > Patches are nothing but direct suggestions from Noralf and Daniel. > I wrote a patch to show what is actually tested, tested successfully, > but I'm not the author of these corrections. For the third and last time, see Documentation/SubmittingPatches. The Signed-off-by tag is not about authorship, it's about "Developer's Certificate of Origin". The text is also available at http://developercertificate.org/. If you send a patch, no matter whose patch it is, we can't apply it without your Signed-off-by. Thanks for your understanding. BR, Jani.
diff --git a/drivers/gpu/drm/udl/udl_fb.c b/drivers/gpu/drm/udl/udl_fb.c index d5df555..cc2daba 100644 --- a/drivers/gpu/drm/udl/udl_fb.c +++ b/drivers/gpu/drm/udl/udl_fb.c @@ -122,7 +122,7 @@ int udl_handle_damage(struct udl_framebuffer *fb, int x, int y, return 0; cmd = urb->transfer_buffer; - for (i = y; i < height ; i++) { + for (i = y; i < y + height ; i++) { const int line_offset = fb->base.pitches[0] * i; const int byte_offset = line_offset + (x * bpp); const int dev_byte_offset = (fb->base.width * bpp * i) + (x * bpp);
Within X server, on top of DisplayLink GPU USB2.0 device, screen content is not refreshed i.e. updated. This fixes commit: - e375882406d0cc24030746638592004755ed4ae0 "drm/udl: Use drm_fb_helper deferred_io support" Thanks Noralf and Daniel for the comments. Tested-by: poma <poma@gmail.com> --- drivers/gpu/drm/udl/udl_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)