| Message ID | 1474991845-27962-6-git-send-email-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 27.09.16 at 17:57, <roger.pau@citrix.com> wrote: > It doesn't make sense since the idle domain doesn't receive any events. The change itself is fine, but I think it would help if the commit message made explicit why this is becoming relevant. Jan
On Thu, Sep 29, 2016 at 04:45:57AM -0600, Jan Beulich wrote: > >>> On 27.09.16 at 17:57, <roger.pau@citrix.com> wrote: > > It doesn't make sense since the idle domain doesn't receive any events. > > The change itself is fine, but I think it would help if the commit > message made explicit why this is becoming relevant. Done. I've added: "This is relevant in order to be sure that hypercall_preempt_check is not called by the idle domain." To the commit message. Thanks, Roger.
>>> On 30.09.16 at 10:32, <roger.pau@citrix.com> wrote: > On Thu, Sep 29, 2016 at 04:45:57AM -0600, Jan Beulich wrote: >> >>> On 27.09.16 at 17:57, <roger.pau@citrix.com> wrote: >> > It doesn't make sense since the idle domain doesn't receive any events. >> >> The change itself is fine, but I think it would help if the commit >> message made explicit why this is becoming relevant. > > Done. I've added: > > "This is relevant in order to be sure that hypercall_preempt_check is not > called by the idle domain." > > To the commit message. This is only part of it imo - I think it would help more if you clarified how you got there in the first place all of the sudden. Jan
diff --git a/xen/include/asm-x86/event.h b/xen/include/asm-x86/event.h index a82062e..d589d6f 100644 --- a/xen/include/asm-x86/event.h +++ b/xen/include/asm-x86/event.h @@ -23,6 +23,9 @@ int hvm_local_events_need_delivery(struct vcpu *v); static inline int local_events_need_delivery(void) { struct vcpu *v = current; + + ASSERT(!is_idle_vcpu(v)); + return (has_hvm_container_vcpu(v) ? hvm_local_events_need_delivery(v) : (vcpu_info(v, evtchn_upcall_pending) && !vcpu_info(v, evtchn_upcall_mask)));
It doesn't make sense since the idle domain doesn't receive any events. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: Jan Beulich <jbeulich@suse.com> Cc: Andrew Cooper <andrew.cooper3@citrix.com> --- xen/include/asm-x86/event.h | 3 +++ 1 file changed, 3 insertions(+)