diff mbox

[01/20] drm/fb-helper: add DRM_FB_HELPER_DEFAULT_OPS for fb_ops

Message ID 1475182136-15191-2-git-send-email-contact@stefanchrist.eu (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Lengfeld Sept. 29, 2016, 8:48 p.m. UTC
The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
implementations for functions in struct fb_ops. A drm driver can use it
like:

    static struct fb_ops drm_fbdev_cma_ops = {
        .owner          = THIS_MODULE,
        DRM_FB_HELPER_DEFAULT_OPS,
        /* driver specific implementations */
    };

Suggested-by: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
---
 include/drm/drm_fb_helper.h | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Daniel Vetter Sept. 30, 2016, 10:17 a.m. UTC | #1
On Thu, Sep 29, 2016 at 10:48:37PM +0200, Stefan Christ wrote:
> The define DRM_FB_HELPER_DEFAULT_OPS provides the drm_fb_helper default
> implementations for functions in struct fb_ops. A drm driver can use it
> like:
> 
>     static struct fb_ops drm_fbdev_cma_ops = {
>         .owner          = THIS_MODULE,
>         DRM_FB_HELPER_DEFAULT_OPS,
>         /* driver specific implementations */
>     };
> 
> Suggested-by: Daniel Vetter <daniel@ffwll.ch>
> Signed-off-by: Stefan Christ <contact@stefanchrist.eu>

Applied just this one for 4.9. I think I'll postpone the others to 4.10.
-Daniel

> ---
>  include/drm/drm_fb_helper.h | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index db8d478..b76f5c7 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -214,6 +214,19 @@ struct drm_fb_helper {
>  	bool delayed_hotplug;
>  };
>  
> +/**
> + * @DRM_FB_HELPER_DEFAULT_OPS:
> + *
> + * Helper define to register default implementations of drm_fb_helper
> + * functions. To be used in struct fb_ops of drm drivers.
> + */
> +#define DRM_FB_HELPER_DEFAULT_OPS \
> +	.fb_check_var	= drm_fb_helper_check_var, \
> +	.fb_set_par	= drm_fb_helper_set_par, \
> +	.fb_setcmap	= drm_fb_helper_setcmap, \
> +	.fb_blank	= drm_fb_helper_blank, \
> +	.fb_pan_display	= drm_fb_helper_pan_display
> +
>  #ifdef CONFIG_DRM_FBDEV_EMULATION
>  int drm_fb_helper_modinit(void);
>  void drm_fb_helper_prepare(struct drm_device *dev, struct drm_fb_helper *helper,
> -- 
> 2.7.3
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index db8d478..b76f5c7 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -214,6 +214,19 @@  struct drm_fb_helper {
 	bool delayed_hotplug;
 };
 
+/**
+ * @DRM_FB_HELPER_DEFAULT_OPS:
+ *
+ * Helper define to register default implementations of drm_fb_helper
+ * functions. To be used in struct fb_ops of drm drivers.
+ */
+#define DRM_FB_HELPER_DEFAULT_OPS \
+	.fb_check_var	= drm_fb_helper_check_var, \
+	.fb_set_par	= drm_fb_helper_set_par, \
+	.fb_setcmap	= drm_fb_helper_setcmap, \
+	.fb_blank	= drm_fb_helper_blank, \
+	.fb_pan_display	= drm_fb_helper_pan_display
+
 #ifdef CONFIG_DRM_FBDEV_EMULATION
 int drm_fb_helper_modinit(void);
 void drm_fb_helper_prepare(struct drm_device *dev, struct drm_fb_helper *helper,