diff mbox

multipath-tools: request to update man pages/TEMPLATE if "device subsection" keywords are changed

Message ID 1472424064-9669-1-git-send-email-xose.vazquez@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Xose Vazquez Perez Aug. 28, 2016, 10:41 p.m. UTC
and s/keywork/keyword

Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
 libmultipath/dict.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Christophe Varoqui Aug. 29, 2016, 7:25 a.m. UTC | #1
Merged.
Thanks.

On Mon, Aug 29, 2016 at 12:41 AM, Xose Vazquez Perez <xose.vazquez@gmail.com
> wrote:

> and s/keywork/keyword
>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
>  libmultipath/dict.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/libmultipath/dict.c b/libmultipath/dict.c
> index e8c6804..7c21e72 100644
> --- a/libmultipath/dict.c
> +++ b/libmultipath/dict.c
> @@ -1330,7 +1330,7 @@ snprint_deprecated (struct config *conf, char *
> buff, int len, void * data)
>  #define __deprecated
>
>  /*
> - * If you add or remove a keywork also update multipath/multipath.conf.5
> + * If you add or remove a keyword also update multipath/multipath.conf.5
>   */
>  void
>  init_keywords(vector keywords)
> @@ -1421,7 +1421,10 @@ init_keywords(vector keywords)
>         __deprecated install_keyword("product", &ble_product_handler,
> &snprint_bled_product);
>         __deprecated install_sublevel_end();
>  #endif
> -
> +/*
> + * If you add or remove a "device subsection" keyword also update
> + * multipath/multipath.conf.5 and the TEMPLATE in libmultipath/hwtable.c
> + */
>         install_keyword_root("devices", &devices_handler);
>         install_keyword_multi("device", &device_handler, NULL);
>         install_sublevel();
> --
> 2.7.4
>
>
--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Xose Vazquez Perez Aug. 29, 2016, 8:49 a.m. UTC | #2
On 08/29/2016 09:25 AM, Christophe Varoqui wrote:

> Merged.

There are six pending patches:
https://patchwork.kernel.org/project/dm-devel/list/?submitter=3680

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Xose Vazquez Perez Sept. 5, 2016, 2:02 p.m. UTC | #3
On 08/29/2016 10:49 AM, Xose Vazquez Perez wrote:

> On 08/29/2016 09:25 AM, Christophe Varoqui wrote:
> 
>> Merged.
> 
> There are six pending patches:
> https://patchwork.kernel.org/project/dm-devel/list/?submitter=3680

patchwork was cleaned. They are:
[PATCH v3] multipath-tools: Add Dell SC name and maintainer
[PATCH] multipath-tools: identify some IBM FlashSystem arrays
[PATCH 1/4] multipath-tools: replace queue_if_no_path with NO_PATH_RETRY_QUEUE
[PATCH 2/4] multipath-tools: replace GROUP_BY_SERIAL with MULTIBUS for IBM 3542 and 2105
[PATCH 3/4] multipath-tools: change default failback from manual to undefined
[PATCH 4/4] multipath-tools: change default path_grouping_policy from failover to multibus

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
Xose Vazquez Perez Oct. 3, 2016, 10:42 a.m. UTC | #4
On 09/05/2016 04:02 PM, Xose Vazquez Perez wrote:

> On 08/29/2016 10:49 AM, Xose Vazquez Perez wrote:
> 
>> On 08/29/2016 09:25 AM, Christophe Varoqui wrote:
>>
>>> Merged.
>>
>> There are six pending patches:
>> https://patchwork.kernel.org/project/dm-devel/list/?submitter=3680
> 
> patchwork was cleaned. They are:
> [PATCH v3] multipath-tools: Add Dell SC name and maintainer
> [PATCH] multipath-tools: identify some IBM FlashSystem arrays
> [PATCH 1/4] multipath-tools: replace queue_if_no_path with NO_PATH_RETRY_QUEUE
> [PATCH 2/4] multipath-tools: replace GROUP_BY_SERIAL with MULTIBUS for IBM 3542 and 2105
> [PATCH 3/4] multipath-tools: change default failback from manual to undefined
> [PATCH 4/4] multipath-tools: change default path_grouping_policy from failover to multibus
> [...]

Hi Christophe,

Do I need resend any patch?

Thank you.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel
diff mbox

Patch

diff --git a/libmultipath/dict.c b/libmultipath/dict.c
index e8c6804..7c21e72 100644
--- a/libmultipath/dict.c
+++ b/libmultipath/dict.c
@@ -1330,7 +1330,7 @@  snprint_deprecated (struct config *conf, char * buff, int len, void * data)
 #define __deprecated
 
 /*
- * If you add or remove a keywork also update multipath/multipath.conf.5
+ * If you add or remove a keyword also update multipath/multipath.conf.5
  */
 void
 init_keywords(vector keywords)
@@ -1421,7 +1421,10 @@  init_keywords(vector keywords)
 	__deprecated install_keyword("product", &ble_product_handler, &snprint_bled_product);
 	__deprecated install_sublevel_end();
 #endif
-
+/*
+ * If you add or remove a "device subsection" keyword also update
+ * multipath/multipath.conf.5 and the TEMPLATE in libmultipath/hwtable.c
+ */
 	install_keyword_root("devices", &devices_handler);
 	install_keyword_multi("device", &device_handler, NULL);
 	install_sublevel();