diff mbox

OMAPDSS: Kconfig: Add HDMI for OMAP4 and OMAP5 dependencies

Message ID 1475542569-24220-1-git-send-email-aford173@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Adam Ford Oct. 4, 2016, 12:56 a.m. UTC 
Make "HDMI for OMAP4" and "HDMI for OMAP5" depend on ARCH_OMAP4
and SOC_OMAP5 respectively.

Signed-off-by: Adam Ford <aford173@gmail.com>

Comments

Nishanth Menon Oct. 4, 2016, 5:54 p.m. UTC | #1 
On 10/03/2016 07:56 PM, Adam Ford wrote:
> Make "HDMI for OMAP4" and "HDMI for OMAP5" depend on ARCH_OMAP4
> and SOC_OMAP5 respectively.
>
> Signed-off-by: Adam Ford <aford173@gmail.com>

You should also ensure key folks are cced when you post patches.
/scripts/get_maintainer.pl drivers/video/fbdev/omap2/omapfb/dss/Kconfig
You get:
> Tomi Valkeinen <tomi.valkeinen@ti.com> (maintainer:OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT...,commit_signer:3/4=75%,authored:2/4=50%)
> Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com> (maintainer:FRAMEBUFFER LAYER)
> Peter Ujfalusi <peter.ujfalusi@ti.com> (commit_signer:2/4=50%,authored:2/4=50%)
> Rob Clark <robdclark@gmail.com> (commit_signer:1/4=25%)
> Dave Airlie <airlied@gmail.com> (commit_signer:1/4=25%)
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> (commit_signer:1/4=25%)
> linux-omap@vger.kernel.org (open list:OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT...)
> linux-fbdev@vger.kernel.org (open list:OMAP DISPLAY SUBSYSTEM and FRAMEBUFFER SUPPORT...)
> linux-kernel@vger.kernel.org (open list)

>
> diff --git a/drivers/gpu/drm/omapdrm/dss/Kconfig b/drivers/gpu/drm/omapdrm/dss/Kconfig
> index d1fa730..19bb704 100644
> --- a/drivers/gpu/drm/omapdrm/dss/Kconfig
> +++ b/drivers/gpu/drm/omapdrm/dss/Kconfig
> @@ -69,6 +69,7 @@ config OMAP2_DSS_HDMI_COMMON
>
>  config OMAP4_DSS_HDMI
>  	bool "HDMI support for OMAP4"
> +	depends on ARCH_OMAP4
>          default y
>  	select OMAP2_DSS_HDMI_COMMON
>  	help
> @@ -76,6 +77,7 @@ config OMAP4_DSS_HDMI
>
>  config OMAP5_DSS_HDMI
>  	bool "HDMI support for OMAP5"
> +	depends on SOC_OMAP5

Did you miss SOC_DRA7XX?

>  	default n
>  	select OMAP2_DSS_HDMI_COMMON
>  	help
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/Kconfig b/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
> index 27d2202..7f417a1 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
> @@ -65,6 +65,7 @@ config FB_OMAP2_DSS_HDMI_COMMON
>
>  config FB_OMAP4_DSS_HDMI
>  	bool "HDMI support for OMAP4"
> +	depends on ARCH_OMAP4
>          default y
>  	select FB_OMAP2_DSS_HDMI_COMMON
>  	help
> @@ -72,6 +73,7 @@ config FB_OMAP4_DSS_HDMI
>
>  config FB_OMAP5_DSS_HDMI
>  	bool "HDMI support for OMAP5"
> +	depends on SOC_OMAP5

did you miss SOC_DRA7XX?

>  	default n
>  	select FB_OMAP2_DSS_HDMI_COMMON
>  	help
>
Adam Ford Oct. 4, 2016, 6:17 p.m. UTC | #2 
On Tue, Oct 4, 2016 at 12:54 PM, Nishanth Menon <nm@ti.com> wrote:
> On 10/03/2016 07:56 PM, Adam Ford wrote:
>>
>> Make "HDMI for OMAP4" and "HDMI for OMAP5" depend on ARCH_OMAP4
>> and SOC_OMAP5 respectively.
>>
>> Signed-off-by: Adam Ford <aford173@gmail.com>
>
>
> You should also ensure key folks are cced when you post patches.
> /scripts/get_maintainer.pl drivers/video/fbdev/omap2/omapfb/dss/Kconfig
> You get:
>>
>> Tomi Valkeinen <tomi.valkeinen@ti.com> (maintainer:OMAP DISPLAY SUBSYSTEM
>> and FRAMEBUFFER SUPPORT...,commit_signer:3/4=75%,authored:2/4=50%)
>> Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
>> (maintainer:FRAMEBUFFER LAYER)
>> Peter Ujfalusi <peter.ujfalusi@ti.com>
>> (commit_signer:2/4=50%,authored:2/4=50%)
>> Rob Clark <robdclark@gmail.com> (commit_signer:1/4=25%)
>> Dave Airlie <airlied@gmail.com> (commit_signer:1/4=25%)
>> Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> (commit_signer:1/4=25%)
>> linux-omap@vger.kernel.org (open list:OMAP DISPLAY SUBSYSTEM and
>> FRAMEBUFFER SUPPORT...)
>> linux-fbdev@vger.kernel.org (open list:OMAP DISPLAY SUBSYSTEM and
>> FRAMEBUFFER SUPPORT...)
>> linux-kernel@vger.kernel.org (open list)
>
>

Sorry, I didn't know how to do that. .  Thank you for showing me how
to do that.  I will CC everyone in the future.  Until this point, I
have only ever submitted patches for a couple board device trees, so
there was no maintainer.

>>
>> diff --git a/drivers/gpu/drm/omapdrm/dss/Kconfig
>> b/drivers/gpu/drm/omapdrm/dss/Kconfig
>> index d1fa730..19bb704 100644
>> --- a/drivers/gpu/drm/omapdrm/dss/Kconfig
>> +++ b/drivers/gpu/drm/omapdrm/dss/Kconfig
>> @@ -69,6 +69,7 @@ config OMAP2_DSS_HDMI_COMMON
>>
>>  config OMAP4_DSS_HDMI
>>         bool "HDMI support for OMAP4"
>> +       depends on ARCH_OMAP4
>>          default y
>>         select OMAP2_DSS_HDMI_COMMON
>>         help
>> @@ -76,6 +77,7 @@ config OMAP4_DSS_HDMI
>>
>>  config OMAP5_DSS_HDMI
>>         bool "HDMI support for OMAP5"
>> +       depends on SOC_OMAP5
>
>
> Did you miss SOC_DRA7XX?

I am not familiar with DRA7, is that fall under the OMAP5?  I only
added the dependencies because I disabled the OMAP4,5 and DRA7 stuff
and noticed these options were still compiling in.

Is something like the following appropriate?

+       depends on SOC_OMAP5 || SOC_DRA7XX

If so, I'll update the patch tonight and resubmit for everyone to review.

>
>>         default n
>>         select OMAP2_DSS_HDMI_COMMON
>>         help
>> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
>> b/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
>> index 27d2202..7f417a1 100644
>> --- a/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
>> +++ b/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
>> @@ -65,6 +65,7 @@ config FB_OMAP2_DSS_HDMI_COMMON
>>
>>  config FB_OMAP4_DSS_HDMI
>>         bool "HDMI support for OMAP4"
>> +       depends on ARCH_OMAP4
>>          default y
>>         select FB_OMAP2_DSS_HDMI_COMMON
>>         help
>> @@ -72,6 +73,7 @@ config FB_OMAP4_DSS_HDMI
>>
>>  config FB_OMAP5_DSS_HDMI
>>         bool "HDMI support for OMAP5"
>> +       depends on SOC_OMAP5
>
>
> did you miss SOC_DRA7XX?
>
>>         default n
>>         select FB_OMAP2_DSS_HDMI_COMMON
>>         help
>>
>
>
> --
> Regards,

Thank you.

> Nishanth Menon

adam
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Nishanth Menon Oct. 4, 2016, 11:36 p.m. UTC | #3 
On 10/04/2016 01:17 PM, Adam Ford wrote:
[...]
> Sorry, I didn't know how to do that. .  Thank you for showing me how
> to do that.  I will CC everyone in the future.  Until this point, I
> have only ever submitted patches for a couple board device trees, so
> there was no maintainer.
>

No issues, we all learn.. it is easier when you run 
./scripts/get_maintainer script on patches to get the list.

[...]

>>>  config OMAP5_DSS_HDMI
>>>         bool "HDMI support for OMAP5"
>>> +       depends on SOC_OMAP5
>>
>>
>> Did you miss SOC_DRA7XX?
>
> I am not familiar with DRA7, is that fall under the OMAP5?  I only
> added the dependencies because I disabled the OMAP4,5 and DRA7 stuff
> and noticed these options were still compiling in.

DRA7 is a different SoC, but many components tend to be reused from OMAP5.

>
> Is something like the following appropriate?
>
> +       depends on SOC_OMAP5 || SOC_DRA7XX
>
> If so, I'll update the patch tonight and resubmit for everyone to review.

Here is how I noticed it:
$ git grep compatible drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c
drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:   { .compatible = 
"ti,omap5-hdmi", },
drivers/video/fbdev/omap2/omapfb/dss/hdmi5.c:   { .compatible = 
"ti,dra7-hdmi", },

Tomi can comment if that is the right thing to do..

[...]
diff mbox

Patch

diff --git a/drivers/gpu/drm/omapdrm/dss/Kconfig b/drivers/gpu/drm/omapdrm/dss/Kconfig
index d1fa730..19bb704 100644
--- a/drivers/gpu/drm/omapdrm/dss/Kconfig
+++ b/drivers/gpu/drm/omapdrm/dss/Kconfig
@@ -69,6 +69,7 @@  config OMAP2_DSS_HDMI_COMMON
 
 config OMAP4_DSS_HDMI
 	bool "HDMI support for OMAP4"
+	depends on ARCH_OMAP4
         default y
 	select OMAP2_DSS_HDMI_COMMON
 	help
@@ -76,6 +77,7 @@  config OMAP4_DSS_HDMI
 
 config OMAP5_DSS_HDMI
 	bool "HDMI support for OMAP5"
+	depends on SOC_OMAP5
 	default n
 	select OMAP2_DSS_HDMI_COMMON
 	help
diff --git a/drivers/video/fbdev/omap2/omapfb/dss/Kconfig b/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
index 27d2202..7f417a1 100644
--- a/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
+++ b/drivers/video/fbdev/omap2/omapfb/dss/Kconfig
@@ -65,6 +65,7 @@  config FB_OMAP2_DSS_HDMI_COMMON
 
 config FB_OMAP4_DSS_HDMI
 	bool "HDMI support for OMAP4"
+	depends on ARCH_OMAP4
         default y
 	select FB_OMAP2_DSS_HDMI_COMMON
 	help
@@ -72,6 +73,7 @@  config FB_OMAP4_DSS_HDMI
 
 config FB_OMAP5_DSS_HDMI
 	bool "HDMI support for OMAP5"
+	depends on SOC_OMAP5
 	default n
 	select FB_OMAP2_DSS_HDMI_COMMON
 	help