diff mbox

drm/fb-helper: fix sphinx markup for DRM_FB_HELPER_DEFAULT_OPS

Message ID 1475692454-11543-1-git-send-email-contact@stefanchrist.eu (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Lengfeld Oct. 5, 2016, 6:34 p.m. UTC
Fix invalid sphinx markup in the comment for the newly added
DRM_FB_HELPER_DEFAULT_OPS.

Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
---
Hi, 

> > If I'm not mistaken v1 of this patch is already in drm-misc so you may
> > want to send a patch that fix just the line above.
> 
> Yup, I need an incremental patch which applies on top of drm-misc or
> linux-next. Sorry if this wasn't clear.
> -Daniel

Thanks for the head-ups. Here is a fix patch for it. Actually I should have
come up with the same idea myself seeing the patch queued for the next pull
request.

I have not added a "Fixes:" trailer in the commit message. If this is necessary
I can resend it, when I see the offending patch in Linus master tree with a
commit id.

Kind regards,
	Stefan Christ
---
 include/drm/drm_fb_helper.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Daniel Vetter Oct. 6, 2016, 9:18 a.m. UTC | #1
On Wed, Oct 05, 2016 at 08:34:14PM +0200, Stefan Christ wrote:
> Fix invalid sphinx markup in the comment for the newly added
> DRM_FB_HELPER_DEFAULT_OPS.
> 
> Signed-off-by: Stefan Christ <contact@stefanchrist.eu>
> ---
> Hi, 
> 
> > > If I'm not mistaken v1 of this patch is already in drm-misc so you may
> > > want to send a patch that fix just the line above.
> > 
> > Yup, I need an incremental patch which applies on top of drm-misc or
> > linux-next. Sorry if this wasn't clear.
> > -Daniel
> 
> Thanks for the head-ups. Here is a fix patch for it. Actually I should have
> come up with the same idea myself seeing the patch queued for the next pull
> request.
> 
> I have not added a "Fixes:" trailer in the commit message. If this is necessary
> I can resend it, when I see the offending patch in Linus master tree with a
> commit id.

drm-misc has stable sha1, which means you can cite them already when they
show up in linux-next. But for a minor fix like this no big deal really.

Applied to drm-misc, thanks.
-Daniel

> 
> Kind regards,
> 	Stefan Christ
> ---
>  include/drm/drm_fb_helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
> index 3c5f599..ed8edfe 100644
> --- a/include/drm/drm_fb_helper.h
> +++ b/include/drm/drm_fb_helper.h
> @@ -218,7 +218,7 @@ struct drm_fb_helper {
>  };
>  
>  /**
> - * @DRM_FB_HELPER_DEFAULT_OPS:
> + * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
>   *
>   * Helper define to register default implementations of drm_fb_helper
>   * functions. To be used in struct fb_ops of drm drivers.
> -- 
> 2.1.4
>
diff mbox

Patch

diff --git a/include/drm/drm_fb_helper.h b/include/drm/drm_fb_helper.h
index 3c5f599..ed8edfe 100644
--- a/include/drm/drm_fb_helper.h
+++ b/include/drm/drm_fb_helper.h
@@ -218,7 +218,7 @@  struct drm_fb_helper {
 };
 
 /**
- * @DRM_FB_HELPER_DEFAULT_OPS:
+ * define DRM_FB_HELPER_DEFAULT_OPS - helper define for drm drivers
  *
  * Helper define to register default implementations of drm_fb_helper
  * functions. To be used in struct fb_ops of drm drivers.