Message ID | 15557770.lH5aPepOeZ@wasted.cogentembedded.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
On Thu, Oct 06, 2016 at 12:37:08AM +0300, Sergei Shtylyov wrote: > Add minimal support for the RZ/G1M (R8A7743) SoC. > > Based on the original (and large) patch by Dmitry Shifrin > <dmitry.shifrin@cogentembedded.com>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Thanks, I have queued this up.
Hi Simon, On Friday 07 Oct 2016 12:15:37 Simon Horman wrote: > On Thu, Oct 06, 2016 at 12:37:08AM +0300, Sergei Shtylyov wrote: > > Add minimal support for the RZ/G1M (R8A7743) SoC. > > > > Based on the original (and large) patch by Dmitry Shifrin > > <dmitry.shifrin@cogentembedded.com>. > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Thanks, I have queued this up. I'd like to see this patch rebased on top of "[PATCH] ARM: shmobile: Consolidate R8A779[234] machine definitions".
Hello. On 10/7/2016 11:33 AM, Laurent Pinchart wrote: >>> Add minimal support for the RZ/G1M (R8A7743) SoC. >>> >>> Based on the original (and large) patch by Dmitry Shifrin >>> <dmitry.shifrin@cogentembedded.com>. >>> >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> >> Thanks, I have queued this up. > > I'd like to see this patch rebased on top of "[PATCH] ARM: shmobile: > Consolidate R8A779[234] machine definitions". R87743 is analogous to R8A7791, not R8A779[234], not sure how it is connected to your patch. MBR, Sergei
Hi Sergei, On Fri, Oct 7, 2016 at 12:02 PM, Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote: > On 10/7/2016 11:33 AM, Laurent Pinchart wrote: >>>> Add minimal support for the RZ/G1M (R8A7743) SoC. >>>> Based on the original (and large) patch by Dmitry Shifrin >>>> <dmitry.shifrin@cogentembedded.com>. >>>> >>>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> >>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >>> >>> >>> Thanks, I have queued this up. >> >> >> I'd like to see this patch rebased on top of "[PATCH] ARM: shmobile: >> Consolidate R8A779[234] machine definitions". > > > R87743 is analogous to R8A7791, not R8A779[234], not sure how it is > connected to your patch. The comment + /* + * R8A7790 and R8A7791 can't be handled here as long as they need SMP + * initialization fallback. + */ is not about r8a7790/r8a7791 in se, but about backward compatibility support for DTBs without APMU nodes and CPU enable-methods. For new SoCs, we mandate the presence of these in the DTB. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
On Fri, Oct 07, 2016 at 11:33:33AM +0300, Laurent Pinchart wrote: > Hi Simon, > > > On Friday 07 Oct 2016 12:15:37 Simon Horman wrote: > > On Thu, Oct 06, 2016 at 12:37:08AM +0300, Sergei Shtylyov wrote: > > > Add minimal support for the RZ/G1M (R8A7743) SoC. > > > > > > Based on the original (and large) patch by Dmitry Shifrin > > > <dmitry.shifrin@cogentembedded.com>. > > > > > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > Thanks, I have queued this up. > > I'd like to see this patch rebased on top of "[PATCH] ARM: shmobile: > Consolidate R8A779[234] machine definitions". I'm happy to drop this patch if that is the desired outcome of the discussion in this sub-thread.
Hi Simon, On Saturday 08 Oct 2016 11:31:50 Simon Horman wrote: > On Fri, Oct 07, 2016 at 11:33:33AM +0300, Laurent Pinchart wrote: > > On Friday 07 Oct 2016 12:15:37 Simon Horman wrote: > >> On Thu, Oct 06, 2016 at 12:37:08AM +0300, Sergei Shtylyov wrote: > >>> Add minimal support for the RZ/G1M (R8A7743) SoC. > >>> > >>> Based on the original (and large) patch by Dmitry Shifrin > >>> <dmitry.shifrin@cogentembedded.com>. > >>> > >>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > >>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> > >> Thanks, I have queued this up. > > > > I'd like to see this patch rebased on top of "[PATCH] ARM: shmobile: > > Consolidate R8A779[234] machine definitions". > > I'm happy to drop this patch if that is the desired outcome of > the discussion in this sub-thread. It's at least my desired outcome ;-)
Index: renesas/Documentation/devicetree/bindings/arm/shmobile.txt =================================================================== --- renesas.orig/Documentation/devicetree/bindings/arm/shmobile.txt +++ renesas/Documentation/devicetree/bindings/arm/shmobile.txt @@ -13,6 +13,8 @@ SoCs: compatible = "renesas,r8a73a4" - R-Mobile A1 (R8A77400) compatible = "renesas,r8a7740" + - RZ/G1M (R8A77430) + compatible = "renesas,r8a7743" - R-Car M1A (R8A77781) compatible = "renesas,r8a7778" - R-Car H1 (R8A77790) Index: renesas/arch/arm/mach-shmobile/Kconfig =================================================================== --- renesas.orig/arch/arm/mach-shmobile/Kconfig +++ renesas/arch/arm/mach-shmobile/Kconfig @@ -68,6 +68,10 @@ config ARCH_R8A7740 select ARCH_RMOBILE select RENESAS_INTC_IRQPIN +config ARCH_R8A7743 + bool "RZ/G1M (R8A77430)" + select ARCH_RCAR_GEN2 + config ARCH_R8A7778 bool "R-Car M1A (R8A77781)" select ARCH_RCAR_GEN1 Index: renesas/arch/arm/mach-shmobile/Makefile =================================================================== --- renesas.orig/arch/arm/mach-shmobile/Makefile +++ renesas/arch/arm/mach-shmobile/Makefile @@ -9,6 +9,7 @@ obj-y := timer.o obj-$(CONFIG_ARCH_SH73A0) += setup-sh73a0.o obj-$(CONFIG_ARCH_R8A73A4) += setup-r8a73a4.o obj-$(CONFIG_ARCH_R8A7740) += setup-r8a7740.o +obj-$(CONFIG_ARCH_R8A7743) += setup-r8a7743.o obj-$(CONFIG_ARCH_R8A7778) += setup-r8a7778.o obj-$(CONFIG_ARCH_R8A7779) += setup-r8a7779.o pm-r8a7779.o obj-$(CONFIG_ARCH_R8A7790) += setup-r8a7790.o Index: renesas/arch/arm/mach-shmobile/setup-r8a7743.c =================================================================== --- /dev/null +++ renesas/arch/arm/mach-shmobile/setup-r8a7743.c @@ -0,0 +1,34 @@ +/* + * r8a7743 processor support + * + * Copyright (C) 2016 Cogent Embedded, Inc. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foundation; of the License. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + */ + +#include <linux/init.h> + +#include <asm/mach/arch.h> + +#include "common.h" +#include "rcar-gen2.h" + +static const char * const r8a7743_boards_compat_dt[] __initconst = { + "renesas,r8a7743", + NULL, +}; + +DT_MACHINE_START(R8A7743_DT, "Generic R8A7743 (Flattened Device Tree)") + .init_early = shmobile_init_delay, + .init_time = rcar_gen2_timer_init, + .init_late = shmobile_init_late, + .reserve = rcar_gen2_reserve, + .dt_compat = r8a7743_boards_compat_dt, +MACHINE_END