| Message ID | 20161003094503.GC9131@amd (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Oct 03 2016 or thereabouts, Pavel Machek wrote: > On Mon 2016-10-03 10:16:26, Pavel Machek wrote: > > > > u8 (and friends) can be used directly in kernel sources (not kernel > > headers). > > > > Signed-off-by: Pavel Machek <pavel@ucw.cz> > > Zero day bot warned me that this is not quiet correct. > > This would be needed on top. Is there interest in fixed patch? Having both __ and not __ in the same driver would be a little bit weird. So I'd say we just continue with the existing code. Thanks for the submission BTW! Cheers, Benjamin > > diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c > index cd208ca..be659ca 100644 > --- a/drivers/hid/hid-led.c > +++ b/drivers/hid/hid-led.c > @@ -57,8 +57,8 @@ union delcom_packet { > u8 cmd; > } rx; > struct { > - le16 family_code; > - le16 security_code; > + __le16 family_code; > + __le16 security_code; > u8 fw_version; > } fw; > }; > > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Am 07.10.2016 um 18:25 schrieb Benjamin Tissoires: > On Oct 03 2016 or thereabouts, Pavel Machek wrote: >> On Mon 2016-10-03 10:16:26, Pavel Machek wrote: >>> >>> u8 (and friends) can be used directly in kernel sources (not kernel >>> headers). >>> >>> Signed-off-by: Pavel Machek <pavel@ucw.cz> >> >> Zero day bot warned me that this is not quiet correct. >> >> This would be needed on top. Is there interest in fixed patch? > > Having both __ and not __ in the same driver would be a little bit > weird. So I'd say we just continue with the existing code. Thanks for > the submission BTW! > Reason for me to choose the __ types here was that hid_hw_raw_request defines the buffer argument as "__u8 *buf" and I wanted to be in line with that. > Cheers, > Benjamin > >> >> diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c >> index cd208ca..be659ca 100644 >> --- a/drivers/hid/hid-led.c >> +++ b/drivers/hid/hid-led.c >> @@ -57,8 +57,8 @@ union delcom_packet { >> u8 cmd; >> } rx; >> struct { >> - le16 family_code; >> - le16 security_code; >> + __le16 family_code; >> + __le16 security_code; >> u8 fw_version; >> } fw; >> }; >> >> > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-leds" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/hid/hid-led.c b/drivers/hid/hid-led.c index cd208ca..be659ca 100644 --- a/drivers/hid/hid-led.c +++ b/drivers/hid/hid-led.c @@ -57,8 +57,8 @@ union delcom_packet { u8 cmd; } rx; struct { - le16 family_code; - le16 security_code; + __le16 family_code; + __le16 security_code; u8 fw_version; } fw; };