| Message ID | 7cee472f-4dad-7306-ed14-098bef5f862c@users.sourceforge.net (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am 07.10.2016 21:46, schrieb SF Markus Elfring: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Fri, 7 Oct 2016 21:13:57 +0200 > > Adjust a jump label according to the Linux coding style convention. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> > --- > drivers/media/dvb-frontends/tc90522.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c > index c2d45f0..4687e15 100644 > --- a/drivers/media/dvb-frontends/tc90522.c > +++ b/drivers/media/dvb-frontends/tc90522.c > @@ -794,14 +794,13 @@ static int tc90522_probe(struct i2c_client *client, > i2c_set_adapdata(adap, state); > ret = i2c_add_adapter(adap); > if (ret < 0) > - goto err; > + goto free_state; > cfg->tuner_i2c = state->cfg.tuner_i2c = adap; > > i2c_set_clientdata(client, &state->cfg); > dev_info(&client->dev, "Toshiba TC90522 attached.\n"); > return 0; > - > -err: > +free_state: > kfree(state); > return ret; > } there is only one user, IMHO this can be moved to the if block. re, wh -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb-frontends/tc90522.c b/drivers/media/dvb-frontends/tc90522.c index c2d45f0..4687e15 100644 --- a/drivers/media/dvb-frontends/tc90522.c +++ b/drivers/media/dvb-frontends/tc90522.c @@ -794,14 +794,13 @@ static int tc90522_probe(struct i2c_client *client, i2c_set_adapdata(adap, state); ret = i2c_add_adapter(adap); if (ret < 0) - goto err; + goto free_state; cfg->tuner_i2c = state->cfg.tuner_i2c = adap; i2c_set_clientdata(client, &state->cfg); dev_info(&client->dev, "Toshiba TC90522 attached.\n"); return 0; - -err: +free_state: kfree(state); return ret; }